From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77B9C433E0 for ; Tue, 26 Jan 2021 07:25:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6586822DFB for ; Tue, 26 Jan 2021 07:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6586822DFB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F24D8D00A4; Tue, 26 Jan 2021 02:25:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A3558D0076; Tue, 26 Jan 2021 02:25:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36A538D00A4; Tue, 26 Jan 2021 02:25:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2200C8D0076 for ; Tue, 26 Jan 2021 02:25:41 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D5FE7180ACF9A for ; Tue, 26 Jan 2021 07:25:40 +0000 (UTC) X-FDA: 77747091240.22.club42_0916f542758c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id ADAFC18038E67 for ; Tue, 26 Jan 2021 07:25:40 +0000 (UTC) X-HE-Tag: club42_0916f542758c X-Filterd-Recvd-Size: 3748 Received: from 6.mo52.mail-out.ovh.net (6.mo52.mail-out.ovh.net [188.165.49.222]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 07:25:40 +0000 (UTC) Received: from mxplan5.mail.ovh.net (unknown [10.108.16.163]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id 259872368DE; Tue, 26 Jan 2021 08:25:37 +0100 (CET) Received: from kaod.org (37.59.142.100) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 26 Jan 2021 08:25:37 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-100R0036943b526-2570-4cdc-a1d4-711e75c6cee5, 5D556FFD98B84F2EA34A7A8BED120B5F5B9D3368) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Subject: Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range To: Nicholas Piggin , , Andrew Morton CC: , Christoph Hellwig , References: <20210126045404.2492588-1-npiggin@gmail.com> <20210126045404.2492588-4-npiggin@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <336902f4-58e6-0240-fe7a-ec06a45e118e@kaod.org> Date: Tue, 26 Jan 2021 08:25:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210126045404.2492588-4-npiggin@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [37.59.142.100] X-ClientProxiedBy: DAG2EX2.mxp5.local (172.16.2.12) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 85cc3d89-2df3-4a71-b88c-7de071b97d5b X-Ovh-Tracer-Id: 14119066310198463270 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdeggddutdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepjeekudeuudevleegudeugeekleffveeludejteffiedvledvgfekueefudehheefnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehnphhighhgihhnsehgmhgrihhlrdgtohhm Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/26/21 5:54 AM, Nicholas Piggin wrote: > iounmap will remove ptes. >=20 > Cc: "C=C3=A9dric Le Goater" > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Nicholas Piggin Looks good.=20 Acked-by: C=C3=A9dric Le Goater Thanks, C.=20 > --- > arch/powerpc/sysdev/xive/common.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xi= ve/common.c > index 595310e056f4..d6c2069cc828 100644 > --- a/arch/powerpc/sysdev/xive/common.c > +++ b/arch/powerpc/sysdev/xive/common.c > @@ -959,16 +959,12 @@ EXPORT_SYMBOL_GPL(is_xive_irq); > void xive_cleanup_irq_data(struct xive_irq_data *xd) > { > if (xd->eoi_mmio) { > - unmap_kernel_range((unsigned long)xd->eoi_mmio, > - 1u << xd->esb_shift); > iounmap(xd->eoi_mmio); > if (xd->eoi_mmio =3D=3D xd->trig_mmio) > xd->trig_mmio =3D NULL; > xd->eoi_mmio =3D NULL; > } > if (xd->trig_mmio) { > - unmap_kernel_range((unsigned long)xd->trig_mmio, > - 1u << xd->esb_shift); > iounmap(xd->trig_mmio); > xd->trig_mmio =3D NULL; > } >=20