From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75747C25B74 for ; Thu, 30 May 2024 17:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E38536B0092; Thu, 30 May 2024 13:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE6616B009B; Thu, 30 May 2024 13:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAE3A6B009C; Thu, 30 May 2024 13:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACEE26B0092 for ; Thu, 30 May 2024 13:26:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28A5C16110E for ; Thu, 30 May 2024 17:26:57 +0000 (UTC) X-FDA: 82175742474.20.719A492 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf26.hostedemail.com (Postfix) with ESMTP id 06F0C14000A for ; Thu, 30 May 2024 17:26:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="g/yQYHMS"; spf=pass (imf26.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717090015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uyL262HUI/eumvrqhAytpNCfzmfVssZxwMRgLZjf+EE=; b=RYd0O2NIaTV4qmyE+S0N14FpqOwMcJwheJdBW4pvIP7tdrStKV2Nh7X+eoSVQbJQO3x73v 1DX9SI3JNFUt0r5OfYfUOM0wzhmZ1MDEqghWprVzqrg+Jm3kPLYiIZSdtyWw+yDh/r33YK PAXDjdciSLQfCmYAeuWNeVneI0d2F6s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="g/yQYHMS"; spf=pass (imf26.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717090015; a=rsa-sha256; cv=none; b=Ac/77n+1AonRqFtvfYLPJvgdhdRJRfdyXEtIsfeduRbRodVa8pSgS/Hc5MTE+E9DGrI90m YTdy+ctpuXTUULjO4PpQ8TtA0WROWcMQjd7rxnvlwuzeqDk/KmIctABvxd85/ji4gvcQ8F rNwdWOhxgzs3eDzfMikXoKLBv27aBjk= Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6f90679d3bbso33988a34.0 for ; Thu, 30 May 2024 10:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1717090014; x=1717694814; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uyL262HUI/eumvrqhAytpNCfzmfVssZxwMRgLZjf+EE=; b=g/yQYHMSP5JODteuc5sOluOTi4j26lFMq140KX7tT8huW92FMc80/KJ009mYnU2bP8 mXt8VKtvJf/w3dfHi1GTfB7PXMv4pmv+QayIJsMce/yieCY4tz8zXvEfR9/e3l8eRlL8 Yup5fhavQ6Q9tWX5udSAx6dvZ4BnqHACYSHVvUsU/Ntyr8mJehoEkMnMBYkTyzS9pAgL V+NETGGfLD57tAoiRsmpkokeKFUdxCw5gZe5Q3OP830lNrmHcWoixMuLHVpS+cXmDpIC IbNwUbhiG9LsY2Z+E4GsB0sgZVcBE84+yrTHNiLk5OYfig5Mczthj5PxAiP1GnkMeZSp 75cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717090014; x=1717694814; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uyL262HUI/eumvrqhAytpNCfzmfVssZxwMRgLZjf+EE=; b=tQE+QR/gLu/m8F5LU/pYo5un+akmxcJccMQHCpD/eVVAVCXZsMzgShiWqu482veB6i ZZJCF+5AzXGce24MCr/f9yFUIVfrQjAfWrDdgdrM6Y0u+OGpryZKYnTC0MLTHGE+aqj6 GebpjjFzAGEOzKRiPDsDJZ5YZyhWt4Lk+PFoEH9sY/FAU5duuISPBOv+Z4uINFYpflZ1 OX21okwbk1Tc+p/So+qKfdpbvKgolSKmD6bHSi6wlTIzR8xgjNO4qL+avRkE5yegxPjW mX3ErIPCBCMrKUHYZdz9Zcw1sN9+x3XgJ5SkNLrzpbLCJZPOrBqzGc6J67aA1SQt1Ydu imlQ== X-Forwarded-Encrypted: i=1; AJvYcCXjzHfUXnhh5X/HLh/aYoXglpwHybzfCVwaXIjcXY+e7IgYazilorUxbGC2Fg/hikhin0hey6XqbFjtgdCFhbBFybc= X-Gm-Message-State: AOJu0YyMo65LCWgh+sAAkbYa729lphmBpLezockpL5OTnnnNGiuCrl8Y Re6a+Nij1M4UVJIWyfMgXlfdhdynRkSxB3O9y2ESpsqisnVbZPrNb71k25civDE= X-Google-Smtp-Source: AGHT+IHPM+Sum0UCb9oBUyBzm4YvF2v5KhwS+LHQ15UQzZG/KvGFbUm/Dvo9c4ljNRtFqhwKgGLXdg== X-Received: by 2002:a05:6830:4414:b0:6f0:4f53:5128 with SMTP id 46e09a7af769-6f90af74225mr3097219a34.2.1717090013642; Thu, 30 May 2024 10:26:53 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f910550371sm35572a34.47.2024.05.30.10.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 10:26:53 -0700 (PDT) Message-ID: <33676efb-c9e9-4ce1-bfff-954f8aac0bac@kernel.dk> Date: Thu, 30 May 2024 11:26:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring To: Bernd Schubert , Kent Overstreet , Bernd Schubert Cc: Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org, Ming Lei , Pavel Begunkov , Josef Bacik References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <5mimjjxul2sc2g7x6pttnit46pbw3astwj2giqfr4xayp63el2@fb5bgtiavwgv> <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> <9db5fc0c-cce5-4d01-af60-f28f55c3aa99@kernel.dk> <43205d1f-de49-4115-857f-c2c7db28b418@fastmail.fm> Content-Language: en-US From: Jens Axboe In-Reply-To: <43205d1f-de49-4115-857f-c2c7db28b418@fastmail.fm> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 7byujbzmy8pceybccdyx86bsxsjjj7a7 X-Rspamd-Queue-Id: 06F0C14000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717090014-60290 X-HE-Meta: U2FsdGVkX1+PvjWmft9iw133RX3lgDU0rF5HgyNVCBJCor/3TzjD1ktaBW63oheLyjx+5rLfVci+KRo/JC+pdDo3ycLHs5lMOyOAfZBC3LyVoO6SDI8XQ5Xen9gEgdD64hB68qzkcneC4pH/xYdiiOHGisw3kkLX/7eFreXdCW6hAXn05XBd2wedimGXtZ0q/5YHz1nilR2eF1pdiMVcYKfy5rVaIYYjk3AaSsftYrGteBuAnaioPOyxFxTtsOC5Xtfdvryh7b/i33YdS0W+i6fp80kUthD6r2rVsmaVBuDjq2ZsEc0y9bZD8MVgSG9GwuzjELaClf7Y7HJc8ieorYwBsVHPg/ppfX8s2F8V/ooY98VniUfN2Y1zJ0nqiBbdqNxSv4eolrOKzkyLO+DAI/QhtjBZpwMQy6bt6U354tXdAWES3Ie4H7T7YIMe/yQhoEUSeBFG8rzrUEbUUycIIGhN50BEhvhxG/OLSE+fDPawea9dR25lk/tUvEWzZOe1gxY4nvWUYH614CZBBY0y+hnNbglY1mWXhIQaJgnH/tLYAuWdhb8KyPHz1CafV4OlMzSBI7XznbkkGvu+yJWzjvizScy0zxEWwc7VSnlp1C2lI7fZRboNnl4Sa90j9xuIQh8HitN6oDEpXQtSwGY3+JS1uHSBiVSbQ93I+9ATXKM+w1Zq0XeT4oczFJWobur/f8U/PyfYUqvusw9+1nrVHV/DYUidl2W1kxD6fxJKdKXW/IRe3ihIUF0PeUZH1Oo1nvNQlkONZHxVfuOlIvmxFvnpuxs2a+Pt8w5YsTCiq4api/ibLaipwe57/mwSmLQ/thyWN+17VVLgvd24VkxAt5R1aOOgCDbuCnPyGH16IcZiyea9YEXHIVbS13/bJdsW/xGQzWDvqgkccAJs04SWGN5j8Vh40lLePJHyvuy0M+jAW9ny1xVcJhhIY40uXtBAQyAxqbgJur34OtFDPtT 9W2spmz3 +3LkFca+/J3JnLmZEK2Wbk3g17Pt6vDM8HU00uIBFm5sB0cYfQLRQqrUNf6JDGt/0Qd+PhoLBDl/4Tt4jNNcBpLe9w/0nTYpMdKBvgqHXC4lDD6G+oEuYqtTYYYZU1yCBBv4W7c/ACrjryaWzHnOWyhK/uCS/V2VzS/hvHMmIlLN+BGkpqbnIqkXDURaPGTsFiKduHbbDi+SliLpZpc4MsfZj4zwLxrypMDqS3zDdAx7hbrSL9VXvK1YHkp/WVQGaO5UTPgFHvohWLs6qyL2XqV3powsB31ALGc9vwj28mmPbzG9yHt8wxM8EvRyy9a1Xz+rtQRlv2aPqD8Rkfi39VF5Amu+Wg0MNsN1pZpaFI2i4zdqxmsfpXQN0JDP0FcfGDe9fRSHvSBv91hsRfcvg+VRrw+S8Eoaj24P5bOgC+MPBuLsZtmNoDUzvcLf9ncreRu6/okyHRQ1ljT6RpXDb1IDy8YPs3cEo3SvunV+CP55obmvAz6RFmPcJpOPzfrcVpL/iwmnfEUvhJNlzhYZijqJqwYY9+l6H7/MIpMzkU4wRPlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/24 10:32 AM, Bernd Schubert wrote: > > > On 5/30/24 18:21, Jens Axboe wrote: >> On 5/30/24 10:02 AM, Bernd Schubert wrote: >>> >>> >>> On 5/30/24 17:36, Kent Overstreet wrote: >>>> On Wed, May 29, 2024 at 08:00:35PM +0200, Bernd Schubert wrote: >>>>> From: Bernd Schubert >>>>> >>>>> This adds support for uring communication between kernel and >>>>> userspace daemon using opcode the IORING_OP_URING_CMD. The basic >>>>> appraoch was taken from ublk. The patches are in RFC state, >>>>> some major changes are still to be expected. >>>>> >>>>> Motivation for these patches is all to increase fuse performance. >>>>> In fuse-over-io-uring requests avoid core switching (application >>>>> on core X, processing of fuse server on random core Y) and use >>>>> shared memory between kernel and userspace to transfer data. >>>>> Similar approaches have been taken by ZUFS and FUSE2, though >>>>> not over io-uring, but through ioctl IOs >>>> >>>> What specifically is it about io-uring that's helpful here? Besides the >>>> ringbuffer? >>>> >>>> So the original mess was that because we didn't have a generic >>>> ringbuffer, we had aio, tracing, and god knows what else all >>>> implementing their own special purpose ringbuffers (all with weird >>>> quirks of debatable or no usefulness). >>>> >>>> It seems to me that what fuse (and a lot of other things want) is just a >>>> clean simple easy to use generic ringbuffer for sending what-have-you >>>> back and forth between the kernel and userspace - in this case RPCs from >>>> the kernel to userspace. >>>> >>>> But instead, the solution seems to be just toss everything into a new >>>> giant subsystem? >>> >>> >>> Hmm, initially I had thought about writing my own ring buffer, but then >>> io-uring got IORING_OP_URING_CMD, which seems to have exactly what we >>> need? From interface point of view, io-uring seems easy to use here, >>> has everything we need and kind of the same thing is used for ublk - >>> what speaks against io-uring? And what other suggestion do you have? >>> >>> I guess the same concern would also apply to ublk_drv. >>> >>> Well, decoupling from io-uring might help to get for zero-copy, as there >>> doesn't seem to be an agreement with Mings approaches (sorry I'm only >>> silently following for now). >> >> If you have an interest in the zero copy, do chime in, it would >> certainly help get some closure on that feature. I don't think anyone >> disagrees it's a useful and needed feature, but there are different view >> points on how it's best solved. > > We had a bit of discussion with Ming about that last year, besides that > I got busy with other parts, it got a bit less of personal interest for > me as our project really needs to access the buffer (additional > checksums, sending it out over network library (libfabric), possibly > even preprocessing of some data) - I think it makes sense if I work on > the other fuse parts first and only come back zero copy a bit later. Ah I see - yes if you're going to be touching the data anyway, zero copy is less of a concern. Some memory bandwidth can still be saved if you're not touching all of it, of course. But if you are, you're probably better off copying it in the first place. >>> From our side, a customer has pointed out security concerns for io-uring. >> >> That's just bs and fud these days. > > I wasn't in contact with that customer personally, I had just seen their > email.It would probably help if RHEL would eventually gain io-uring > support - almost all of HPC systems are using it or a clone. I was > always hoping that RHEL would get it before I'm done with > fuse-over-io-uring, now I'm not so sure anymore. Not sure what the RHEL status is. I know backports are done on the io_uring side, but not sure what base they are currently on. I strongly suspect that would be a gating factor for getting it enabled. If it's too out of date, then performance isn't going to be as good as current mainline anyway. -- Jens Axboe