From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A5BC636D4 for ; Wed, 15 Feb 2023 15:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 881E76B0072; Wed, 15 Feb 2023 10:04:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 809F76B0073; Wed, 15 Feb 2023 10:04:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AB6B6B0074; Wed, 15 Feb 2023 10:04:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5C3E16B0072 for ; Wed, 15 Feb 2023 10:04:06 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2F1A0140BDA for ; Wed, 15 Feb 2023 15:04:06 +0000 (UTC) X-FDA: 80469846492.19.E31C611 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id CFE6F1A003D for ; Wed, 15 Feb 2023 15:04:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CLAlzP2b; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676473443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AA0HfJf0ghZRpE+IyHbKXXgsU5oTF5v1rWycRLY8ctI=; b=NASTktQKJeuBxnmYbfUYaEkDQSTsDwKJisNj5//p2xJqWVS4yT2qY4c26sYP8PDnmnUIwo uyL5HjQozRXvzDxSM5gc3KIhvhTfjzShYWx+WcCOZZqPuMrLt46Vvl4KYXzK8/R8BzJlZ9 7fAt4/3dk68vMn80gt8XGR39dAp594M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CLAlzP2b; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676473443; a=rsa-sha256; cv=none; b=Uf2wGs+y0kE8jkKJr5bsxMK4n4AUKzMDeUZgi2RvQuOiOqb/mWjksFnWzfYGuBspwl6Cg4 K52X/8xdjYUavMrb0J4zsL0xEehYJfIKiOsa/L/COBAWRkHddhG/v1P70JiQakasT7vZ5A FYB+La7UM2F6EHiZQFKFLtG/gtF5lqI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676473442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AA0HfJf0ghZRpE+IyHbKXXgsU5oTF5v1rWycRLY8ctI=; b=CLAlzP2bv4dU5jG6Sd4SuVp9KAw5Iqw3Wc8Ss3Ba67iz4bVr8/wId2xznFL6d7ovov2to7 L0M+0UHn71HCxJz2N09gxj7Pcb1i2TRZO+VRbJdDI1lI/wOws+I3e/cEO+lOAkizfib3RA 5ezVpPToexWdv42MdG8e55dPoKCV33k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-353-waR7bzIWP4Swo5jl6ha6hw-1; Wed, 15 Feb 2023 10:03:55 -0500 X-MC-Unique: waR7bzIWP4Swo5jl6ha6hw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F21C719705B7; Wed, 15 Feb 2023 15:03:34 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32E6F40CF8EA; Wed, 15 Feb 2023 15:03:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v14 05/17] overlayfs: Implement splice-read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3367218.1676473410.1@warthog.procyon.org.uk> Date: Wed, 15 Feb 2023 15:03:30 +0000 Message-ID: <3367219.1676473410@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: g11cs7pwof4swhqm6tmzjfntj7ke3coy X-Rspamd-Queue-Id: CFE6F1A003D X-HE-Tag: 1676473442-308843 X-HE-Meta: U2FsdGVkX1/7fN8z1AhzoysBKkyXvffmjbBXAckA9tvDWNVv8Uir78fw6m/aeZUayHnQ0kMN+SBOt9GBsuekHgWn+Jn62nb8D70aEHd4w9BRre0wEKTm3P78Q6CsJN95v3vRpF0VHOECWTaKmMqU+74j1ytwnfUn7sqe3m2q969eYWcSzMokK6dWG4I2TSaQPMkkgtmao4pzvsE3zqDUiq0jJgSa48Y1K3Up375djnbkmmAxJ1HGP/O5Ri27Mb/kL9oJOPMuGtl478fA6uQhTYoSJMLKIj+jnYcPDWwiVs9NOg/scouARhvLRNXC4+AzGVKUa48dMz/B5Ag8Epyd74LenJ9DsBerfULU99eye/Fm+Y7byLesebKWWy/0HzUTJ1KunN1DZPVjczD/BgdIpaBgRHOB20F6FS98Op3SSVlPZwNvcmYdnul/TFQqng6I9xwFuIHe7tUWbkm8I804d/3SluB8xEIwcfnu+FeMiHZxU0L32GOqrWLM+XhG7LhZEu/1HYmDl5ZC3tLymn6pbQiBy1c1IE5JP3BHVtbZODcOoj6fSk2IzCrZeWhf8XODjWCJLL627CxgwXldH0MlsvxeIgO0zcWEmTqIb1DXK29z/pIkYaMA1fHYNtQyLo0VzWB4Wm1bxcu7/q3bcNnKegf3WvTJ4WLghm9XCAZ0sGaNSQks9VWW8wyyaY00OBzBTvQrBpSru1rVaNF5EsGfhoBrmapwNEP1QkN3UMQKB46yrZzo5umyYjWO+e3d9VSBewTyeome8LQVW76F60j7W9SHFoDYq5S0Vq1xBuVMpzfMEmI/u+dYyYlklx6YeUwqAoteXba6roOrjlyHYoghu7CtofY3yqH+KHM9tUU3LJMw92FzKyDeV32/7UYH5AFuElLJGd+LEvdq0++uky6QSHJHmyWaY7W5VXh5Q9DYhVTOVR24DNIhBgKYrxgGYRw5dI2AkpeNrDG0TYMgjCj qXCksc8g 2eKhooBEbu7q0Wp6GuqOdaqy5RfzzHWi8GllXflOYC1Mv87JQsBecOqc1UXY1MAfr33Qca5UhCWlJzQxEGpe4j5p2PWtTCdS93e7gJF1LQn1pD4VUtAfthV9KbauSQ2sXR1IkAEczLaFOeOof4AvKipRuZK5VtH4392kgmZhK2Ez2qwU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miklos Szeredi wrote: > > + ret = -EINVAL; > > + if (in->f_flags & O_DIRECT && > > + !(real.file->f_mode & FMODE_CAN_ODIRECT)) > > + goto out_fdput; > > This is unnecessary, as it was already done in ovl_real_fdget() -> > ovl_real_fdget_meta() -> ovl_change_flags(). Does that mean ovl_read_iter() and ovl_write_iter() shouldn't be doing it, then? David