From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33505C54E90 for ; Thu, 22 May 2025 16:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39D476B007B; Thu, 22 May 2025 12:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E196B0082; Thu, 22 May 2025 12:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23D2D6B0083; Thu, 22 May 2025 12:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 06A166B007B for ; Thu, 22 May 2025 12:08:55 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F701BF8B7 for ; Thu, 22 May 2025 16:08:55 +0000 (UTC) X-FDA: 83471027430.11.ED360E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E99961C0013 for ; Thu, 22 May 2025 16:08:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VCS80cKN; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747930133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8wfJZ2JWWh5NDCT76p5yfUNfJs0TBciywsBKTnLT2wg=; b=miwln1nQ+GYPEdXXydzD2eLE9RMQOmfdNAQYPib/Tevapww8b9nXcacE8OVROEzNx7Xg4r 8SxHd+yQkdda5P+korVKYcABtneh75Bcq0cDtnnl69DUIC+lw8et6r9kf+hDnU4e0nwOHB 9Z2Frfq0ji5XUbavwlxZgtxMr4mAem0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VCS80cKN; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747930133; a=rsa-sha256; cv=none; b=RYBj2w0T0VK4U0HH0O7X7qLnYlySkWlLsZiX3LhHnPgMJ1QK6irxl9vdbpOXL9kJE0Ffvm N+zKmqkuc2guBL1EuzldE7aGQRdcmAZirsPxloNwqP4BE73ihzaDQniAIrzhpgDiCfvDE9 h+iQIaAMFOVtDnKGuOhb88GeAyHT1eg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747930132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8wfJZ2JWWh5NDCT76p5yfUNfJs0TBciywsBKTnLT2wg=; b=VCS80cKNFyfQOAhS+YE3uSjDPq+Y8/8aJH/RC8oBvLwoAHpsDCu2YL2MWVqCBVhehGKDa5 w3WgQHrwuTAfy73QA95im0ZqpwhKH14nGX51rEo0vY0uqirE33jl0CSzScFE4agLmGZaWV iHYp1IXK7SnOuRaIPxXndT2SBHOFRGA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-47Nhres4M7G7JKJeQf_eSQ-1; Thu, 22 May 2025 12:08:50 -0400 X-MC-Unique: 47Nhres4M7G7JKJeQf_eSQ-1 X-Mimecast-MFC-AGG-ID: 47Nhres4M7G7JKJeQf_eSQ_1747930129 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a362dcc86fso2730334f8f.0 for ; Thu, 22 May 2025 09:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747930129; x=1748534929; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8wfJZ2JWWh5NDCT76p5yfUNfJs0TBciywsBKTnLT2wg=; b=PQAl+fj2A5IsJN5+Aso8Oz/pTZt2yD6pV2blqI7CGxssMmAp/+K0IVUw4uZQH6s6kx 7nq+/O5QZsVhbokNDfJL1cs5YjjPMuH1CXplMEJ5FuwH20BcX6CuauwpGwKmAQvoAo0s OhpQDwCe33PeqIqVqVibRLok/ih8sysx1w9r7mX2pM6mtZnubbaW41qg6jt221eYjlyl sePJwHqVujtmJKE/75LdFgC/4qGo03fQCoPbitFtCjfCcjRbaruksR+zSXGHOKYzn+G0 HRyMOarS0BOus1gWakegPQFbQnz6Ov2fIlijac/8dhXSKe8pfsoe6CXC1AQkQw0mJBT6 aB/g== X-Forwarded-Encrypted: i=1; AJvYcCVFB7juInUJRx4TkaRl6fMSNJAP8m2tBgh/AceAaU/tu0a86NDumt4xRw9iI6GnwR09CReKAs+/bA==@kvack.org X-Gm-Message-State: AOJu0YyI4rB9PSZxVu18GNgWelgQiY6xCcslg4Wl147dRvGPqmv4/WOC zn4ynWDS0XC4LeQsCJWqJwFP5jSTm9repRwQ5k9DMZ874G4pWmVvbiQpo98pSc3BoDsZd4CkdmP OHaX+QHiiOFvnnVx5UIFifrziK5GIh3jU3KSk2S6uYbypRkCWpfti X-Gm-Gg: ASbGnctFekIzhjwCatqw3KBqT6ZMwyU0mlizxuCHaAnlMZ8hAd/U+P+lHjb+grjnP+P oFvewlh7b+Ok5Vl/mNiDkVpwvDQoH0bzg8CkYofRXN4K4FHpeMx/XJiimSwuPKvK8hvkcDiKpN2 SlXydhGpFyLDA0+fBP99UUrr/YXQpuiwTTXEbTrzRIP/VWb/6jUQli4ES+WdbpcYsbRSb0uj5uR DUki/yl5v1badyx+XW4k094/LC0nI/ugfhOdZPBlNYYTwEUxFOGx/NRp4OHYQ0Ab1o3LzgIf6F+ fRs2Bqfbsk6/jO7BWOWqBtSWVZo0dD2uQ0eBsYlMzZa33tUngwq8WhwLNvaitTB2RqDNu1a6cKt PBHMK3jmGuP1ZqY5DOCbmTmNp72QCP3ex0Rb1LgI= X-Received: by 2002:a5d:5848:0:b0:3a1:f5c4:b81b with SMTP id ffacd0b85a97d-3a35c83915fmr21963166f8f.23.1747930128649; Thu, 22 May 2025 09:08:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESFdDFUXfb74tU7eLRPfNqn07FTE15x+guhR8GM6NgEr4TYOMtIVgXHeIhy1DRApmqlBJW2Q== X-Received: by 2002:a5d:5848:0:b0:3a1:f5c4:b81b with SMTP id ffacd0b85a97d-3a35c83915fmr21963125f8f.23.1747930128211; Thu, 22 May 2025 09:08:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f22:2e00:6e71:238a:de9f:e396? (p200300d82f222e006e71238ade9fe396.dip0.t-ipconnect.de. [2003:d8:2f22:2e00:6e71:238a:de9f:e396]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca8896dsm23406352f8f.73.2025.05.22.09.08.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 09:08:47 -0700 (PDT) Message-ID: <3360625b-2f95-45d8-8aa2-a7c5a4811786@redhat.com> Date: Thu, 22 May 2025 18:08:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v0 1/2] migrate: implement migrate_misplaced_folio_batch To: Gregory Price Cc: Bharata B Rao , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan.Cameron@huawei.com, dave.hansen@intel.com, hannes@cmpxchg.org, mgorman@techsingularity.net, mingo@redhat.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, sj@kernel.org, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, ziy@nvidia.com, dave@stgolabs.net, nifan.cxl@gmail.com, joshua.hahnjy@gmail.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, akpm@linux-foundation.org References: <20250521080238.209678-1-bharata@amd.com> <20250521080238.209678-2-bharata@amd.com> <15744682-72ea-472f-9af1-50c3494c0b78@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9gGZ86cSSfmvbBKK2g7EJ-V22RFGspwiz3ToTWexEsc_1747930129 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E99961C0013 X-Stat-Signature: 41yrx87m6k4mkgi1aq1udpy376anf7zy X-Rspam-User: X-HE-Tag: 1747930132-401670 X-HE-Meta: U2FsdGVkX185lATp9Bkpp5HBAVu2u0tDTYFJKwgf26bJcKd2r8orml+u3yqKke1vhgF+YhWqhJv1yRl4vF8xmLpUmtqs1NFeXofQyeq9J2AeQKMHWRjlhWw5ADBkJSUzPEmPGMtuFNsyRUwCEJfrIm1PqSaDwFU6u/l+UzjzVNNSYUPeyiWPBH6+r7jT3WKnK1xbPuRvu0g7S/FFWA/fJvwvCALFoSBoj9Ao7jmVpeo1EqZJwnrZDbTJb/W4u4QBWDYRDKNGyMbwinY1MudrSRWfv0sLcAMTskO5WrxiZFUriWiLG6oTaNlxtIdZRD/0Jafp8k4/+NnbgB5H/Tg//9Xd7KeJ6BENP4z1SsvOuPwWYT8bJUmSrKTXW1gSD3CPaBm+I3nQFmN/wjqQs7zobXp4JeHXE3c2xzVadLGuAXJWMqnnLOs/nPDHThG6V9OOVteWXC46tXQ4B5dW+p8r+/xdLWuvZket6qcThP6PUprJRAD+QGWLEmKotpQKtMzWFo3VjjIt7EJWQlVs13usQ+G2li4Bnm32PVFSAdwFbSsVbT0+v/1qSkjY/ek0+HN7RM0xEK5JvzrtYdaoRT8urnXSuaZB8SVjbSYX6EBNBibpJUZREbQUydgxYprJb7sd16aNhpEW+vi6SjzkNxRyyVKHWTek+AQmH2mbqscoRZ/k8JA7oXXGV9TCWDX/D1/cr+ATb2/wS+QlSOnLB28FGx+jeCJLwMSgmrNa3MB1Fv8XcNL9dai/msDOb94IY8N1gyWVr44YtncxSkZrX/WX8MAU/ebk5ToIvRbjkJNd9bz2ybTHYbMI6zshMc8Ut4e6BknHx1/ia+XiYrMH8psE1W5rSvSOS7bxnmPZyEWJuo7tNl6QJnDXaGDtizUpM4PTfOKZV7xqceOrei535nCxVt7cWub3+UrtGZ73JRKdCLqmF5PGGCWJspG0d4sRbgLAuue2yeeUd7f6xhCQFoU ikZwccqi xGL8P9lvhX/5brAn5NpC0rygj2cTn5SpR5RkabgSy+q4z0zBLPa67W46LyAXEt0aNpZo30Evo823Gp50dhHoCgMIS7TEEWRZVtoqt72hxmRxyJhqkfJofhb32+dbWGVMm6OOgZ9/pHRpdlNvRlSo69bBSQ80YXNihUnpWm9Gs2gpYbKy85iajVUuV58AMCoZaBV/sKzO/h/7DuhwmMWu7ficzsssAGfbz4pVV7qNpJCZK8OJrXNgQ57drxUAC2iJxQmCoZ1KxxsExZxrOSWL3uH2Uz0uGTGcJG6/QUMjO0fES8R/T2I2MgA4/BHwYeVj1mY9MzSpJp1JqJNGRFdAT20BzsqDi122NtjuflS70oFDbFl4M3AUWm2dOljYDK0ZaNgOuyZ9M+DGTBOc2RUqXLv8W0spoUgzzcQpOgJc/V4INYiAlZ1C3GmhEgJnNnWqPZg5Fw1KpTmeePTLCWV+zd7ED7MgrLGaBkx17SFxUvzvwSQH2XsN9l2itllGQuNyA21HzfpFsCm/+lAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.25 18:03, Gregory Price wrote: > On Thu, May 22, 2025 at 05:59:01PM +0200, David Hildenbrand wrote: >>> +int migrate_misplaced_folio_batch(struct list_head *folio_list, int node) >> >> "migrate_misplaced_folios" ? >> >> :) > > something something brevity is the soul of wit > > I think i went with _batch to match surrounding code (been a while since > I wrote this), but I don't have strong feelings either way. I think we have migrate_pages_batch() and migrate_pages_sync() because ... they are called from migrate_pages() :) For something that "simply" calls migrate_pages() right now, probably we should just call migrate_folios(). But maybe you were referring to yet another set of "_batch" functions. -- Cheers, David / dhildenb