From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3660C54FB3 for ; Thu, 29 May 2025 15:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3733D6B0082; Thu, 29 May 2025 11:10:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34AE36B0083; Thu, 29 May 2025 11:10:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 261686B0085; Thu, 29 May 2025 11:10:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 065D36B0082 for ; Thu, 29 May 2025 11:10:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A7F7280833 for ; Thu, 29 May 2025 15:10:57 +0000 (UTC) X-FDA: 83496282954.30.561C098 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2076.outbound.protection.outlook.com [40.107.236.76]) by imf22.hostedemail.com (Postfix) with ESMTP id D9E86C0008 for ; Thu, 29 May 2025 15:10:54 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TpcuWGO4; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf22.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.76 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748531455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gG5+JIEBFdH0dcB05285CjnGDUr3XJEEMVAwWXvu2FQ=; b=Z2ByTv+bJqL07MP7fwe2zNYcFtD2PJkql8/wxvz85a+xjpEwK5Ai+00lGmdBdVg9yIjZe4 qhslv/jeGQoVVW5I/Qc5IwZW1SXCIQPlzbU+uMlUACNplvM7EglBxmU58DnCaFOqz1LqJ5 Y//DiKEZQWSKll/YW6ISoSxdzmzKRQg= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TpcuWGO4; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf22.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.76 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748531455; a=rsa-sha256; cv=pass; b=U+TNShxKSwGcYSiwx6NKG5bsIzsko82v+Oxnhcm1yg4Zlew4fOJ/68EncfQFD/rQHm3p6y FHX7+d9dNgBiW63UAuvTibpwWFOaLZCtBkp68wlR9URNbAErdQ7pgL/Lv2qshkSVowi9I3 HRshrUHorYeZwn7Ii3y3ipT6U0uCPRM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yG8EE60E65ual2NgMV0C840uKLW22ufst0Y+qk/MPosIAlbX/palEpva/QYOL3k3ffPmk9hb7bzK6TL7Zp05QWnkiNdK/6SNueAu6557ur2vTKanQhZdw5DuUt4iybQoNH8GPVlJ0RiOLgopfBqNwfZwUmrCv9sYYMMWUfTVrstWzXu1kqO+Q/YYRLckjrEvA5JwjV5QWteiorkO4q5YjFZ42yzHObwgSU43syIHwLI8r46SyfKw9gjUhVJjtViUc4rGIkb7ekxBc69gh78tlPp0ZKPG2XA5Vzaclp5KqhJrn0YYS4ncw+QpMhCiYJYEFdmjnY60fnsCRNJ0POzXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gG5+JIEBFdH0dcB05285CjnGDUr3XJEEMVAwWXvu2FQ=; b=toWsOprj3ZCCJN8EGfOkO5eZiJ4k4GlEPbiN4sFVuOFfooOfrHKVhAcp2BuWvQnF4Htaz2H8tMVUkDA/u4lEy0EW+a7sZON927x84ZSoMiaELwamoURwZvGCBc5Szx6bBR0+PDOr2fR/8sQ6m6fcmlXw/nx2uWQZ7cbTt7JMwwuHWoDkJ60FZaQ+c3nc+SapFsnW9qaqbA/C12fXsYJ1uykJPxm5jk2CzEmqO+/6uaBI87a1MYh+d2PIoCjN1kUANbFd5r2yke7A50RBoB74hg30SeeUTHIQE3Gu1bHkjD0+YPIHWgJ7maz48YG8kCxqe4RYYOYlCCpK7XNPYMfRfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gG5+JIEBFdH0dcB05285CjnGDUr3XJEEMVAwWXvu2FQ=; b=TpcuWGO4D9ACtvP9zjyxCx+Ehvzc2Hu/kPJrxSF9rgLBkbSWvP3++cO2cizfNnsgxRI7EGA0cWp9bv19tsOAFuJT2K6f9Wdn8+E0KrjhNIlNby9lRfvxM2rEJkP72ahQli8vdHhLviWvg4TG86YO1u15SX1jaRyb8ve3X0CRogI+aCWLhpRNza7oeDPFPLf/I+oO4pMI3NahJcyHzviMolEjTSB3B8uIVJjinEpMb2eDgTmdh5Br8KPiYgEPH85AV7LPQwmfy5zBcJwRy9CZ4pPfAbiD+U6WYq2BICh8HkdW1QXk+9hqjWFx1nRZREDtz1Y2GC4XNiD6T8HeFCV73Q== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by MN0PR12MB6366.namprd12.prod.outlook.com (2603:10b6:208:3c1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.31; Thu, 29 May 2025 15:10:46 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%4]) with mapi id 15.20.8769.025; Thu, 29 May 2025 15:10:46 +0000 From: Zi Yan To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled Date: Thu, 29 May 2025 11:10:42 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <33577DDE-D88E-44F9-9B91-7AA46EACCCE8@nvidia.com> In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LV3P220CA0028.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:234::21) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|MN0PR12MB6366:EE_ X-MS-Office365-Filtering-Correlation-Id: 73c74235-e95f-417c-41bf-08dd9ec2fcf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cE0pxXiJ7HtvMsxJDRaBar9rsPxvYAGhT9L2URP3487oYUGig1pJ//N6kIxY?= =?us-ascii?Q?NCtf9ZpAqfelWtx6Na5uyd30Hxyp0Ypr6oU/8W+0vgmaQvO/NOjAKZ/9aS6J?= =?us-ascii?Q?lspBGq0datkyJNRJbqVH7+4X3NKzjpPtgjV0evbZlXsvbnKZSFpT2EWXtUVU?= =?us-ascii?Q?scyVmPWZHOHa65+Z6wfF3pRJzoBZ7H0tJCJg6Oy1XSTTkKmFXPNy621FeBG7?= =?us-ascii?Q?mvXXXn7zIm8vSLCI63CIlf77LgbNUxcZ06t426R61+IQzzEQ7F1XlocenDUN?= =?us-ascii?Q?MFD5G/U0r4qxKypFzyxFucFStSHfyzicbOBhj5M+Yg2qaKlVLoG4w4aAR3hO?= =?us-ascii?Q?0qUBDYILZvMQkwix79r2RLx8T2ehOzGw3ZCQgOkzWVbaf4aLJO+hf0+uFpJd?= =?us-ascii?Q?4t7/HSg1upqIlp6jhZpKOQATpp8TW1AsLWitYA4uUbaKRVeWkNUGLmZjOIjp?= =?us-ascii?Q?2cRsSzgrALKet1LPBqbZCo9tAJAJFKceIsgsnFk5v/M8BQJ2mRIj5XKoESkL?= =?us-ascii?Q?RzTjvoCli+huXKAkHvW1bQ9xeGoePP1+QJh3V2PTzVyIL8TlM/sC8n173fOP?= =?us-ascii?Q?0M0hUciS08byy4FSwCYtCWDCgPxGORN0v7v0UsF2K146F8DQbmmHEc9q3dqW?= =?us-ascii?Q?7Nns+cYrLFFuuz/LnMXXDrkXwbFlSsv1V0RKeNXms7kuSzeUj9F2jJL+elYu?= =?us-ascii?Q?wYwLBmKD8Hy8gPJbd0ffUCFuM1REx3nRn7e7IgbH5eKCSiDB4yMcF9yTFZso?= =?us-ascii?Q?SgDfU3x+pB1mC4wf7eFQg0umRDN9SvK/n6W2b2/N6qE8xiWJgo0ysY0+l4XW?= =?us-ascii?Q?/Ls5h4lPG6avlbj17xXEPPYbDKdXDiqJ5OyygEFs2ATnRWJckrXNnrc2+FQS?= =?us-ascii?Q?j63ez8BtvPB3ZNJDq+xrpisgK2A3x3l6SooOAP+bkhTjYLGGrlQGElgBJJ5J?= =?us-ascii?Q?TMEWjB+FKhTM1Ij5AnlKAHnP+HYIWCjfbSh7ya2v9AFZ7KZiVnYSQDubcqJK?= =?us-ascii?Q?yXHASDeTTtzwFlzKpQmIPZ7StC8N8v5jg/S7nN/UCtJgzoiWF4yzmOqXV0Zg?= =?us-ascii?Q?0ZFfNb9qmKygPQ/ufmS5s0SPaodHn3bw3I8kV3yCcKpRn0ub+z+Vhi9F+DNL?= =?us-ascii?Q?4sNLoGBHD1h1ytpmBMdjXj5iBYbAFa44DppD8Sh75MOjwACgLetP9zUnU0Zz?= =?us-ascii?Q?tv4WW4qOKsz2FtfVZ/kg3wous4mpZqwi26GjVfEM15a5MhgCTNJKPA7UsIl6?= =?us-ascii?Q?vLJUu94eiqrXoT/ctm/bl0j22p/ClnzmTIw9e/oObec5h30zBXSk/dDmyLu8?= =?us-ascii?Q?4y0n0PGxTD/zByGLuLvTCq5CSeITBIAkYYK+MXaKKpzWkeB8NWz4JD53nupc?= =?us-ascii?Q?fwiZvQek6TS9DP5YqQtDt8u0cjN6avll4cIfzhIvItPpes8j4dW9NAJQBxs4?= =?us-ascii?Q?peW8+scDKc8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bIETvSkelJJg+lvjiBBsf+k4FTSYzN8+ZMB6P0VlHpym+NWRgKGrzU0qpbjt?= =?us-ascii?Q?liMMEsAFbvF1aAvREepK+bzggI1QlXvYW045MTKsT6ZK9WJ4GpEs8BVJ77sN?= =?us-ascii?Q?D8a9J3B6wWsdTl6NIwWKLCUoANwd34t9qDVMiWMnN65Lo887tci8p28QuzDT?= =?us-ascii?Q?QZlzraNWduryTNPzd947KKeqmG/nr1ooO6ijzC8T9TXWdSeaPxgQ2J1v2oay?= =?us-ascii?Q?HGa8RO+7jxHxX3wUIHsMW5BPMBqDorp/NjvamwEI7faEx1vlTB0t7W20Rd42?= =?us-ascii?Q?wCrpcT8lauuU2D+QCIMoo3oxU4BlYOvsE06u2IJLHcPrWxt+YpWveZKVQAmn?= =?us-ascii?Q?Lp+HpfKGGzrYHT3TA6dGmzHLnOGIlovGuYFNPOcx6hYn/V7D6fYuMBy7/L+F?= =?us-ascii?Q?KeKnQUgbyHuv22gBo6aDZKtPqVILTApYjyUYIpszJVOzRst43aIlbzdQzmnv?= =?us-ascii?Q?x8b0lf2j/FSgxvZ43o4vlQ8MV5cCsq5gvawe4oLPnHL4deHRejl5YkMy6SOA?= =?us-ascii?Q?lfXWvt4ncxfjKfpNRe9GY3i/cdUyqnzrftkXGYPd3pgRmjyw7iBHjoceyBjC?= =?us-ascii?Q?6JzKiSsSkOxg9eKQVXGy9ctTH3Txk23CycIvTEU9MaybLas52Kv2U3FuENkz?= =?us-ascii?Q?FiqJGOu7O3YAMbLGzCX9RlfsKEJ0oT3nqqLrNcRBS6hdOWuM4g0mit0BhpgW?= =?us-ascii?Q?DSULVUBgfnwoI9B57nFZ3m1fGHcKRiQuQgiiV5/Ry3wwEacVwKkKTOf4Xt5V?= =?us-ascii?Q?lUBe6xzwwQjmS3qng6uZueNtfmf8du2ZF2CHf1mMlSpRWGIRV3Cu+g5XEty8?= =?us-ascii?Q?gxx06sW17c62maNEUqoAaSdMiWz1Edil0e0zkbVH6joEgg9hIeItrTmrx7ij?= =?us-ascii?Q?I3y01Aq65ou6zEwUOKBHTNNKLqXNjwYWV+SQg7cwVRAZsAb/Gcdx+OYDI6Tn?= =?us-ascii?Q?zQSnFqhQ82+SEFkS6RuELCCREmOFq51hFJw4RDaSq4uNfRVFwaiIRFMlARPm?= =?us-ascii?Q?zyi6NNf9SgWTVEluxP/F/g5YMknCLphjm6w0HM+bbsnMDya7GY0W5N/qoNvJ?= =?us-ascii?Q?GX7/0PvySIb+D+TX3QpoCkQ4ijJ+3tRjZhaB+64yrvJ/eI4O5KC7MAt6OeaE?= =?us-ascii?Q?lFRPx2Dm6Mp+NPKqiXf79n8qeLBe8XAlNp8Bnqbv3sHfZdocDNvtCcYPHdIT?= =?us-ascii?Q?2Ra7qPg1MvywcDRdMB4ZLqaA1nJIK4PWZHG06Yudl/j9BbGX9eTWmQGJCQAB?= =?us-ascii?Q?WzGOYb5nhBJvtvf1Akp9BO6M/YyCn+rXgEwVVNVhFkYNR+rhHwbh4aWOnrIN?= =?us-ascii?Q?b0ObFcQFaDva3KnVXLtF9HbOSzN+lOxMqn5uwCCV68GhziskYB7pbylvHMex?= =?us-ascii?Q?8eS/QgAkzf+wK9nSDFJCiosk+P89gB9+YZziLSJ84CCxfcrHWBg5EY46rL+c?= =?us-ascii?Q?77t8kkD+D7Htz93nO7tlB+kZAoscEyRCoheU2hdEJQvk8p6O44Nkv4xNCtt5?= =?us-ascii?Q?rlxG9cQescUKVnAYUwhn4ayJf0bk6YYT7buCXipoYIoGJ2Lu4g2hkUtBNykN?= =?us-ascii?Q?cYxM3bfU4+VgR5jhdCHjo7Y/uhIjS/GaJY47Wml3?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73c74235-e95f-417c-41bf-08dd9ec2fcf5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 15:10:46.2593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rrWDpJmeW/WWBymVtZLsR74kjiEVd0+vnGmlzj3pkwrQDLIFH3rQBbVjK+jmgEit X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6366 X-Rspamd-Queue-Id: D9E86C0008 X-Stat-Signature: mfdgs6hp5huego6r468nxep4n1dq4xs6 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748531454-212541 X-HE-Meta: U2FsdGVkX1/4Y97oYYTiETD0eh1MVW5LlU/NR2aRmAVnI5pPDGfRsq2kwE+xcZenRgA9NG7x7ZbBWqZxcWECRRJzpALBsFcFdx35t+nJzbg/l/X4xkIh9IBbyzS/Z0YQT1TV0DUvOHqC3czZwMeilbwoOpW5szMnTlSR/drB2Ymqg1SmxnyEGf2y6Z+xdziiyHG7FDnNaVwBCca+T3bSRUhznBrL4nzV6r5AsYAMsaRm9gjx0IwWUbphfQhg2r/L6/62kyxuQGHDMNSOIuR9wTTqoHxxGE54u+vINLh2fbNUNMwfBw0AxnH6l9QU5GxL+lKURN4xMTJJD6xsdWut6Ih8WB62ePxWgJxr/aIVyubUB1AVpz7sXnJ4NvqNEnBGPAvdeXeBdlDkSm9wk4dT4ycbjjPcdmZjFqM4A3X/7XHC08+2pOodZ9j92lV3iyTFRpWI1swKlWGtU421MTTbjUDTDTiYcb7mWUhFM4nZiKEGEUm8Rp9J75i0rzR5OoxvwfztgCFAPY3N7P4AnqaMSVHBnmPOVqbk/t3qDRu3RUAnv6hK3CB3RLt+oaCwdMWl3Cc5ni+BeZxMJca/W+Uu0XJlNgq4fsPr8OJ4St9i/AKGA9cw1Xy6RMTDn6ckpVGpfm1aeMG23W6iJEy3xCAIVLqNTBE6qifiHpfJMyvIPcBBO5oAG7VolGHPhbgrQZkEucm6krj5mHp588VNJ1iwlYoZiNJJVxK1BEGTxFmQvZtnkONPbRhwU5QwHFFc/7veTCEACrbLsW1i+Aq1tnvstdsxopKzsqXXnmsRv3WXzba12lhZxpDGx9eGtMgwmZ89kygNGdOK8gdKn3p6MdpP/y+j504l0T9CJ9txWa4ONncPuPiEC8uOyPEiUc82b0C0UUhVj5d1MZiSe/NCWJGTrJo1TKQ/s4ix2wYDYVx/qn6JdW0NPOAh8si2WpZwhx4I+3iFUErIRqWJhvlrdDc 1E3G9pP3 gkiTuqLFrKuEwvhhtLAutlvyoBH5HmPUmrj6IS5dvoEk5ovwll+yRm0j9jXbIqagBbdOzEq+Web/QfasFfxGQWZeBgJ7v37gOR2NxveIvtcVSmCeNyZlDtZd4vKwq03OLJd4N7WyQlcFebP4xT5JXN2LIae91cmFG/6TzjRDc5gRYk++MMw+hjLRpXOBpBTb0lC89zAz8WI8iaDkXuX7x/PAzIAyiL66JCyLnyFBvER+THMDyTLa5c3E3k57vPlYZNHr9GsMMtd0dWCL0kupm8KElusnZkSiaZ40/HA8071lVXRhhRLjBAzdOHuIK7h+IsMBgub3XrLpd8ofGgJ2XyhTc/hOZUvz9TGUVuvTC0+a6XmRwL+jI03lHJcmcnQlZUKs2M25ZbV1XzENb+tAL2HRIntCrPCXlhnteDLpy0Q3wjvrlnRLdsd1RogNScWjRvkYUPqVflCBCO4Z3kwOoEUr9jZpzrqNtlNDajav+//YYfQA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29 May 2025, at 4:23, Baolin Wang wrote: > The MADV_COLLAPSE will ignore the system-wide Anon THP sysfs settings, = which > means that even though we have disabled the Anon THP configuration, MAD= V_COLLAPSE > will still attempt to collapse into a Anon THP. This violates the rule = we have > agreed upon: never means never. > > To address this issue, should check whether the Anon THP configuration = is disabled > in thp_vma_allowable_orders(), even when the TVA_ENFORCE_SYSFS flag is = set. > > Signed-off-by: Baolin Wang > --- > include/linux/huge_mm.h | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 2f190c90192d..199ddc9f04a1 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -287,20 +287,35 @@ unsigned long thp_vma_allowable_orders(struct vm_= area_struct *vma, > unsigned long orders) > { > /* Optimization to check if required orders are enabled early. */ > - if ((tva_flags & TVA_ENFORCE_SYSFS) && vma_is_anonymous(vma)) { > - unsigned long mask =3D READ_ONCE(huge_anon_orders_always); > + if (vma_is_anonymous(vma)) { > + unsigned long always =3D READ_ONCE(huge_anon_orders_always); > + unsigned long madvise =3D READ_ONCE(huge_anon_orders_madvise); > + unsigned long inherit =3D READ_ONCE(huge_anon_orders_inherit); > + unsigned long mask =3D always | madvise; > + > + /* > + * If the system-wide THP/mTHP sysfs settings are disabled, > + * then we should never allow hugepages. > + */ > + if (!(mask & orders) && !(hugepage_global_enabled() && (inherit & or= ders))) Can you explain the logic here? Is it equivalent to: 1. if THP is set to always, always_mask & orders =3D=3D 0, or 2. if THP if set to madvise, madvise_mask & order =3D=3D 0, or 3. if THP is set to inherit, inherit_mask & order =3D=3D 0? I cannot figure out why (always | madvise) & orders does not check THP enablement case, but inherit & orders checks hugepage_global_enabled(= ). Thanks. > + return 0; > + > + if (!(tva_flags & TVA_ENFORCE_SYSFS)) > + goto skip; > > + mask =3D always; > if (vm_flags & VM_HUGEPAGE) > - mask |=3D READ_ONCE(huge_anon_orders_madvise); > + mask |=3D madvise; > if (hugepage_global_always() || > ((vm_flags & VM_HUGEPAGE) && hugepage_global_enabled())) > - mask |=3D READ_ONCE(huge_anon_orders_inherit); > + mask |=3D inherit; > > orders &=3D mask; > if (!orders) > return 0; > } > > +skip: > return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); > } > > -- = > 2.43.5 Best Regards, Yan, Zi