From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851ACC52D7F for ; Thu, 15 Aug 2024 06:32:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F91D6B0082; Thu, 15 Aug 2024 02:32:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D0826B0085; Thu, 15 Aug 2024 02:32:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9EE6B0088; Thu, 15 Aug 2024 02:32:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D10216B0082 for ; Thu, 15 Aug 2024 02:32:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 859721A098C for ; Thu, 15 Aug 2024 06:32:18 +0000 (UTC) X-FDA: 82453510356.26.09FF7DD Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf19.hostedemail.com (Postfix) with ESMTP id 8A3FF1A0004 for ; Thu, 15 Aug 2024 06:32:16 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WUI6QmJ3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723703455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nt+p09uz8tAqwLeLii8cPw/zrSYX75ywbDJiGCl6kRA=; b=F5mpy4mFePu8T400lN0xo3T6wuTPypOWjjfUJsckMFGA0kQJM9ls5X/dwwBSSKfGs2KWEd WJLpXDNV6Ie79acDvbPFltWtNK7XvO5C7mA7/+3HzFbbgERg7qTktlL6H9Qx3ooYy/BxJ6 38v3WgnLQKxIhQ2OG0VYKArjHyuyY1g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723703455; a=rsa-sha256; cv=none; b=fjhSFleyL5sTvQ4AUfIV6PF8mXzKOPvgmn7WfvLU7BC6YZsbu+ULIuCbAE9r6+AmxLbkaH hAK0fVid6kXlCsTApG0AfzdGd9rfiZU5HYAeu3N/OQwMIpqBn0/nAv/XPiXsr1KTNLvNQy /y0Ltm361IaIWICMvrmQWNJpcdjojx4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WUI6QmJ3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fc566ac769so5972515ad.1 for ; Wed, 14 Aug 2024 23:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723703535; x=1724308335; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Nt+p09uz8tAqwLeLii8cPw/zrSYX75ywbDJiGCl6kRA=; b=WUI6QmJ38tBKby4tnnXO5V0NKnJDA238Or2Z5Uyp5JfvurZVmpMcrx8O4dzRq0Olrw 505Iu0UofDIAGj1UHFFuNL0dHEmodo8EpAb9WK33Pae5U05TqKkAjWJTMDIXBjwxyiPd xPOeVnDR7La3c6V5hI297wjLRS6+pgFTLr1Y6MDtmtupl5cyiH2cqy8ZKXUXTEpd5qCx tuk7HAL3XIuC3tXoXK7mRV8NpD1CVZupEQti9f+FzqDzvuVLmwgOGGuCTN+Sf4h6q6P6 5EU4PWdD5M2EhPqVhzJVHCURqbVK66MFus/EDY/wqRChemRycojQwcj1l+8Qp2cjycr1 cT9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723703535; x=1724308335; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nt+p09uz8tAqwLeLii8cPw/zrSYX75ywbDJiGCl6kRA=; b=PbDJmbwu9sTpMQr4+d3Y2J2tecp0sCrspnmkDY6oO8MyB4tyZiFh4+OifWXCDsDIgr iQJcZHJHcemN+MqsaE/biZayVSUvduWYf06MYFNsbyM9PSrbv1sG9PW2XItXtIJEBwqZ KkbgWl2KSUx1rJOfzYz8nMRAsWCaU+h8J6ukaLugTRkRQp+jxo+bDsmOyk9XjsD0nqnk wXG96h/mnNsccsIpSli4AREFYfI2bCVbBrklo2EEliwzUbYVs9RxYJJ7YvQjZsTa3f/t MNvPL41UwvA70hNGOaoWe3FCj4wdlkJE1HaO+AxTJ5taAKPmtFGYvCBDz60RRF/i/3rP 0lPQ== X-Forwarded-Encrypted: i=1; AJvYcCV9Sm+TSpIDnPw/CNzE2cQFYj8oLeR9Gp4z1tRsk+t84bJ1EumU62f98ei5SFN75iIBIeJ0UoOi9KmHC+lLzUbBF48= X-Gm-Message-State: AOJu0YzNgF7hqTna9jQOOLD3qSnbywxUlXdqH/Rx2K7u2wHlRIeKAV12 6gzBs7BQFKglY7runYQ7ZJcjhgox6gfkWnK1sANoPZVvSnB6A15k X-Google-Smtp-Source: AGHT+IGHQF6v1wj4OnSDtmW1i+o0W3hXKMZnU/CMxWJVexuFM/VLhfFkwN0de8G4/UHXSn+MbeyB0Q== X-Received: by 2002:a17:903:11c4:b0:1fb:cf82:11b4 with SMTP id d9443c01a7336-201d63bc296mr66187655ad.6.1723703534763; Wed, 14 Aug 2024 23:32:14 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f039ef06sm5216095ad.249.2024.08.14.23.32.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 23:32:14 -0700 (PDT) Message-ID: <3351b0db-4764-48a4-8bab-478ba7bfa4f4@gmail.com> Date: Thu, 15 Aug 2024 14:32:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 00/18] use struct ptdesc to replace pgtable_t To: LEROY Christophe , "alexs@kernel.org" , Will Deacon , "Aneesh Kumar K . V" , Nick Piggin , Peter Zijlstra , Russell King , Catalin Marinas , Brian Cain , WANG Xuerui , Geert Uytterhoeven , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Michael Ellerman , Naveen N Rao , Paul Walmsley , Albert Ou , Thomas Gleixner , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Andy Lutomirski , Bibo Mao , Baolin Wang , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-openrisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Qi Zheng , Vishal Moola , "Aneesh Kumar K . V" , Kemeng Shi , Lance Yang , Peter Xu , Barry Song , "linux-s390@vger.kernel.org" Cc: Guo Ren , Palmer Dabbelt , Mike Rapoport , Oscar Salvador , Alexandre Ghiti , Jisheng Zhang , Samuel Holland , Anup Patel , Josh Poimboeuf , Breno Leitao , Alexander Gordeev , Gerald Schaefer , Hugh Dickins , David Hildenbrand , Ryan Roberts , Matthew Wilcox References: <20240730064712.3714387-1-alexs@kernel.org> <392b267e-cf98-4aa0-bb6e-90f6861d097d@cs-soprasteria.com> Content-Language: en-US From: Alex Shi In-Reply-To: <392b267e-cf98-4aa0-bb6e-90f6861d097d@cs-soprasteria.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8A3FF1A0004 X-Stat-Signature: hqe5fm959ycxehyis4q75jyqkabatzff X-Rspam-User: X-HE-Tag: 1723703536-479506 X-HE-Meta: U2FsdGVkX18xvGPaHLaOW+aFfp/863qkisRUe1bOFaq1ChwnSi3vAmXfnga/milLpg3/RvZuIe7c67LIbbr3eyYQYRV26eo0WbxB1+SetUUCyTJjwFMbGiOk1YNRgfekf9jPilNZZ4QPv01v49mZ+FuTHYGgJNW1MAyGd9efIu/+bBkmJfNxsTH7zHABCV6NLsznI5wo3kJ6DCIBqwtlRL2cWDctsTvjx0SP9UGDnTGHXNKdams+rJWqc600RQSB9w4rGVRMk1uLH97Cj3dTMaf6zS2B6ob7Y2aV7SoEH+FqrNRA5oXSvPzHg6EWXi2HNhjkznTmbA8n0SAkzNECxLqugirgk+CXcLOnn73IaaMWgMtSABnBtsOkQHegLSS+XITdEIAxOcDmgvK0r63nyNKfBdH/Fm89nsJ0c8ge9jkbz3wciYWaHhShtfnJr5ycygDFaq1I+SLr9vpygAfdx0ixxqTFQKZac2ubUwCuMgkZo955tnlrcuqyfBn80QteIZRbrAju8y4HN4HJvkOq/b4WWIa0gPPPTKfkJ1YhGq95mOvLlRwLzLk+1d9T6gH9t/G707XavBv0Yx2a3PluOVsF6AjeZqw5QVmHqiIqDKfAHAKxzbdTwMR4UZkJ4hPm60xF35lbuj389Y04LjLbxV970FUzBTNaeOGT+O67TyhjpD+kvTifc+J5h92PG8Fnh+3B8CTnG4TiwsH9F3g3KUtrBL1XqVRZO3S5lKHhjHsezxuaWGvXj0cwB7mHSCC/OkkCtW5XSbHrWtOzgK8xFD6WAoqf08++IPnnZ/+Ssxxb4nAAbP+s5+mFQEjZlzCc7sflVWlSOnmx5na1RXrvhoSWfSjAOrjTgEGYaiipStrQB5yw6+8HrM1ECFsspFe5531el+NKwWUWZCug8rtbdu3dunPqUivyyo/N9D44D+hSKAdfjRjjgerN0gnpP8w/C4wgWD8RpV75ojgOWOV BnAcXB4Z pj9FLRDuBEaU+bmhPyIJtQ1eEdyoqYGIPETPp5VVH09xuDV78V4W53uiN+EQ3gKqqaEEZDlDTAGn7Oxx4C3hSQoref9zadAiV+l312aQ9zmYfBskiR2Rl8GdrnZs5Hbwthac/eFPJ5rBaOzx4SfzNjp89pVwobhNyGqgS2owpNVfHNToQzEZd2Z4CQJ3fVM7NgHcLRGOnbW7HccCIqYlIzI99pBR7eRutk4YXAFT6sR/gbpwOo1oXsTeYEcX9v6EozVe8qNhFQqnpMNXeb/2kcbl9gAKEiBiMmPgnE8qHDpiVVdti3bIHrmShCRYBExKnI9P/2F2PaqnWMLPvyOTcIkwTvC2SbDwS+TiB1HwPJs6HJyRK5naKyAP0B8wSc8RteSAfnwAbLbAJEwPbK9oET4+KIDNVs7YX07dGe/NzDwdnBFsL3R2+4sOL2qt4c00ZPlGCebfxzhidE+lg9+mvF7YWkqdbtJBVaqDdZjVPb42RHtywwO/4IgrXXAtLjS9j9N+xbyMHzWc64lXqLQ3VT94QK6tu47WPMYZXNbb9Hl9cSfD/8t8x083QtlXGX0RTlJ/UmQ1ORtgrEgJGdg53cI/fgOwgqV81XXKUXFSK1STKNrsM1qWwdA6sZKTFo7kAEmdtpGiSS7aqA11AMj1+vBrNexWELhFEBMpMVEFr7pgeeUhF/bEwZxV9FsFdoP0HfUDC+oIta/AHGjssvRcvirUlijIzpEVGfG46 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/15/24 12:50 AM, LEROY Christophe wrote: > Hi, > > Le 30/07/2024 à 08:46, alexs@kernel.org a écrit : >> From: Alex Shi >> >> We have struct ptdesc for page table descriptor a year ago, but it >> has no much usages in kernel, while pgtable_t is used widely. >> >> The pgtable_t is typedefed as 'pte_t *' in sparc, s390, powerpc and m68k >> except SUN3, others archs are all same as 'struct page *'. >> >> These blocks the conception and code update for page table descriptor to >> struct ptdesc. >> >> So, the simple idea to push the ptdesc conception forward is to update >> all pgtable_t by ptdesc or pte_t pointer. But this needs widely >> knowledges for most all of different archs. Common code change is easy >> for include/ and mm/ directory, but it's hard in all archs. >> >> Thanks for intel LKP framework, I fixed most all of build issues except >> a bug on powerpc which reports a "struct ptdesc *" incompatible with >> struct ptdesc *' pointer issue... > > Can you tell more about that problem on powerpc ? Which defconfig for > instance ? > Hi Leroy, Thanks a lot for response. The detailed error and code tree is from LKP: On 8/3/24 11:26 AM, kernel test robot wrote: > tree: https://github.com/alexshi/linux.git ptdesc > head: 3735e634f8feb67c941d17222b53906ace2fd2b8 > commit: 8ac2ea5f299444d065b292043aed0a1e94996159 [14/17] mm/pgtable: use ptdesc in pgtable_trans_huge_deposit > config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20240803/202408031130.UnwgnuLS-lkp@intel.com/config) > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 423aec6573df4424f90555468128e17073ddc69e) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240803/202408031130.UnwgnuLS-lkp@intel.com/reproduce) > In file included from arch/powerpc/include/asm/book3s/64/mmu-hash.h:20: >>> arch/powerpc/include/asm/book3s/64/pgtable.h:1372:52: error: incompatible pointer types passing 'struct ptdesc *' to parameter of type 'struct ptdesc *' [-Werror,-Wincompatible-pointer-types] >> >> Another trouble is pmd_pgtable() conversion in the last patch. >> Maybe some of arch need define theirself own pmd_ptdesc()? >> >> This patchset is immature, even except above 2 issues, I just tested >> virutal machine booting and kselftest mm on x86 and arm64. >> >> Anyway any input are appreciated! > > Can you tell on which tree you based this series ? Last patch doesn't > apply on 6.11-rc1: The code based on akpm/mm-unstable tree, not upstream, you can check the code on: https://github.com/alexshi/linux.git ptdesc Thanks a lot! Alex