From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C210C636D6 for ; Mon, 30 Jan 2023 10:33:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90DCA6B0073; Mon, 30 Jan 2023 05:33:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BE6B6B0074; Mon, 30 Jan 2023 05:33:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75ED76B0075; Mon, 30 Jan 2023 05:33:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 693576B0073 for ; Mon, 30 Jan 2023 05:33:52 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A989AA123 for ; Mon, 30 Jan 2023 10:33:52 +0000 (UTC) X-FDA: 80411104704.16.DB2B325 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 5730D8001E for ; Mon, 30 Jan 2023 10:33:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YfHn7bHa; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675074830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oT4/+Dsw5hQNhjDNcfeDL08lroMdeVaKhV4kansN0pA=; b=3KQdbUnmQlwAwa6dss0lfp3fXiqpsQfcWyNf1hwsmbckEdiaPtrckoNNIOzCfOBAZ2nkTi NiqYh2TTaB6nKlMZJPrzgTJGR+pZk1TRwyI/vRN3pw0sBL0GERv/nQ4mz5RxEmBwW/FfLZ +TC5vZsxIPK9YmBoAzQcPyv9gDe9oRA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YfHn7bHa; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675074830; a=rsa-sha256; cv=none; b=nUxmYQFWpdxnEXUysCiGtEiPkSYQBvMO7BhqE+ZKgyH5HGW7TpTTOeCrJ3eYMHghEjT9/a Ktf4yPwTLWy34Al3PC5V/b6vqVIbg/m1b9o5yKLx7awkaaQ/aFvSJb5K5nZKoCaLilLp13 3bCOOg8CQ8Uv6nrrdEXee995ov4DJx8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675074829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oT4/+Dsw5hQNhjDNcfeDL08lroMdeVaKhV4kansN0pA=; b=YfHn7bHaxwhcZ/tpq1adMY0IC3kseQUAJJi45LGGyu6FZYayjR3e3p4kZDJs0G2AxZXA5W C0Ix9mNBh+uleOduoSJdRdcyOdQj4EfvMaIolstiCZ9wgW6RIivHQxLn2kntXW1znQ4pXY 3WvvwqviJPUN0UW9LgugVmWc9WpHyT4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-323-2Q7zrrTIPmSvdtNBIoEfxQ-1; Mon, 30 Jan 2023 05:33:43 -0500 X-MC-Unique: 2Q7zrrTIPmSvdtNBIoEfxQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23F6E85A5A3; Mon, 30 Jan 2023 10:33:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64AB01121314; Mon, 30 Jan 2023 10:33:37 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230130092157.1759539-2-hch@lst.de> References: <20230130092157.1759539-2-hch@lst.de> <20230130092157.1759539-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3347556.1675074816.1@warthog.procyon.org.uk> Date: Mon, 30 Jan 2023 10:33:36 +0000 Message-ID: <3347557.1675074816@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: jyke145y77wrokz5zoxcso6qdyx1bbrd X-Rspamd-Queue-Id: 5730D8001E X-HE-Tag: 1675074830-429982 X-HE-Meta: U2FsdGVkX1/XWgFdTLLO3ynksda8mOEn2K6ZyUFyjELcRVRTXEiaBt3qhjgIbPQpOChJ9oOIDFlf7ODmdpL81ll68/zZS7DhvdFg4z3Vu+rISQEO+8lCQpNL1dCp5yFBwOs0KOzKA/Hz2elwkQbsR1ogui3qSWP2YPEiwo9kOsnofHXdijd9MNgFr18BF3UxJx7Me+gATvNcQtd9EzbCpi/wVxtzaPKig+OKAj7YSWns+7ic+0kPOiNi5ygsvDqRX3SmlKon6LYeB/Xs53jCsmTr2PS2xRvmmw5CDoyUVL5vtTIASReMb8wrLAb5ldE1M5ExTOjVPuwoVO6u8AWVhpG9plYacltdnf0cRovwohDQPzRTo7aZmglsGwntff0FVRm9P/ZBfJcf6XbXfeICAqfvDRb4QXAF0IexvT5jVGvMuwqTpKSQ7lspUqkmIaV9OmaO9ADm9uVS2JjUUm8qxDXduEi7bz9I1jRVgHwnqep2iXw6HRFueF6u1x1MtsDzfvx93VBRE8lLls/T9JMBX/tT/Ht4C7DI/1C8nu0JrvsRf9SaTW76nw+qQHaP54FHYGfzKI3UoqxMx0KqDr2OnsTZ+EmYO7DGhH3RgHCYxogDL4MJb7Sr6Aqv1EzY56EGrMZr8tARKPOHNbw1/Cgp1twJibz027aoHkonv9T+CZTnKO+WqmsqTLBqVfNrKGZh3tTFWLBb2x6rNJotUJDGYgPc/SC7FEk6XGLSAys/RW9Sp4vnqlPrzcQsKXUf5ckaAJ4JY43bl6dOV/Ah0JL/Qx01Ad+M394qf/pBfh5Uqn2YUA3AU5m1lS6k/19NeS2JDedG0RL2NNDEzZMNx+z1UcC1pNMu3tCpdBnyYv5DL5NLpTQPrIiFm7bq4xtdNfuY27a7siYM3+Wu7FpGpLkP1CHxhij3nKdcBxj0+PRny+gPcm4rp8dqR5Ij+a2Tp0DqAyK+1gbiR30ocrF/nuD kS3ffGet D4mSeYoRDn21inhGPPTImFnuoqahSeEpWk7Q/DdIt5lgTPxF7iZ1DaGosEvKxqmjLw4Vyfd23ul8mscroMfzmD+4nyja8ic5p/kOD1sAI7DRxtu9oeFy5OHeFnNwSBLIhsLYowQmOWAZtf16k89nCLXnZHUokPRbmoBwDtGatduUYjexG4DsJYs10RoH9eKS30iiXqJhv2CqqZmVeLKq1ao3uVCe+WgwnryvmyVG78FmtiVKw6y6cZcL/it4X3nkr00O4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page, > + unsigned int len, unsigned int offset) Could you swap len and offset around? It reads better offset first. You move offset into the page and then do something with len bytes. David