From: "Kuehling, Felix" <felix.kuehling@amd.com>
To: Jordan Niethe <jniethe@nvidia.com>, linux-mm@kvack.org
Cc: balbirs@nvidia.com, matthew.brost@intel.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, david@redhat.com,
ziy@nvidia.com, apopple@nvidia.com, lorenzo.stoakes@oracle.com,
lyude@redhat.com, dakr@kernel.org, airlied@gmail.com,
simona@ffwll.ch, rcampbell@nvidia.com, mpenttil@redhat.com,
jgg@nvidia.com, willy@infradead.org,
linuxppc-dev@lists.ozlabs.org, intel-xe@lists.freedesktop.org,
jgg@ziepe.ca
Subject: Re: [PATCH v2 01/11] mm/migrate_device: Introduce migrate_pfn_from_page() helper
Date: Fri, 9 Jan 2026 16:03:59 -0500 [thread overview]
Message-ID: <3334cea8-dbaf-4dce-8b6f-e22350f642b2@amd.com> (raw)
In-Reply-To: <ebc909f1-ab70-4659-b037-bb82806fa159@nvidia.com>
On 2026-01-08 18:49, Jordan Niethe wrote:
> Hi,
>
> On 9/1/26 07:03, Felix Kuehling wrote:
>>
>>> @@ -646,7 +646,7 @@ svm_migrate_copy_to_ram(struct amdgpu_device
>>> *adev, struct svm_range *prange,
>>> pr_debug_ratelimited("dma mapping dst to 0x%llx, pfn
>>> 0x%lx\n",
>>> dst[i] >> PAGE_SHIFT, page_to_pfn(dpage));
>>> - migrate->dst[i] = migrate_pfn(page_to_pfn(dpage));
>>> + migrate->dst[i] = migrate_pfn_from_page(dpage);
>>
>> You missed another instance of this in svm_migrate_copy_to_vram.
>
> I might be missing something, but is there call to migrate_pfn() in
> svm_migrate_copy_to_vram()?
I see what's happening. You removed that call in patch 2. Never mind.
Regards,
Felix
> I'm seeing svm_migrate_copy_to_vram() calls
> svm_migrate_addr_to_mpfn() - that should be handled already.
>
> Thanks for reviewing,
> Jordan.
>
>>
>> Regards,
>> Felix
>>
>>
next prev parent reply other threads:[~2026-01-09 21:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 9:18 [PATCH v2 00/11] Remove device private pages from physical address space Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 01/11] mm/migrate_device: Introduce migrate_pfn_from_page() helper Jordan Niethe
2026-01-08 20:03 ` Felix Kuehling
2026-01-08 23:49 ` Jordan Niethe
2026-01-09 21:03 ` Kuehling, Felix [this message]
2026-01-09 22:47 ` Balbir Singh
2026-01-07 9:18 ` [PATCH v2 02/11] drm/amdkfd: Use migrate pfns internally Jordan Niethe
2026-01-08 22:00 ` Felix Kuehling
2026-01-08 23:56 ` Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 03/11] mm/migrate_device: Make migrate_device_{pfns,range}() take mpfns Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 04/11] mm/migrate_device: Add migrate PFN flag to track device private pages Jordan Niethe
2026-01-08 20:01 ` Felix Kuehling
2026-01-08 23:41 ` Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 05/11] mm/page_vma_mapped: Add flags to page_vma_mapped_walk::pfn " Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 06/11] mm: Add helpers to create migration entries from struct pages Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 07/11] mm: Add a new swap type for migration entries of device private pages Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 08/11] mm: Add helpers to create device private entries from struct pages Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 09/11] mm/util: Add flag to track device private pages in page snapshots Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 10/11] mm/hmm: Add flag to track device private pages Jordan Niethe
2026-01-07 9:18 ` [PATCH v2 11/11] mm: Remove device private pages from the physical address space Jordan Niethe
2026-01-07 18:36 ` [PATCH v2 00/11] Remove device private pages from " Matthew Brost
2026-01-07 20:21 ` Zi Yan
2026-01-08 2:25 ` Jordan Niethe
2026-01-08 5:42 ` Jordan Niethe
2026-01-09 0:01 ` Jordan Niethe
2026-01-09 0:31 ` Matthew Brost
2026-01-09 1:27 ` Jordan Niethe
2026-01-09 6:22 ` Matthew Brost
2026-01-07 20:06 ` Andrew Morton
2026-01-07 20:54 ` Jason Gunthorpe
2026-01-07 21:02 ` Balbir Singh
2026-01-08 1:29 ` Alistair Popple
2026-01-08 1:08 ` John Hubbard
2026-01-08 1:49 ` Alistair Popple
2026-01-08 2:55 ` Jordan Niethe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3334cea8-dbaf-4dce-8b6f-e22350f642b2@amd.com \
--to=felix.kuehling@amd.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=dakr@kernel.org \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=jniethe@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lyude@redhat.com \
--cc=matthew.brost@intel.com \
--cc=mpenttil@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=simona@ffwll.ch \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox