From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id 937816B4ED4 for ; Wed, 29 Aug 2018 21:55:33 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id e6-v6so471614itc.7 for ; Wed, 29 Aug 2018 18:55:33 -0700 (PDT) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0127.outbound.protection.outlook.com. [104.47.36.127]) by mx.google.com with ESMTPS id l203-v6si3826544ioa.13.2018.08.29.18.55.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Aug 2018 18:55:32 -0700 (PDT) From: Pasha Tatashin Subject: Re: [PATCH] mm/page_alloc: Clean up check_for_memory Date: Thu, 30 Aug 2018 01:55:29 +0000 Message-ID: <332d9ea1-cdd0-6bb6-8e83-28af25096637@microsoft.com> References: <20180828210158.4617-1-osalvador@techadventures.net> In-Reply-To: <20180828210158.4617-1-osalvador@techadventures.net> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Oscar Salvador , "akpm@linux-foundation.org" Cc: "mhocko@suse.com" , "vbabka@suse.cz" , "sfr@canb.auug.org.au" , "iamjoonsoo.kim@lge.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Oscar Salvador DQoNCk9uIDgvMjgvMTggNTowMSBQTSwgT3NjYXIgU2FsdmFkb3Igd3JvdGU6DQo+IEZyb206IE9z Y2FyIFNhbHZhZG9yIDxvc2FsdmFkb3JAc3VzZS5kZT4NCj4gDQo+IGNoZWNrX2Zvcl9tZW1vcnkg bG9va3MgYSBiaXQgY29uZnVzaW5nLg0KPiBGaXJzdCBvZiBhbGwsIHdlIGhhdmUgdGhpczoNCj4g DQo+IGlmIChOX01FTU9SWSA9PSBOX05PUk1BTF9NRU1PUlkpDQo+IAlyZXR1cm47DQo+IA0KPiBD aGVja2luZyB0aGUgRU5VTSBkZWNsYXJhdGlvbiwgbG9va3MgbGlrZSBOX01FTU9SWSBjYW5vdCBi ZSBlcXVhbCB0bw0KPiBOX05PUk1BTF9NRU1PUlkuDQo+IEkgY291bGQgbm90IGZpbmQgd2hlcmUg Tl9NRU1PUlkgaXMgc2V0IHRvIE5fTk9STUFMX01FTU9SWSwgb3IgdGhlIG90aGVyDQo+IHdheSBh cm91bmQgZWl0aGVyLCBzbyB1bmxlc3MgSSBhbSBtaXNzaW5nIHNvbWV0aGluZywgdGhpcyBjb25k aXRpb24gDQo+IHdpbGwgbmV2ZXIgZXZhbHVhdGUgdG8gdHJ1ZS4NCj4gSXQgbWFrZXMgc2Vuc2Ug dG8gZ2V0IHJpZCBvZiBpdC4NCj4gDQo+IE1vdmluZyBmb3J3YXJkLCB0aGUgb3BlcmF0aW9ucyB3 aGl0aGluIHRoZSBsb29wIGxvb2sgYSBiaXQgY29uZnVzaW5nDQo+IGFzIHdlbGwuDQo+IA0KPiBX ZSBzZXQgTl9ISUdIX01FTU9SWSB1bmNvbmRpdGlvbmFsbHksIGFuZCB0aGVuIHdlIHNldCBOX05P Uk1BTF9NRU1PUlkNCj4gaW4gY2FzZSB3ZSBoYXZlIENPTkZJR19ISUdITUVNIChOX05PUk1BTF9N RU1PUlkgIT0gTl9ISUdIX01FTU9SWSkNCj4gYW5kIHpvbmUgPD0gWk9ORV9OT1JNQUwuDQo+IChO X0hJR0hfTUVNT1JZIGZhbGxzIGJhY2sgdG8gTl9OT1JNQUxfTUVNT1JZIG9uICFDT05GSUdfSElH SE1FTSBzeXN0ZW1zLA0KPiBhbmQgdGhhdCBpcyB3aHkgd2UgY2FuIGp1c3QgZ28gYWhlYWQgYW5k IHNldCBOX0hJR0hfTUVNT1JZIHVuY29uZGl0aW9uYWxseSkNCj4gDQo+IEFsdGhvdWdoIHRoaXMg d29ya3MsIGl0IGlzIGEgYml0IHN1YnRsZS4NCj4gDQo+IEkgdGhpbmsgdGhhdCB0aGlzIGNvdWxk IGJlIGVhc2llciB0byBmb2xsb3c6DQo+IA0KPiBGaXJzdCwgd2Ugc2hvdWxkIG9ubHkgc2V0IE5f SElHSF9NRU1PUlkgaW4gY2FzZSB3ZSBoYXZlDQo+IENPTkZJR19ISUdITUVNLg0KPiBBbmQgdGhl biB3ZSBzaG91bGQgc2V0IE5fTk9STUFMX01FTU9SWSBpbiBjYXNlIHpvbmUgPD0gWk9ORV9OT1JN QUwsDQo+IHdpdGhvdXQgZnVydGhlciBjaGVja2luZyB3aGV0aGVyIHdlIGhhdmUgQ09ORklHX0hJ R0hNRU0gb3Igbm90Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogT3NjYXIgU2FsdmFkb3IgPG9zYWx2 YWRvckBzdXNlLmRlPg0KPiAtLS0NCj4gIG1tL3BhZ2VfYWxsb2MuYyB8IDkgKysrLS0tLS0tDQo+ ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0KPiANCj4g ZGlmZiAtLWdpdCBhL21tL3BhZ2VfYWxsb2MuYyBiL21tL3BhZ2VfYWxsb2MuYw0KPiBpbmRleCA4 MzllMGNjMTdmMmMuLjZhYTk0N2Y5ZTYxNCAxMDA2NDQNCj4gLS0tIGEvbW0vcGFnZV9hbGxvYy5j DQo+ICsrKyBiL21tL3BhZ2VfYWxsb2MuYw0KPiBAQCAtNjgxOSwxNSArNjgxOSwxMiBAQCBzdGF0 aWMgdm9pZCBjaGVja19mb3JfbWVtb3J5KHBnX2RhdGFfdCAqcGdkYXQsIGludCBuaWQpDQo+ICB7 DQo+ICAJZW51bSB6b25lX3R5cGUgem9uZV90eXBlOw0KPiAgDQo+IC0JaWYgKE5fTUVNT1JZID09 IE5fTk9STUFMX01FTU9SWSkNCj4gLQkJcmV0dXJuOw0KPiAtDQo+ICAJZm9yICh6b25lX3R5cGUg PSAwOyB6b25lX3R5cGUgPD0gWk9ORV9NT1ZBQkxFIC0gMTsgem9uZV90eXBlKyspIHsNCj4gIAkJ c3RydWN0IHpvbmUgKnpvbmUgPSAmcGdkYXQtPm5vZGVfem9uZXNbem9uZV90eXBlXTsNCj4gIAkJ aWYgKHBvcHVsYXRlZF96b25lKHpvbmUpKSB7DQo+IC0JCQlub2RlX3NldF9zdGF0ZShuaWQsIE5f SElHSF9NRU1PUlkpOw0KPiAtCQkJaWYgKE5fTk9STUFMX01FTU9SWSAhPSBOX0hJR0hfTUVNT1JZ ICYmDQo+IC0JCQkgICAgem9uZV90eXBlIDw9IFpPTkVfTk9STUFMKQ0KPiArCQkJaWYgKElTX0VO QUJMRUQoQ09ORklHX0hJR0hNRU0pKQ0KPiArCQkJCW5vZGVfc2V0X3N0YXRlKG5pZCwgTl9ISUdI X01FTU9SWSk7DQo+ICsJCQlpZiAoem9uZV90eXBlIDw9IFpPTkVfTk9STUFMKQ0KPiAgCQkJCW5v ZGVfc2V0X3N0YXRlKG5pZCwgTl9OT1JNQUxfTUVNT1JZKTsNCj4gIAkJCWJyZWFrOw0KPiAgCQl9 DQo+IA0KDQpJIHdvdWxkIHJlLXdyaXRlIHRoZSBhYm92ZSBmdW5jdGlvbiBsaWtlIHRoaXM6DQpz dGF0aWMgdm9pZCBjaGVja19mb3JfbWVtb3J5KHBnX2RhdGFfdCAqcGdkYXQsIGludCBuaWQpDQp7 DQogICAgICAgIGVudW0gem9uZV90eXBlIHpvbmVfdHlwZTsNCg0KICAgICAgICBmb3IgKHpvbmVf dHlwZSA9IDA7IHpvbmVfdHlwZSA8IFpPTkVfTU9WQUJMRTsgem9uZV90eXBlKyspIHsNCiAgICAg ICAgICAgICAgICBpZiAocG9wdWxhdGVkX3pvbmUoJnBnZGF0LT5ub2RlX3pvbmVzW3pvbmVfdHlw ZV0pKSB7IA0KICAgICAgICAgICAgICAgICAgICAgICAgbm9kZV9zZXRfc3RhdGUobmlkLCB6b25l X3R5cGUgPD0gWk9ORV9OT1JNQUwgPw0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgTl9OT1JNQUxfTUVNT1JZOiBOX0hJR0hfTUVNT1JZKTsNCiAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOw0KICAgICAgICAgICAgICAgIH0NCiAgICAgICAgfQ0KfQ0KDQp6b25lX3R5 cGUgPD0gWk9ORV9NT1ZBQkxFIC0gMQ0KaXMgdGhlIHNhbWUgYXM6DQp6b25lX3R5cGUgPCBaT05F X01PVkFCTEUNCg0KSWYgem9uZSA+IFpPTkVfTk9STUFMLCBpdCBtZWFucyB0aGF0IENPTkZJR19I SUdITUVNIGlzIGVuYWJsZWQsIG5vIG5lZWQgdG8gY2hlY2sgZm9yIGl0Lg0KDQpQYXZlbA==