From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AC6C54FB3 for ; Mon, 2 Jun 2025 11:45:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07AF36B028C; Mon, 2 Jun 2025 07:45:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BA56B028D; Mon, 2 Jun 2025 07:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E35556B028E; Mon, 2 Jun 2025 07:45:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C36056B028C for ; Mon, 2 Jun 2025 07:45:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5980F8024F for ; Mon, 2 Jun 2025 11:45:18 +0000 (UTC) X-FDA: 83510279916.27.0349800 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id D9C831C0002 for ; Mon, 2 Jun 2025 11:45:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfoC5UCw; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748864716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pluW0u/+xJd0eUGvzfkykomG6yjqcYSK31IZ33YVJmI=; b=PtwO7NozRExWPdiO2mK2gB3Vai4B0C7X2Fd72ChtPVLhj8qSoXSBE222fPrCS3fw0C8Vcl +DGWUVSXRP1BcKWEzRIFall15jlemeZHMEswBjqBdeSa7zOWJiAIVH8VZ2ytpO2/j5RvKV gs/8MhnBXvtn3jTcRGh2rqmadsTk4zI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bfoC5UCw; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748864716; a=rsa-sha256; cv=none; b=jC57SY4hg69/yv/SK9XllkzyYrcFHuhs2G0d2dfozzVdPisH5b+uqJfEg3ZlDLptYW+Ej5 TYkU2Mjl8xLc5kdcf/g3b86VYfJF8qerJdlnS2W/U+zOlG0F35DGX7yeRB+pBg4DFWDFF7 EOPnKs8acbwROcjzDWPxOdzSLAK8xNI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748864715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pluW0u/+xJd0eUGvzfkykomG6yjqcYSK31IZ33YVJmI=; b=bfoC5UCw8EBDqqiyeTjOllXYRBAFKxlOPkh3LkBRSvh4ZvdFOI8MhpK4j71vyk6Qn1q455 /Q/wG7hmna5ul6xeTQOhGenQEIFljEAx1ZUlhOKHq1stWDaAcLRn4k/VgLRYcNQj1PtVjW 7HZpXM1CkswDoNY/yHd7aixqrC1Q/Ac= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-jzMQiyVPMUiX1O5PyVkdpg-1; Mon, 02 Jun 2025 07:45:13 -0400 X-MC-Unique: jzMQiyVPMUiX1O5PyVkdpg-1 X-Mimecast-MFC-AGG-ID: jzMQiyVPMUiX1O5PyVkdpg_1748864712 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450de98b28eso7402555e9.0 for ; Mon, 02 Jun 2025 04:45:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748864712; x=1749469512; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pluW0u/+xJd0eUGvzfkykomG6yjqcYSK31IZ33YVJmI=; b=Nlls33aCBiufZqXQFrUJFPl2v9/jN+CA3mcQepTBA9aH9Rvjl3a/O15ge2nAfoOV32 5LK+BWbEfXCUwTHv0H6joNSX7Woe4hWcXuaQ1m46k+6egtwefUk1xmGWHmcOZEXUFpLn bnl24a+NMIZKldTUkMa/UD85ZYQER6MD2ThvAM253lkz+YdKnhs478iRGMzK8uWOQ4rs mAhNrGQzilwPScyD+C+wQbn7kGLtJgt2j86NMFmo5HII/WwbdC9gLoQLHAhyq5btane1 5BPtofFmO/vHPnOnWeWLPWhcxZXaYG3EkIDQJwIk6UYZeDeqGFcHtyteCvOsYvhC2cD1 1nVw== X-Forwarded-Encrypted: i=1; AJvYcCWx17W6PuGr/pxeAeCiUWfBnuFTitVSWTs94z79BFzHbphSMv+XHP9rfwgpETTPMmPlp3V9xUn45Q==@kvack.org X-Gm-Message-State: AOJu0YxFg28tHRjuBj8NB+fgAuvY2pQ7Aq7oHYEQ3xorklbLGf6OpgQZ sV8qAhyhxrNX6Dz58mYUGOVc5/oiu6fuD3wKOjKs/bBPad4x2v+CyCJCR0LflecHwsyAFsnGEft NRbkUaIqJer9rpzorOSzFvDgso/OGIAcPto/CdBm/SIF8eagzgjQd X-Gm-Gg: ASbGncsgYoPdmB6ZqoXvYFLPn/cUcTI7uFZmIir3yDvno7AevvsV8k6bVjOOUw/MZAn TPqowzc2kFcNQ5zKhPiKQwtJ6sk/xoFaZKUFGjp+SEcx2dPVNhMJhi/GsYFaoq+uy2c3yUVZsdc NMDWltjSpKvHrHnsQUZFQTfAs0QtFpmEiEMx2wiCFkaSgOHRT941FTXiTtScGYIXtPwbZt1inBn A3/r6pJ4tTi+wJnD6IaxjhS/YKCAD7284mAnnLbWZe6aEk7ySpUycevFa3ofT60DhWMY/osjLAr wLQQZVqLEw73KbgRrqbVpNtYC5Kxi3Nk+WgSKf6LeTlLZFtgo8vMJomaD+Cm5crYRol6R95LYrD n053JxXBkrr0EhwVviWW72PMmrZljyhbNt3Q1NFs= X-Received: by 2002:a05:600c:3555:b0:450:cabc:a6c6 with SMTP id 5b1f17b1804b1-450d6bbb899mr123242555e9.15.1748864712255; Mon, 02 Jun 2025 04:45:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNiWxj7ru1ZpdEa7TTYC+Mx0/zZsZQT6PVApBO3c8hzuU2D+iOpq+QjyaIBIup3raLJSW1Xg== X-Received: by 2002:a05:600c:3555:b0:450:cabc:a6c6 with SMTP id 5b1f17b1804b1-450d6bbb899mr123242185e9.15.1748864711876; Mon, 02 Jun 2025 04:45:11 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f92585sm126373555e9.5.2025.06.02.04.45.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 04:45:11 -0700 (PDT) Message-ID: <3327f886-e708-4229-a83f-2404f115d44b@redhat.com> Date: Mon, 2 Jun 2025 13:45:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/12] mm/khugepaged: Remove redundant pmd_devmap() check To: Alistair Popple , linux-mm@kvack.org Cc: gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net References: <2093b864560884a2a525d951a7cc20007da6b9b6.1748500293.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2093b864560884a2a525d951a7cc20007da6b9b6.1748500293.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n2vYvIkQM9CaiI97th9_Fk9IOyIfpgRvyV-hQpEVZ2s_1748864712 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D9C831C0002 X-Stat-Signature: sfidi1kz55kfoebi9fa61n8epodsfrt3 X-Rspam-User: X-HE-Tag: 1748864715-483684 X-HE-Meta: U2FsdGVkX18xZ+cnRVUyQRTqIXtDj+qi+hA/eIakzXN9SICT1psbND1hz6LKr8jOgqwqm6RyXKLDOxAem/znBG0QXyaK4ezxqQxkMPJpuy+f8O9O5vcTK9pfydDtu5pNShismy1EhUdoCv1tcV7qCgPeWksjsayoM8pwj79xXIE/hkZ+17Pi6L7FhvD28xX3YuYQCjUUmqJa0igPeLHsVF284CC2YenVzVh4fAl7TIc732xCWM/43VhaDiZlVWXIRVxgjafjyjn+vBoCX25O3BQuzU6VRKxKQrPzhxOMxyoU5YWwJKsCf5sXi2rx2126duXHvUwXpRUJLDOREhuJ0g6aTO+su8zeKIXg6mIpsDftk5duKCyAfmtRtdLnAEifXLDiy6i36mpkNikYb4BtZBXy1RFhZKMc1mbOCzXQrXbuJIrm6riurcsyfP4IL5d4/AAZwSptPSxE7mLgUMTzkrtU1d8Rm/Oq9v1ehwqR53pF0iJUADRQWLh0hdnsTaaa6IkM1sXWyPTFlKXUon6+2ovsySaWyjW/nJ7rpPMefpWW5fTNKQGn2HRTvxU1YgbZWcw9/nPkngMB8lxdg2bOdMd3oCURIDFZqq8ZTXdJfHNqoU6iEkjfeRtVI1w0YxDsg3tDe6xRCMIJt1Sn9Us6/9DNzPYc8SGXbZRpupBmuXDohH3s9aYZlWFD4jau7evjnJyQk2W91VrsVWYY8DHB390YMyOkI8ySjwxZmFVmXeV7r8nZ7IIvDyyZAYnqWKC1ngsq1UyXnFZX/POcPJVnPIwnwlJBwrJwjzynCmZA3miGgizBncFjWSXuzmkgZ6TO7568mzpn38Lwbf/gEeiwRh5wzuDDjSKK7iZJAuqjxw/X7iy25Uh6aDPNTL0ZVYolwKJNjrHUnWYTxv47o2ef6Y1cp5dAbkvwQ0Ke9HeE/+WIFKhCsJ+4nzLs6eMyno34pPXIO09ZEFg3DQRTtRD dAnZU9ZN J0qvDxEdl58980Buk1h6NXVdylXvhUp9LblfGX4h07rX6BW+RILGPk5pTOeHLpew2UZ2YyFyCLCeqB6agpHd8MW2e5aZqMeQlBIL8N7YLGYAqyGLraJoY+DQaGqnYgx0jSjIZtSJ06hyonNRLWaHgfSaH+pXJqRB3cbbfEyScDb8XrD5fUb/EmJh+w6ZcOxnEctGYvQP2W31C5j2aRHfEm7t0+V9YHP8HuonBkXzD+JttLWXEY7NJBiearMOtbB3lsPLFGp3rNMaG217aWCFCGG26AasRPUQ/f16YWkyAsh4cz47JEt/fSCJQs83bL7cjSVr1T5CLp8DIe6ktY3Uo/8973gGx43VC64dotly9XqPNJ5fDaL0oe7CqP8VKqRYmW4plALNRisop84/WpIkSv8h0qZfi+xe/1cukD99sXC2+HyV64fAN3utPaCzP5Uiy336cAxFq25HM2WE7uyLjWd4s23EhfSThma22tzH9HlwJUT5uvACo5gqg0QcdSaDs2WyW8tCulp7bz0olyRlqt/f30sr70EHvfksEJiahxxcl2JMhvhVQLKL6+o9wIcsW3W+V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.05.25 08:32, Alistair Popple wrote: > The only users of pmd_devmap were device dax and fs dax. The check for > pmd_devmap() in check_pmd_state() is therefore redundant as callers > explicitly check for is_zone_device_page(), so this check can be dropped. > > Signed-off-by: Alistair Popple > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb