From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB459CD1288 for ; Wed, 3 Apr 2024 12:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21ABE6B0098; Wed, 3 Apr 2024 08:58:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB236B0099; Wed, 3 Apr 2024 08:58:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0937A6B009A; Wed, 3 Apr 2024 08:58:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E1E406B0098 for ; Wed, 3 Apr 2024 08:58:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BF0D1C0DAA for ; Wed, 3 Apr 2024 12:58:33 +0000 (UTC) X-FDA: 81968224506.02.1F7BA7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id CA88D2000C for ; Wed, 3 Apr 2024 12:58:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ijLe/6OK"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712149110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5DGnORPv79MmjGVc5naevaHP+scfzBDnCLP3n2Z3Y4Q=; b=s+RVdPqaDi2sdLmpmiTRHADWkreCWdeOzJMzm5k9SDareEaibee9xWKv85rnhRlfr35/Ho JLCf9xlwRfk0h2FtksecLYBZxotJo0hjWM5Hh/4VNZI/1/C92ccEX9SyzFCQcfAT6Cc8Ju mt1VtgKEh/W9WSfExYa9NlXpFKHclgU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ijLe/6OK"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712149110; a=rsa-sha256; cv=none; b=NgGqd8rNUoFoiGdTnWTKF3iewzJFncK/NUDZuA7GD/lzpaB+RH39QY6zzDalsYo4xENTo5 5oF1hcGdZbc1unqQzooh0dIaTZLDgsp+vjo38UX1EtTGULcUasg3PTcUWSodVYOnWg1lTv vVbTev4dRNCA+mGCUhuc4JOXxg7PRDU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712149110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5DGnORPv79MmjGVc5naevaHP+scfzBDnCLP3n2Z3Y4Q=; b=ijLe/6OKOO2PKubQFWLEV6FNUuj8ejEaDH4Glt3U+SF252L+rQVO2MhsueFIhC58A7B31M sM1qdXAxR5QWs7NAjgRCPQLbtVgiFOesa66cNXixxlTnSHL1jCzNnvA4uCMjDE9x5SzI+j kQA4ioR0q+I9DeppO+KKvpEBKG/7Ylo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-dz7FoxU5NrCenslQwwmFtQ-1; Wed, 03 Apr 2024 08:58:24 -0400 X-MC-Unique: dz7FoxU5NrCenslQwwmFtQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E932785A588; Wed, 3 Apr 2024 12:58:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id E17DAC04122; Wed, 3 Apr 2024 12:58:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240403124124.GA19085@lst.de> References: <20240403124124.GA19085@lst.de> <20240403101422.GA7285@lst.de> <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> <3300438.1712141700@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3326106.1712149095.1@warthog.procyon.org.uk> Date: Wed, 03 Apr 2024 13:58:15 +0100 Message-ID: <3326107.1712149095@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspam-User: X-Stat-Signature: jgdqrtjd43xzcd6q4ezfx96hemiuwqzs X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CA88D2000C X-HE-Tag: 1712149110-455671 X-HE-Meta: U2FsdGVkX1/+jQDpCI46gg9T5qwSOKOJj+nvbB/mGIbwk66cZqKuP9Kxpax6NkMLbBX4qGi/xYGCw/booqbo7JfGFYkJvca7Uto3V46/Qoy2o9lXW+wSUnbQw9MAHteAFPAhs2k5czO3rPkrXw5FRetK5lUSg9Uq5ArxnNBsIIEf/AZHPPukN5LNaQcUPFeT00fpNoC3saSJICjf9cIFhQjB8FE6bArP9EUDKWuhOGJem0+MqpjzXoSW7fV/CpDCdl2/k1OReCUHwwwvTrtkZZwOv59NUKH1ZHhW5mR9l6pCF4goAZxRtFeYGLk3Rx7Y4Hx3T6OBfgxHfalMewpOX11hirrn6ScuY0L5P3IS75Or1HD22mEsNKZQFg/NekPXLtkkJ8HMDz4Eg+N8uv2VzvwNZo8nFX+CML2rjhzUTxdLEsI6t4KH66PNkKASCvjDcov2zw/IMaBWaVbOGdr/2TSnUxjsi/MwZRMN52IM1XH3Ui+6IQA0f4jbA9MeOOfWN9byJqPpTYzOJmEpjoaTGT2PGTxbEUwnvlDB2GiJvuL9GzSpEk2hCOxULYeSqH6zJG/5ttomU1zdyVUFhr7qHGs03KakChg21PnJgKaPB3nodcUbk/WdOfpdyPG1L6iwasrT+D7zWeciTXOE/xx9MEf7sRffye+3DEqa2XpSVd9DAxSJ26uu7swZ+9O8hy8140qt35slTzmO+/FelIDXSQrn0Ivi4+DVHiIUPJVpXrERklqaRl+0rYXTMPsjDfFvT98znOmca9TgJ/VGAPDl9eCrGxgGY5HY+0rfbJWY8FAe9c30NzP8dO2FkOTgwaHtIXJPAc/3EHHUqLyU+SaHE+FDBQauIBoLh0+C/vM4JLBowLpUeZ58GNEjEh2xaIh1/gy5RUc2nlXXaIQQrDAwvXLfpPdBleTyUgUcMHFEkA1/KWHeaxQck47qhyxLdWm4OparaYqhP0ZLt7OwsK6 tDnyqiat 1zNqswaecsP8V041XXkQQMS5GrXw9WvRP8Hc7Er1oPL3uh4NEYvbVnyP0RuZxA4dR+DeZwCYegd7CswpVIAYByj8Cm4Z+2YvAr/8kMBBGo0lQxfpBNXBf752gfmFjpOvC8pyZ9lxGnGjvtkz67DCM59F2nqRNaTQjaftEyq/Gyqu0Ox2XuEJwrSOvnH5iLyBLuR6fNEvZ5vZoHg6Ftm/s1gLPxjMYm/uZOuhf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christoph Hellwig wrote: > > So why are we bothering with EXPORT_SYMBOL at all? Why don't you just > > send a patch replace all of them with EXPORT_SYMBOL_GPL()? > > No my business. Clearly it is as you're gradually replacing APIs with stuff that is GPL'd. > But if you want to side track this let me just put this in here: > > NAK to the non-GPL EXPORT of writeback_iter(). Very well, I'll switch that export to GPL. Christian, if you can amend that patch in your tree? David