linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-api@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Balbir Singh <bsingharora@gmail.com>,
	Borislav Petkov <bp@alien8.de>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Eugene Syromiatnikov <esyr@redhat.com>,
	Florian Weimer <fweimer@redhat.com>,
	"H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Kees Cook <keescook@chromium.org>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Nadav Amit <nadav.amit@gmail.com>,
	Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
	Dave Martin <Dave.Martin@arm.com>,
	Weijiang Yang <weijiang.yang@intel.com>,
	Pengfei Xu <pengfei.xu@intel.com>,
	Haitao Huang <haitao.huang@intel.com>,
	Rick P Edgecombe <rick.p.edgecombe@intel.com>
Subject: Re: [PATCH v28 04/10] x86/cet/ibt: Disable IBT for ia32
Date: Mon, 9 Aug 2021 16:04:18 -0700	[thread overview]
Message-ID: <3318ca57-7ac3-8296-f9ae-0ae83d5f95dd@kernel.org> (raw)
In-Reply-To: <20210722205723.9476-5-yu-cheng.yu@intel.com>

On 7/22/21 1:57 PM, Yu-cheng Yu wrote:
> In a signal, a task's IBT status needs to be saved to the signal frame, and
> later restored in sigreturn.  For the purpose, previous versions of the
> series add a new struct to the signal frame.  However, a new signal frame
> format (or re-using a reserved space) introduces complex compatibility
> issues.
> 
> In the discussion (see link below), Andy Lutomirski proposed using a
> ucontext flag.  The approach is clean and eliminates most compatibility
> issues.
> 
> However, a legacy IA32 signal frame does not have ucontext and cannot
> support a uc flag.  Thus,
> 
> - Disable IBT for ia32.
> - In ia32 sigreturn, verify ibt is disabled.

Acked-by: Andy Lutomirski <luto@kernel.org>


  reply	other threads:[~2021-08-09 23:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 20:57 [PATCH v28 00/10] Control-flow Enforcement: Indirect Branch Tracking Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 01/10] x86/cet/ibt: Add Kconfig option for " Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 02/10] x86/cet/ibt: Add user-mode Indirect Branch Tracking support Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 03/10] x86/cet/ibt: Handle signals for Indirect Branch Tracking Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 04/10] x86/cet/ibt: Disable IBT for ia32 Yu-cheng Yu
2021-08-09 23:04   ` Andy Lutomirski [this message]
2021-08-10 16:07     ` Yu, Yu-cheng
2021-07-22 20:57 ` [PATCH v28 05/10] x86/cet/ibt: Update ELF header parsing for Indirect Branch Tracking Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 06/10] x86/cet/ibt: Update arch_prctl functions " Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 07/10] x86/vdso: Insert endbr32/endbr64 to vDSO Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 08/10] x86/vdso: Introduce ENDBR macro Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 09/10] x86/vdso/32: Add ENDBR to __kernel_vsyscall entry point Yu-cheng Yu
2021-07-22 20:57 ` [PATCH v28 10/10] x86/vdso: Add ENDBR to __vdso_sgx_enter_enclave Yu-cheng Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3318ca57-7ac3-8296-f9ae-0ae83d5f95dd@kernel.org \
    --to=luto@kernel.org \
    --cc=Dave.Martin@arm.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=bsingharora@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=esyr@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=haitao.huang@intel.com \
    --cc=hjl.tools@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=mingo@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=oleg@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=pengfei.xu@intel.com \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=rdunlap@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@linutronix.de \
    --cc=weijiang.yang@intel.com \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox