From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE8B8D149F3 for ; Fri, 25 Oct 2024 21:51:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 726F16B009B; Fri, 25 Oct 2024 17:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D6FD6B00B3; Fri, 25 Oct 2024 17:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550B46B00C9; Fri, 25 Oct 2024 17:51:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 371716B009B for ; Fri, 25 Oct 2024 17:51:50 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1BD6B41114 for ; Fri, 25 Oct 2024 21:51:39 +0000 (UTC) X-FDA: 82713471624.06.510BD2C Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) by imf24.hostedemail.com (Postfix) with ESMTP id C644C18001B for ; Fri, 25 Oct 2024 21:51:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=CWaVlnu7; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.92.85 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729893054; a=rsa-sha256; cv=pass; b=iLnqM+qD0uUiQ8/154b7tKOwUdGBugk/87SyxJpYJM62waQSVMCHlKjv5/GmiKcYBHDPbH OyJlSZrzo+swy30ZhOshbmjXE6pDvZSQcbzqt4imOwzrbWRIxVjVHccikLEonWK8Fa0WOd L52OglyU7TAce63x456YT2l4zclhxUY= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=CWaVlnu7; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.92.85 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729893054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WYWgZqA5IxagrEb1ITvcPiuUun/SzZ8c/vvc78nFTRc=; b=MomUExsd1LlVCphX2a0wdboCUiLyb5FKwsjP5U0Ttx0DxQdNnh1hPlQWAl9xmLZVEMwTrO g15Me5ETu4AP33HIZUGvlmdqYyY4IBHJLIw1urNzCCGqdzb3rBD7mVsdFy519GKQdQepSK czTGJQVNrhx9/EBTT4aiPipNGFzYLIw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lcnuoD++LhoZguqIcxPyVYnZpgwp/z8MSjxaLAs+/e5YxSccVbtUzjpuBptpHPvJl6nzVKqa+j1nXUGDL1fld/P/yOTrIbMQxNm3lJ3HscKcydx9NSItHbKEVQvgQmVhtqiZzgAlJNGtEEv0JfuWWR/rsUH1kdEd3mjcbLn3m9HSU2OES9et7Mr7Cl6cWnVaLfcieAAfYBKuw/1MTxV9vRlGrhzlZQ4Nf+1Y6+qjyAdeiRUU10tpyxUpL2nYbZL0qcjTQyV88klM8rkBUwCKz+QhGRImhwVOxsQPW3pjMzfETXKCm/gO0op56kWiTkUb8+kYeyfxsxWhML7D/M2GWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYWgZqA5IxagrEb1ITvcPiuUun/SzZ8c/vvc78nFTRc=; b=dUfvgKYd3+4oaTIRoAU+y1ltXldkHkDIHUs192I3IYrcNzduaExmYROozjUp7Fnur5L4Fsd902UYcggSHRQsUmFPlFArWFodUku6SyQ7vi/rejy4gtgQXGrr+BE29szjcoNqUMt5HTm2WElNbdZ+s2MCRoWArcv0vqExSLnCxVLP6oaHXBhA51SIPFvBv9bpwYHKCV3uA++mAD8ijTyZWw14FTzbamjX/6au8b/lRZY4zp/rz3JPPCgFEDBPd8zQRWEIhXPdWaWGdgH6oF779N3/E22R0ReG9MdEc0lpMfT1J89qQQQDQjquHjqvr7USvelWV5vTlVa0WSTiW6Oy8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=oracle.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYWgZqA5IxagrEb1ITvcPiuUun/SzZ8c/vvc78nFTRc=; b=CWaVlnu75srf1+mbVYkL/X6KBfBZLyoD99CFcv0QtdVnoSFsfYOtTYDrco1A7VSuFUAEjn2kh8xsEaAQtvhzbNBPjXxvX7fSe5UzVvQhevhC5JABKWj8V6GrmztE0BF5TroZ7S6e9fym9SbLb8S2qecg57MJc/3ya4UfssLT1cUzTL2/lHh9pS56xjhTkubNOQz8EvmfjrGr1YbfnEsLc6U2kaGiljpTkiLnJTJjrnCRdhvgpXIjZVVtIueXiWFcuFVP3RZEbRFSawMtnz0lTu1qz9Sixw82uCP9ch2FPsYXvi6NylrGKSkSTVNNcwh+uSi+VnQS5/sYyz3x1bK0UA== Received: from BYAPR06CA0023.namprd06.prod.outlook.com (2603:10b6:a03:d4::36) by PH7PR12MB5998.namprd12.prod.outlook.com (2603:10b6:510:1da::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 21:51:42 +0000 Received: from SJ5PEPF000001C8.namprd05.prod.outlook.com (2603:10b6:a03:d4:cafe::4b) by BYAPR06CA0023.outlook.office365.com (2603:10b6:a03:d4::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21 via Frontend Transport; Fri, 25 Oct 2024 21:51:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001C8.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Fri, 25 Oct 2024 21:51:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 25 Oct 2024 14:51:30 -0700 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 25 Oct 2024 14:51:29 -0700 Message-ID: <330c0dae-fa8a-49e5-94b4-25b915f74e37@nvidia.com> Date: Fri, 25 Oct 2024 14:51:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process To: Lorenzo Stoakes CC: Pedro Falcato , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , "Vlastimil Babka" , , , , , , Oliver Sang References: <788fdfcc9ef602b408951d68097918d6ae379395.1729848252.git.lorenzo.stoakes@oracle.com> <828674d9-e862-4438-86b6-61977f4cf3b5@nvidia.com> <31dd0e52-9868-4cb4-aec6-d8749cdd2560@lucifer.local> <9de8d876-5729-454b-bf8c-8b0ec8f8ffc1@nvidia.com> <239456b7-4045-46cd-a2e7-8445dd6640c6@lucifer.local> Content-Language: en-US From: John Hubbard In-Reply-To: <239456b7-4045-46cd-a2e7-8445dd6640c6@lucifer.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C8:EE_|PH7PR12MB5998:EE_ X-MS-Office365-Filtering-Correlation-Id: 525644a4-e635-4cb5-142b-08dcf53f3650 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RzJ3NXBRa2x2OEwzT3RNRFFuVGVCL0lza0lpNE9sUmZuNDBZTWhFNTNnY21l?= =?utf-8?B?blRiRlJFb3RlSk83aEwwZXJwZDZNZ3NLb3pob1NLUnp5dEp5T25SWmJNbmdF?= =?utf-8?B?RUE2WVU5Qm5hQjJMWTNvNllIbi81VEFMSCs3bmdPdjR0dEVIZUdMYWRTaW9D?= =?utf-8?B?TDlzTnVKR21ZUVNJaDRZSVZBYW1iUSs3blR1ekMrUERaSnF6NUVTbk8ranEv?= =?utf-8?B?eWp2cHZRMjZtMzJ1MVN6R1lGZTJUZjEwSXpNQlNQd1Z5c09GSDMrOXpKZElr?= =?utf-8?B?amxjeGRrZEhtdmQ2Vjh0N2xzRW5FWnB2VDBFTlgxMXUyZUdrRXk1ZU85Rzk4?= =?utf-8?B?aDM3SllQOG1ieTFGT1FDeGdaVVRlSDlzZFM0dzBFeEVIT3dJS1RGWnJBb3cz?= =?utf-8?B?WEMvQTA3TnlSV2NqS1FYUVh3ZmFOMEdudTcvaC9KYTdrNnBlOTVWZXc0a0xJ?= =?utf-8?B?YjhZdktyQ09vVnVZdXRXSnFZekpZZFQyT3R6L0ptbGErb1A4UUY1cFF4Ukl6?= =?utf-8?B?KzE0UWlGSkdYSGJKRUR3MkU5OWIydDM5VTBxc1VqMzdab3JucmM1M1RDVmJF?= =?utf-8?B?QWNRRUFEWWJ5bWw2d3dkK2VyZHIzdGRkcGIwa2FleUkxZ0lQcTBtSWhaczdX?= =?utf-8?B?SnJKTkVRRk1GemR6c3dEREp3OEkwQ1YxRkdDWks0V0hiOGhDYk93OGxCOEVY?= =?utf-8?B?cGFQTHR4L0hSbGlvbjVIS3RXWVVMOVNsNHRhNlBlZWx3TkVDUHVJdUREYTZY?= =?utf-8?B?SnJybE5uc0ZWVmVZWVFrbmRUS0VJM0dFRVRkdmpsWFVTUEg0Wk83SXBjbFpt?= =?utf-8?B?djY0dHhicUc1MDAwZ2ZOaDZYaEoxQXU2R2hqWWxGU2ZMSHR2MldXb2IxMDAw?= =?utf-8?B?dW95NkdjZC9hSnZER3g3elpab3dMMlkyWDZuWGlYUis0ZEFhOGFEYWpiNjFJ?= =?utf-8?B?NFJ2cjhnYVY3LzlIRVdySzIyaVdsV1JLUzZmNFBjQlFmeWF1blFERzc0QUpV?= =?utf-8?B?SGgwb3pNK21zY2Z0bUtZbTl1L2ZlcHA4Y01xNVJzZ3RObi8zV0JBV2NUUVdl?= =?utf-8?B?S05BQk84aDkxTXNXbkkvM0pSSTdabkw0R0t4NEIvZEVzOUwwd1hRV0IrbVF6?= =?utf-8?B?YmYrKzlwL3diWjkzcGp4dFFpQmFtYldMc0h5V1gxSk5mVUJRU0RzZTRlRWw2?= =?utf-8?B?NXNpejFTanFQRFN5bmEzTys5eTFNZlM0bWp1QlE0TjQ0akdMem41WVFSWlF3?= =?utf-8?B?MGxqMjNNeS9HZGI4eEI5T1BrcDZwVmJJRjVkdmJ5V1U5cGhYdjJFYS9JcmlX?= =?utf-8?B?KzJqS1h6MW43VEh4UnU2SW5DMi9DZE5UVGV6dSt1L09HQm1YNmMzY2tIelRL?= =?utf-8?B?aWkranh4WnNzMWZwUG9zaVdXcEVWblR1S3drTnRpNktndnJzTnlBbXdtZHp0?= =?utf-8?B?T1BBUWMrczNXaHl2VFB0UjlkdGJsRzVoY2srYmY3V08wTlBrRnRsdVAwZ0J5?= =?utf-8?B?UW81eEhNRGE2R0lZS1hhZ0MvbXJYSW8xY2tIOVE3RXlGelQwYWI5YS95allW?= =?utf-8?B?cnlURDhTK1FVMDhZUHZyZkRvdWd0ZzFVUTJYNFpjWWxvOGw3UkJaLzVBVDhP?= =?utf-8?B?UmpabStXb2NBdURHaktHUWZOTUc4Wm9TcHlrZVE0YUo0alJWdkpxaktGSmkv?= =?utf-8?B?M2k2cHlKcWU2ZmpnQU9oQjdIWnp5MnBKNUt2eVNYTG5zL0JodU9hWSs4UERB?= =?utf-8?B?bHVlVG9xdlRxUit4RlFXMU1Hc0h2cnYyRUJKbU9GVHBqMXpBNEJLeU5jVEY3?= =?utf-8?B?Qi9Ednd2QnhKWFFBZzU0WkxZVy9tVjZ0WndYR001c0xwdjBDTzlsc0pMOUd2?= =?utf-8?B?YXhaRWdGc09jZVo4Y0xqaDh6UUQyK1liZ3h1SWVtOFhhR3c9PQ==?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 21:51:42.2417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 525644a4-e635-4cb5-142b-08dcf53f3650 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5998 X-Rspam-User: X-Rspamd-Queue-Id: C644C18001B X-Rspamd-Server: rspam01 X-Stat-Signature: ud5ix1qmffjhih6t4tdz931f1tewzagy X-HE-Tag: 1729893103-658012 X-HE-Meta: U2FsdGVkX1/xjrrI4k03Olp2jDPs/ZXMBM6mFdqfwqcYJnDMBOqVaraY2oWSG+PkZRyp7I9wdFASOfw1f3H+eW6I3nI4TZ1enSlwY7bS3ZZqEO07+P8maYAnIszlpM0Ohdcpc4ujvZ5Jy2qsBjpRbNHBEs6J7/FNTICECM3xfIVIfMHMCz5445/FMaqGtDsDfpqCHHGxvYcFOkQ7e8FY1srjKX0hqxYWsTZkKDSLP5TYEUY6z/8y7z+w1aaJt1aaKthpHtJdj6+cQ4vLKZNjUW8eHnfBGO0VdOs7mgc5ebqoUrVWxGKHOgQ3UWsqhOOr9qy5mxWyG+Xlq7GMLXOHx+IWCCo/H5PCO9m4qhQ6sRPELwscqloKA+wR2FUoaRVKCuo0Bxj4QM6YDsCFxMTO32Kb/y0WSnDAgFZjGGz3rjcaVnpFCjs1CVerkGM7L3CPxFreyHAqw2aNd8f5DW1lsZbZeL5ulviXh+NdVvFyBKaLEepf7+UfN9fNvtPwYKbxTU2OaHla5nsVLilwfAWoysVHIFdsSKWwvQ8GYoeam2bBrxrBw7KHfT7g83Ftza/an0T5WRs6xhttXKBrnMHtevuhBUEYdrxmplUlZMiacjnB6dHovG0AhfBrJZblzzgT+HAl2yWA8wERM7O13BsW9CTxmmHWZ3kdo9qCjzU41Q9pMAMDjiaEx9yG0TINBJqCXnvuQ9ZSkO/9273OfCUdDRDcUWBG0o9KRdGg2HH8uuiMU8aWrXmxtnAT9r+TjrnDVmTEFhQfUMyLx5Deifj4DmTKSY2W+ZybNegov70mtl/OPK70DeARfahyUokMGnT91jQjfeFbgZsSwCXU1i5A90TpadH+knHYFeh6muVR0s2LSBneMNhaHxbr9iqQAgo2+Ux5kWOtqqbfXctSRPg5GJiq4wej6SCwM0/P8h6LxLB0l+tXRRqfYNJAF+XUz4bhDo1OmcUlS7JIvG2db4w FW9U28de jxYI1wXd6kHXaBYdjKi86yimK8r58AHxx7S/XS2YLb2r0wMKtvy8fYV6YfiiPrm/gGCTk3r4VqiNlVxudfZJ/QrRdzRgCFEuAVbO482V0VZd5mnF9ASXVW4kH49DTpEGlxAjLIBYp/oxW1Duvn+6J9msjksvAbZaiOgQafTc21MUSkrnBEt0AgWyfl0aPB/H8NwgGgUQY1kRvBUC4Y4JbWxsNijmKge/AohTT2WZnxpB+cuAh/YzfG90qzfEXHe8C+dcTtaJOyAD7Wl+qHK3EmrAIsbBp0I7L7pRb1vizDv7vrX7jCcdBL36NhZbtoHc2uo8+ubQHdvIRESdInmTqw5OwKB8/PiwjnvkhYgg+2XQl3OCvflgT8ZHASHk2JXrB0NAxPSNLA2WkuGHhGqLRndwWmMrYyyAw7fR9Qr2TgmPoJb+68qJkVtof+q2LmYxIvJytXkmMyCa61kwmDd9rv2jUuSfJOnLuZHDHbysFQOI5Rsxg9y+/9OZZlR+6Flm+0tkT0Y57oQ8P1BYyQ3Mf4p70n6q61nLveYVbAJcbgoCBR9FyPH+KvKAK02+VdSPIicc+3Lt5gl1c34Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008415, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 2:09 PM, Lorenzo Stoakes wrote: > On Fri, Oct 25, 2024 at 01:31:49PM -0700, John Hubbard wrote: >> On 10/25/24 12:49 PM, Lorenzo Stoakes wrote: >>> On Fri, Oct 25, 2024 at 11:44:34AM -0700, John Hubbard wrote: >>>> On 10/25/24 11:38 AM, Pedro Falcato wrote: >>>>> On Fri, Oct 25, 2024 at 6:41 PM John Hubbard wrote: >> ... >> I'll admit to being easily cowed by "you're breaking userspace" arguments. >> Even when they start to get rather absurd. Because I can't easily tell where >> the line is. >> >> Maybe "-std=c89 -pedantic" is on the other side of the line. I'd like it >> to be! :) > > Well, apparently not... Why not? Your arguments are clear and reasonable. Why shouldn't they prevail? Please don't think that I have some sort of firm position here. I'm simply looking for the right answer. And if that's different than something I proposed earlier, no problem. The best answer should win. ... >>> The bike shed should be blue! Wait no no, it should be red... Hang on >>> yellow yes! Yellow's great! >> >> Putting a header in the right location, so as to avoid breakage here or >> there, is not bikeshedding. Sorry. > > There are 312 uses of "static inline" already in UAPI headers, not all > quite as obscure as claimed. > OK, good. Let's lead with that. It seems very clear, then, that a new one won't cause a problem. > Specifically requiring me and only me to support ansi C89 for a theorised > scenario is in my opinion bikeshedding, but I don't want to get into an > argument about something so petty :) An argument about the definition of bikeshedding sounds delightfully recursive, but yes, let's not. :) ... >>> ANyway if you guys feel strong enough about this, I'll respin again and >>> just open-code this trivial check where it's used. >> >> No strong feelings, just hoping to help make a choice that gets you >> closer to getting your patches committed. > > I mean, you are saying I am breaking things and implying the series is > blocked on this, that sounds like a strong opinion, but again I'm not going > to argue. Actually, Pedro's request kicked this off, and I was hoping to dismiss it--again, in order to help move things along. My opinion is that we should shun ancient toolchains and ancient systems whenever possible. Somehow that got turned into "I'm trying to block the patchset". Really, whatever works, follows The Rules (whatever we eventually understand them to be), and doesn't cause someone *else* to come out of the woodwork and claim a problem, is fine with me. > > As with the requirement that I, only for my part of the change, must fix up > test header import, while I disagree I should be doing the fix, I did it > anyway as I am accommodating and reasonable. I agree that pre-existing problems in selftests should not be your problem. By the way, I'm occasionally involved in helping fix up various selftest-related problems, especially when they impact mm. Send me a note if you have anything in mind that ought to be fixed up, I might be able to help head off future grief in that area. > > So fine - I'll respin and just open-code this as it's trivial and there's > no (other) sensible place to put it anyway. > > A P.S. though - a very NOT theoretical issue with userspace is the import > of linux/fcntl.h in pidfd.h which seems to me to have been imported solely > for the kernel's sake. > > A gentle suggestion (it seems I can't win - gentle suggestions are ignored, > tongue-in-cheek parody is taken to be mean... but anyway) is to do Actually, these come across as sarcasm, especially in the context of these emails that show you are becoming quite distraught. I've met you several times at the conferences. We get along well. And your work is top notch. So please consider that I'm very much supportive of you and your work here. I'm still trying to understand why you are recently sending these very strong emails (Vlastimil also took some heat), but I see that you also mentioned some long hours. If my feedback is making things worse here, I'll try to adjust. Selftests in general are a frustrating area. thanks, -- John Hubbard > something like: > > #ifdef __KERNEL__ > #include > #else > #include > #endif > > At the top of the pidfd.h header. This must surely sting a _lot_ of people > in userland otherwise. > > But this is out of scope for this change.