From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59224CF58CD for ; Fri, 20 Sep 2024 05:49:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A2346B0082; Fri, 20 Sep 2024 01:49:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 852246B0083; Fri, 20 Sep 2024 01:49:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F3146B0085; Fri, 20 Sep 2024 01:49:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4CC1A6B0082 for ; Fri, 20 Sep 2024 01:49:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 00CE61A1240 for ; Fri, 20 Sep 2024 05:49:45 +0000 (UTC) X-FDA: 82584039972.06.AA0F3F4 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf05.hostedemail.com (Postfix) with ESMTP id A26E1100005 for ; Fri, 20 Sep 2024 05:49:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iW9pquEJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726811372; a=rsa-sha256; cv=none; b=sfHswaoXPsJPy9diLwGlWPMJnQ7oneHRcVfjGl9XxklD7H2tLFr3sekNpBEJJ5Trffps7D zTAYtLbtLUiuDeatSgQW2tMu/CnB9+zXNjwlInrIe5apOKyPmHDdWLD3UPnsyETla6PLL6 VmQ5ElDpE6PGLkJWsfYEMgIk/3mk+t8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iW9pquEJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726811372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N/MEch8/IEY6HagRlbGjvEswxSLqewNlgwLCpHA91R4=; b=GIsfHhRVinYJnjMV+w4m3ALAXDNvxNklsSW3Vef2q/GTZO+VLrkxL34dcgz0rCSP6RW7Ug N5/THTOOH0VcczhBoh091OilnooYltRIKjgDJ34t7F5+lGy/+gsVsoDdVsOme7HuQJb41Y 7IYdkB5gzMis2ZZEpE5Yr2MfqNK5cbI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726811383; x=1758347383; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oMboSpzBWv5H2Scgue83a50Sb5B7byr4Rro21UDFgOU=; b=iW9pquEJ57ez9Y8B/CbNdteg9rVq7nAmJZgXN3hVXYEYZwWSEbpjldio gM2nrBON0g+5IgZJiu/NGkNqe7cbHs80c+awemUl2tXXSZh6w4vUpKgYN XfQ/ZT4qIJLe8rKL5b1Em1ed2APBfhCzHqC8RmWYLBAHLKt9fVeIOJsjF e0rQWNlFLldkzDJYU42cioTsdBFrKJf6FS531MIv1vP6uImDWuhh4LDzJ hSkTfGispd64r7PMPk3zg6ahm16HuwjBN74jQtHWIAxRW79J4TMc3O0AW NnEogcvTK1chNXJtoWoLwojvPWV0qkuiyhWtspY9oKClyiHXTbSUdBOV5 A==; X-CSE-ConnectionGUID: Yx51Db2ORtimolwGrS8JgQ== X-CSE-MsgGUID: 5qYNxhnzRoWQKvHcg0sl0A== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="29591058" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="29591058" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 22:49:41 -0700 X-CSE-ConnectionGUID: MfnWxp7ITZOvapuPBgD15A== X-CSE-MsgGUID: kiQgVevfT62k85MHRoowyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="71010311" Received: from ettammin-desk.ger.corp.intel.com (HELO [10.245.244.213]) ([10.245.244.213]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 22:49:34 -0700 Message-ID: <3309e9ca-458b-4b10-8409-9fe315b60ae2@intel.com> Date: Thu, 19 Sep 2024 22:49:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Paul Walmsley , Palmer Dabbelt , Thomas Gleixner , Dave Hansen , David Hildenbrand , Ryan Roberts , x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240920053017.2514920-1-anshuman.khandual@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240920053017.2514920-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: faxw76zoq8w6wt5rct8qz4apyams4t8p X-Rspamd-Queue-Id: A26E1100005 X-Rspamd-Server: rspam02 X-HE-Tag: 1726811382-491019 X-HE-Meta: U2FsdGVkX1+2DjeccetLS3V6rk4gTBwNWZNhpmAEmlkSAy8nWF0M+MojU5P89ymjpF8ltOwBz6tRy0D+nccewppdDQAHKyCz1Q5fWRxJSTeRoG0AJLfRsJMJHu7A/WREpg2+5ShAKwYZNHWfy+gtwV4CEkTMk/ljII86iQY6PE5kGaX6YNz4PHvvWLwCamunhQI4rzn0Qt68dFyIumq9P3rAlmaA54z04IeQ2dd8Rdq7mH8SGepi0jK35/nlCFJaYUOhZdlmrQj+CkgYJPYHuIUiVqW5agHIQoGufPX2+/rDscMUXk/Cltmy0MhtJRk9FaGFijRT3IyflW0sNtHPk6oBp/ImLt13HSRiDH17oF7kKkDO6NiB/jMFc0tTy6E7VFWmxGhWLGjE6VOMO/MAvfBcilkoDI4qbUFDZxd4mtksOeTKEkIfP7gUvVIGr/6iVGLpvBl0jiigFw7qBAv1jxWcd0MCGJfwN8YQOQ9c3Z/v5rceyP/oLGfWc1MPu8U9wVMWLcbGT+ouuy9OnNqToZk0z5l4enrJfGNqswZXwntcuFT+VqgVhGYAMjEc16bcabX8IvZdJQlVhOprvCA1iWrKCvaMLxkVx7BXOLZ4zyXQYKI9TQHDplOn/YCe0WrbSECvFLAzcsaGe88UOfkURbgA1rcgJTqVrQ5ZJwU/V1A+r8jA7x/LSTAg8+GosLcZx+IUjdbkOq4bRgPIogmRveudg9wZSnIIbJd+YWMLeiQtLcxqJPhVfZwmVZ//KE/38dWOcvNWe0frEq55T/80uO+Hi9IeklcjqqJiTNZMmD3/ndQQVs/doz2Nknhl3xUUmNbsptAOk4RRwEdSCB6X7W0mlsYbfMF4WXFEIa+l7m1W3BadJnt1louPMCFOO0V8qDbtJ2DYkqpgpHQSkHqGlupS8kcB1RBOvX+IkaTdUeqAemfd+HQh2cT2WRBiV59yR4b+hiD8qEjVUr0tTw/ KhuKTfjz 2fa7dRyW3xnT730e3J+lFxjcmPZNsEqnQ2VYO04fut5b6O3DduncE/RpZ3aR5zS4Uh1RMTat1naDSEvwra2nyCxmgCRt8ixSAXSqbJfc6dwpiaMXxf8VQuqjdNfkOT1/m3XPw3XfoHMiWMdZIdw48amVxbePXFbodvvML81sAktOLzE/ij9SfVK4NzxjIqjlzCWA4ZPaeuoQJHrfJgUav4VjdR4fApxP0t5x1WT7YVh53gj9LxpXqY7kFXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/19/24 22:30, Anshuman Khandual wrote: > set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv > platforms, do not need to be in the common memory code. Otherwise they just > unnecessarily make the common API more complicated. This moves the helpers > from common code to platform instead. I just did a quick grep and don't see any difference between the _safe and normal variants. A quick grep didn't turn up any actual users. Did anyone actually double check that these are still needed on x86 in the first place?