From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC9ECD1288 for ; Wed, 3 Apr 2024 10:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4FF6B0087; Wed, 3 Apr 2024 06:55:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A74CE6B0088; Wed, 3 Apr 2024 06:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93C7A6B0089; Wed, 3 Apr 2024 06:55:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7596D6B0087 for ; Wed, 3 Apr 2024 06:55:17 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F3DED160D70 for ; Wed, 3 Apr 2024 10:55:16 +0000 (UTC) X-FDA: 81967913832.15.8885E61 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 2D5D140008 for ; Wed, 3 Apr 2024 10:55:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PP++8r8Z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712141714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JOHdI5+Rm0qGsBNAwcaXDe1QoVGd2FuT8Hymhfhq4nw=; b=v+yGCXRbo5Xs3TtDP/eK4pZq5YICajIxE0PWh5IUjQmjq9E4pteKCGIWNJ84q8ixq7bx9J NQ+P7+qSeCyhzNhPKYKQUmjzMFJaf5Qri+xW13uFSm18LsDCH2DE0C2utAUkeV7peGVCn3 FHTSPV3TxkbzAnUR05CiIqIe1TrmlTg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PP++8r8Z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712141714; a=rsa-sha256; cv=none; b=OcEQBTIRe0Y/NDKKWHV8+jfiziF1NmRWuX+FQjS9pXsDtHW5naNrL4WWuJg2Iqbg2kKb/X 5Bf/zfLSkYUcF+mKy0bRE3yu1O+RN72U+6GME0qJq6H1Km5Y7s1q3dV7BYgTiAFJl8ALCW Wp+whkNtpZiqNB4+7J4hSDBpel0Cjm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712141713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOHdI5+Rm0qGsBNAwcaXDe1QoVGd2FuT8Hymhfhq4nw=; b=PP++8r8ZmpRyUlrcj2v3Wy11ek17NGtA+K5ivLqU+r7mCAyiGGdL9ovrhnzUGnsOgpN/by tGxQf+ed0Eakzgrh/H+ELH5TXS2meOZ3DwyB/a6U/Ksu22jy5QXkU6TyPEVxmupwCPG+FZ d7NK68gXhDAH8q+E7KPj4qOlSrJfh7s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-XFTgKXIOOraQHI6hCfH_XA-1; Wed, 03 Apr 2024 06:55:10 -0400 X-MC-Unique: XFTgKXIOOraQHI6hCfH_XA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0A868007BB; Wed, 3 Apr 2024 10:55:08 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97C6CC1576F; Wed, 3 Apr 2024 10:55:05 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240403101422.GA7285@lst.de> References: <20240403101422.GA7285@lst.de> <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3300437.1712141700.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 03 Apr 2024 11:55:00 +0100 Message-ID: <3300438.1712141700@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2D5D140008 X-Stat-Signature: 7pg8gi7mhnhfgjd9axsmfawqdckui116 X-HE-Tag: 1712141714-509591 X-HE-Meta: U2FsdGVkX1+a/qUdnSWQi47XbogzvO5EWzM8feEPWg1HklOC9rec4OMC8S6BcDCUgeLRz0ZDbxGLFKDDwU6YM/tsHragzXAGniHboRSn8CayUn/K/oIhLHO98x3OrbVgjExA6FT5S8djKOiwDcw3s0K9MHd+fSLs9Td21WniekIa5/4mVSPu3Y/iqogg0bU9opkVg+WxLaTQ16ODeez847efCAObENXySW28NgG4H07R9Lu6jof3MAjlTVRA1wiY2dqM540JM/Z73a+Wb1I22nIUzxah+S9+Gq/+47K7zV7UqwtY4kxYpPyksczdH68ZkRhw+Ei4J12jctYhwxk3KsyDpJbFSLTObGMi5EpY6DDL2YTi+b1OdZZOuYaAYI4LyvK+an8xAoXJRVEelDpcp37rhP/cKmpkFQUS9DShOu85OidAA+AZ1S6ucFTKgt7593nzWPvvtYwNMzU4DcoynfUGjzBfFygj3sDoU4Wf9nmPIc6iYQGVg+dxGqgTGDlZwbZ8AtTkAkUVr2gkryBjkGj5lNVZ7WYdjW+DRXqZawLQAK3tAnNkRMOw0LYSIZ7w6tTqKCBTbgOO4p3KpUBH+SyIp4i8IJzuxOlb35Zgq6JqcvHIX/G/wZZCqi5pjMSyJ/NQfXwUeApO+d+PCnM6B7lk+uSZJVb4e9dSZMDOBkvqTvKgDVzq9UnSEnC6JaUsnPjOySFYC/cCG/FXfn0t0bnrPCwimbXc3KgaUkotGQ2Z9WEsj/gE68FTENXBzu8Dh814zuXYimcrqrb3gybbBqmN5tzHSCAHsaoO7SBTgdCJZVPxu3pBrYG3+3J1jp46RuBBZ6SuPGTBWv51aes3qNdI5sog1lRxb6UlLsiPA+AZFvMKt3DgRB/nKpC6z4wWboRLdDKLJqfMf30bG757pyCQIJUu8VCjUx4AwUmIXwc+y3vXn2n5/gnO8hWHJCjjkcrKbIbJF3wVCkwiX3Q z2IV7i4j R8YzShHqS+kEt2DDPurP4LRkg1OaQFLJziHvotrXOZTlQQfCt1A12awlt3Ie+9hBv/jvvzQZRQY8woFBny2MI3fD+NNwARs9AYl3PnogVtrbkOF8C08S4l0/UhwwpMV1K+uymnU4irrJDMiQZaLJbTRHyKsyWdSs1ueJMQMv47KWDE1i+rc6OQCtGIYYm/WypPAXxHmZQ9MefTtA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christoph Hellwig wrote: > On Wed, Apr 03, 2024 at 11:10:47AM +0100, David Howells wrote: > > That depends. You put a comment on write_cache_pages() saying that pe= ople > > should use writeback_iter() instead. w_c_p() is not marked GPL. Is i= t your > > intention to get rid of it? > = > Yes. If you think you're not a derivate work of Linux you have no > business using either one. So why are we bothering with EXPORT_SYMBOL at all? Why don't you just sen= d a patch replace all of them with EXPORT_SYMBOL_GPL()? David