From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3CAC83F1A for ; Mon, 14 Jul 2025 20:28:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 598F08D000C; Mon, 14 Jul 2025 16:28:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56FF48D0001; Mon, 14 Jul 2025 16:28:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AD308D000C; Mon, 14 Jul 2025 16:28:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BACB8D0001 for ; Mon, 14 Jul 2025 16:28:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4061F1A0242 for ; Mon, 14 Jul 2025 20:28:27 +0000 (UTC) X-FDA: 83664007854.17.CBE438A Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf05.hostedemail.com (Postfix) with ESMTP id 0700B10000B for ; Mon, 14 Jul 2025 20:28:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wXZrJShm; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752524905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8fQyIOsuNSBC9vq4oF9Pm+Z2yhRW3OY+Y+eyPVEJoZY=; b=5b2QfR2g6aFdhpxQDlUhPZnRzhkjyoiG3265yfiZFw3jFu4pePiULl+6e/u9uwUpECZkBq 9R0YhkhLKm9myXSoZUkyCvywFIwZvq5iDAMnVCSRa/ZYM5xD3oEf6zfp6NXFjYXcSVvSQ7 8oePmE3B7KbUBt7Nb/aREpHDgYCYjec= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wXZrJShm; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752524905; a=rsa-sha256; cv=none; b=Aj6G9BGvcMP1JAt5vAUAsq27xiBtJ3SkAcYqZtuAn7ts5xwTvYzdCQU2U+p3+fxAF1f5AI fEHhxu8+Vnot2zPJBV1Od+VvQlzaVTxVOWwhwFlmrMbQsMc0vwVwk5oi574WDFEdonKITE cbqdnd06s4YT/CeANNMXBDym8dV6CHg= Date: Mon, 14 Jul 2025 13:28:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752524900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8fQyIOsuNSBC9vq4oF9Pm+Z2yhRW3OY+Y+eyPVEJoZY=; b=wXZrJShmdA5Pomt3K5vyoc9cM4l41sRzQeghtojgmSp3zAijJFzknrSEkPNgYyrx/25a5y HpHZXsHVReBZwAezJ1ag5gCmw7GXb/vLVN4nK5K9i7zsa1rIikqMuAdEp/TLaG3w6aBOs8 LWWb95KQ8daBG8AYj+lv8vawF649WMg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Hugh Dickins Cc: Roman Gushchin , Andrew Morton , Johannes Weiner , Lorenzo Stoakes , Michal Hocko , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: skip lru_note_cost() when scanning only file or anon Message-ID: <32nmrynnyg3fazfq6i7uddczzahwia3ae2c7etiaaqphmqg6kb@rswensgq2mys> References: <20250711155044.137652-1-roman.gushchin@linux.dev> <8734b21tie.fsf@linux.dev> <21100102-51b6-79d5-03db-1bb7f97fa94c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21100102-51b6-79d5-03db-1bb7f97fa94c@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 0700B10000B X-Rspamd-Server: rspam06 X-Stat-Signature: e7ybgwa33upix3kctk36ane5nbrpdjod X-HE-Tag: 1752524903-483106 X-HE-Meta: U2FsdGVkX1/SoKIKfmF5iSLZhPus5jqhr2OpFzFU/AspaUP+BE4XC6g7AvJ7RlkcPbe2+YgOO6gqU5d4OImyMsRTPOjMXyhJbECZdSQd4oLsMnjjR9h4bBSsIxa0ww4q3+ur8wD1Pu0Pl28GdTboMvtVxfB/ZaOJPXCsxjcpJKS/ol8QBdVx9Z9wXTgwT7NKOtGNIGoAIXW1j9rZWdvR+brRD3zwyoe1kJrczOdWNUZ07eAfLR1iMB4IvJKoAzSbn9Y32nMkQBhVDP525N7pbkfFNK+w7F4hJ+VllOhSqK/GmRUK+OJBPNtkKJ1q8VUa7PegOhYchm9fWa2vdyKymaImNOOpsl8Ew6TI3eWneIhd3cZIizgu58A5TrreHRbzYX1xhsKui/13irP0XCTVezLq+bmxtkS91RBuUQlAdkDf732c+9ah1vf49gSiRJefYhTpSqQx9EbsAGJCW8sKjqJhT/SeKCScz4qyQiCHS70E7h9oi6VPJ+9KUCc42YF7IoyVNQaKZsdnjLA3l6QjanLjIbyl/nyF/1raiIF3i9GPgIHix/uf+p8roy9I7U4HqcpDKeSha/6LNB5c4LgqAQIlQEM0dE2dVghnauMWDth6Pi5ns5iLTPzUeo77r9DAk1qr87fKS0Fp7Y2pEeAqGV9RB8WwU7LNjVMCkoTcbfF24jRyDG23NYHHMKJW6hydGIYEyKSkkS9Qz/dA+mnmqIPCqQgtB2XO1V3cNhpx6qdqp+BiK7LGPvl/x3GQjue0JHqjWZa/d9v07f9RdvFcQJNur/u7ikwKozOChpqrSEmCooKFRgyly4FwXCQt9x9YKV7JZ09WjKx6brGcuuzJrtRlLgNqBr55HswUYK+vsoHu1ct+Rf9+FDeuFXHTPAqNr75Pa/m0Tcr0v+U7vixaEh3Jy7FLNpaKzfDx4+SlJYHd0CF8HjAbgkylCBiGi6ofwmZ2KhPA8WUQyiSMBxJ SMapT7IH SOF6sIE2WXqvUux0H5qDQYlfCusSiXaAV889aPU/7APhALc2nAhJ5PPdzkslJlIaB8/rb3BPlVByE3FLuja1BiRO5I8vxp1tHCaxNe8eaGZZkU7a7PO2n94NQMCjaicXG8ykWk2LYQ1nU9jtnTfzebpRDulRYuGnv4mUHS3wzWNv3k0bcGjloWfewtbbd9jnuF3Z7aWvNhsNOH3pi9kZZTIsxLQkxOfjf048kKe9DJaKf3sBcHH/0wwlQE/kQOmVhKEODQlam+mCvCehoMGBg7F3s7ix17S7dGiq7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 13, 2025 at 12:57:18PM -0700, Hugh Dickins wrote: > On Fri, 11 Jul 2025, Roman Gushchin wrote: > [...] > > [PATCH] mm: lru_note_cost_unlock_irq() > > Dropping a lock, just to demand it again for an afterthought, cannot be > good if contended: convert lru_note_cost() to lru_note_cost_unlock_irq(). > > Signed-off-by: Hugh Dickins Reviewed-by: Shakeel Butt