From: Vlastimil Babka <vbabka@suse.cz>
To: Hugh Dickins <hughd@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
David Laight <David.Laight@aculab.com>,
Joel Fernandes <joel@joelfernandes.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
rcu@vger.kernel.org, David Laight <David.Laight@ACULAB.COM>,
Kees Cook <keescook@chromium.org>
Subject: Re: amusing SLUB compaction bug when CC_OPTIMIZE_FOR_SIZE
Date: Tue, 25 Oct 2022 11:17:39 +0200 [thread overview]
Message-ID: <32fe01dc-dda1-2154-af8e-7e9f64d6f811@suse.cz> (raw)
In-Reply-To: <904cc831-eb16-b1e5-10e5-9e7a171ef83@google.com>
On 10/25/22 06:19, Hugh Dickins wrote:
> On Mon, 24 Oct 2022, Vlastimil Babka wrote:
>>
>> [1] https://lore.kernel.org/all/aec59f53-0e53-1736-5932-25407125d4d4@suse.cz/
>
> Ignore me, don't let me distract if you're happy with Matthew's patch
> (I know little of PageMovable, and I haven't tried to understand it);
> but it did look to me more like 6.2 material,
Yes, it is targetted towards 6.2 now.
> and I was surprised that
> you dropped the simple align(4) approach for 6.1.
>
> Because of Hyeonggon's rcu_leak_callback() observation? That was a
> good catch, but turned out to be irrelevant, because it was only for
> an RCU debugging option, which would never be set up on a struct page
> (well, maybe it would in a dynamically-allocated-struct-page future).
It was mainly due to David's observation:
https://lore.kernel.org/all/c1c8920a56014a179dbb82d483f2ad28@AcuMS.aculab.com/
I did also conclude that align(4) indeed overrides anything set via
CONFIG_FUNCTION_ALIGNMENT (and passed by -falign-functions) in a way that a
globally configured larger alignment can be made smaller by this macro, and
it was all too risky and last minute to me, while Joel's series wasn't
targetted to 6.1 anyway so there was no urgency.
And yeah it looks like a gcc bug to me.
> Hugh
next prev parent reply other threads:[~2022-10-25 9:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 5:16 Hugh Dickins
2022-09-28 5:49 ` Hyeonggon Yoo
2022-09-28 13:48 ` Joel Fernandes
2022-09-28 15:09 ` Hyeonggon Yoo
2022-09-28 16:20 ` Vlastimil Babka
2022-09-28 17:50 ` Hugh Dickins
2022-09-29 9:58 ` Vlastimil Babka
2022-09-29 21:54 ` Hugh Dickins
2022-09-30 7:39 ` Vlastimil Babka
2022-09-30 10:45 ` Hugh Dickins
2022-09-30 11:02 ` David Laight
2022-09-30 16:21 ` Hugh Dickins
2022-09-30 21:34 ` David Laight
2022-10-02 5:48 ` Hyeonggon Yoo
2022-10-03 17:00 ` Matthew Wilcox
2022-10-04 14:26 ` Hyeonggon Yoo
2022-10-04 14:40 ` Matthew Wilcox
2022-10-05 11:07 ` Hyeonggon Yoo
2022-10-24 14:35 ` Vlastimil Babka
2022-10-24 15:06 ` Matthew Wilcox
2022-10-24 15:24 ` Vlastimil Babka
2022-10-24 16:49 ` Vlastimil Babka
2022-10-25 4:19 ` Hugh Dickins
2022-10-25 9:17 ` Vlastimil Babka [this message]
2022-10-25 15:45 ` Hugh Dickins
2022-10-25 13:47 ` Hyeonggon Yoo
2022-10-25 14:08 ` Vlastimil Babka
2022-10-26 10:52 ` Vlastimil Babka
2022-10-26 12:29 ` Hyeonggon Yoo
2022-11-04 15:57 ` Vlastimil Babka
2022-09-29 11:53 ` David Laight
2022-09-29 13:01 ` Vlastimil Babka
2022-09-29 14:04 ` David Laight
2022-09-28 17:56 ` Hyeonggon Yoo
2022-09-28 19:53 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32fe01dc-dda1-2154-af8e-7e9f64d6f811@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcu@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox