From: "Garg, Shivank" <shivankg@amd.com>
To: Zi Yan <ziy@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/khugepaged: remove unnecessary goto 'skip' label
Date: Fri, 19 Dec 2025 17:50:39 +0530 [thread overview]
Message-ID: <32f3f9dd-f84c-4113-b356-01750b2af80a@amd.com> (raw)
In-Reply-To: <848E8F85-CD24-491C-8A3B-474E4FCBF995@nvidia.com>
On 12/16/2025 8:57 PM, Zi Yan wrote:
> On 16 Dec 2025, at 6:11, Shivank Garg wrote:
>
>> Replace 'goto skip' with actual logic for better code readability.
>>
>> No functional change.
>>
>> Signed-off-by: Shivank Garg <shivankg@amd.com>
>> ---
>> mm/khugepaged.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
> LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>
>
Hi Zi,
I noticed that b4 didn't pick up your Reviewed-by tag automatically (possibly because
it was on the same line as "LGTM."). Just thought I'd mention it in case it's helpful,
Since maintainers may be using b4 or similar tools and your tags might occasionally
get missed.
Of course, I'll make sure to add your tag manually when sending v2.
Thanks,
Shivank
next prev parent reply other threads:[~2025-12-19 12:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 11:11 [PATCH 0/3] mm/khugepaged: minor cleanups Shivank Garg
2025-12-16 11:11 ` [PATCH 1/3] mm/khugepaged: remove unnecessary goto 'skip' label Shivank Garg
2025-12-16 15:27 ` Zi Yan
2025-12-19 12:20 ` Garg, Shivank [this message]
2025-12-19 16:00 ` Konstantin Ryabitsev
2025-12-19 16:07 ` Zi Yan
2025-12-17 2:48 ` Wei Yang
2025-12-19 9:24 ` Garg, Shivank
2025-12-20 0:38 ` Wei Yang
2025-12-20 18:32 ` Garg, Shivank
2025-12-21 1:16 ` Wei Yang
2025-12-18 9:14 ` David Hildenbrand (Red Hat)
2025-12-18 16:41 ` Liam R. Howlett
2025-12-16 11:11 ` [PATCH 2/3] mm/khugepaged: use enum scan_result for result variables Shivank Garg
2025-12-16 15:38 ` Zi Yan
2025-12-16 16:20 ` Garg, Shivank
2025-12-18 5:40 ` Garg, Shivank
2025-12-18 9:17 ` David Hildenbrand (Red Hat)
2025-12-18 15:54 ` Zi Yan
2025-12-19 9:45 ` Garg, Shivank
2025-12-16 11:11 ` [PATCH 3/3] mm/khugepaged: make khugepaged_collapse_control static Shivank Garg
2025-12-16 15:39 ` Zi Yan
2025-12-17 2:48 ` Wei Yang
2025-12-18 9:18 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f3f9dd-f84c-4113-b356-01750b2af80a@amd.com \
--to=shivankg@amd.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox