From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790A9C4338F for ; Wed, 25 Aug 2021 08:16:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCB14610F7 for ; Wed, 25 Aug 2021 08:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DCB14610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 336C06B006C; Wed, 25 Aug 2021 04:16:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0358D0001; Wed, 25 Aug 2021 04:16:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160ED6B0072; Wed, 25 Aug 2021 04:16:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id ECA286B006C for ; Wed, 25 Aug 2021 04:16:10 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 97F948249980 for ; Wed, 25 Aug 2021 08:16:10 +0000 (UTC) X-FDA: 78512895300.34.B9D3217 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 35F5FF000392 for ; Wed, 25 Aug 2021 08:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629879369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W3kk85j4W9zJim+yIZCUmng/KT5kpvGwAKM1Z2j0VRA=; b=UV+0Jf066thbaocrcyglTp58jqLFHUhgM43+FI9KR/gfCL/QK34gGuEOIFgbUbNAqzYJd7 8DAmqx4cALeH6pEOddhG/QPzFUxcsUQBF616Hc//28uHgV/NzQhMJXiuaOtHSTL/d6j7z/ Fdq4lrFnB0Gp0DXlnf8Q6jXKPmfGVFg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-pSwQRK_cNq6DymQTYQDq2w-1; Wed, 25 Aug 2021 04:16:08 -0400 X-MC-Unique: pSwQRK_cNq6DymQTYQDq2w-1 Received: by mail-wr1-f69.google.com with SMTP id p1-20020adfcc81000000b001576cccf12cso856838wrj.6 for ; Wed, 25 Aug 2021 01:16:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W3kk85j4W9zJim+yIZCUmng/KT5kpvGwAKM1Z2j0VRA=; b=G6NtdJu7fvkrnzZaroj3OsMHRM13sfFEqVk1kl/liC8Z1h3xBgr0TF0jg5mjfAhjpq 6gpnwDbfkHuRka2vJfKtN7eAAuXT9EIJVEvAIlZ3pcwg9ulZjor0F8g+yx+cl6xzTn8T KrUAsLDqtnpu451KVMqf/mSifEAGRQ7noJX9KcmlFgFpfhxJ7hIk4at5QcBmdLwuXPT8 TH6cgM49QupL4Gb+0gQlTfuBPrelju/RZtlgVzKflBTKU2oJ4dqr8n2Uw6k6PgZhJcIu LiLBI9qb698odAIqGbD48xOkvJYoWacH6qyr1RASnAoxbpVPc3cntY20Q5epC1rUq528 IUZg== X-Gm-Message-State: AOAM533kSPMYYdvTVrV6DMmmJTmodSG6TVl9B8NnFqtVxtiNCeIvK6T8 is6MYatDHaV3on9BQze/20UixK+jU35deMpjXq4wAQ2fG5wg7YSnQy/o4+2f3pAHa5G+JWeVR2m WSWZ5ejAcEqU= X-Received: by 2002:a1c:a94c:: with SMTP id s73mr8209350wme.12.1629879367327; Wed, 25 Aug 2021 01:16:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+Vti2X7N4d7BWUb73EOFI18iWBQZPD2EE+9uTQhf4cSJLgUwfjGXyklR3giymkJ29/W45mw== X-Received: by 2002:a1c:a94c:: with SMTP id s73mr8209321wme.12.1629879367093; Wed, 25 Aug 2021 01:16:07 -0700 (PDT) Received: from [192.168.3.132] (p4ff23d6b.dip0.t-ipconnect.de. [79.242.61.107]) by smtp.gmail.com with ESMTPSA id n14sm10153000wrx.10.2021.08.25.01.16.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 01:16:06 -0700 (PDT) Subject: Re: [v3 PATCH 3/3] mm: hwpoison: dump page for unhandlable page To: Yang Shi , naoya.horiguchi@nec.com, osalvador@suse.de, tdmackey@twitter.com, willy@infradead.org, akpm@linux-foundation.org, corbet@lwn.net Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210824020946.195257-1-shy828301@gmail.com> <20210824020946.195257-3-shy828301@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: <32d21645-699e-09a8-9c77-67c448e1037b@redhat.com> Date: Wed, 25 Aug 2021 10:16:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824020946.195257-3-shy828301@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UV+0Jf06; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 35F5FF000392 X-Stat-Signature: 48ozzqtynyjwek6mhx5gdsxqdaapunoz X-HE-Tag: 1629879370-773018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.21 04:09, Yang Shi wrote: > Currently just very simple message is shown for unhandlable page, e.g. > non-LRU page, like: > soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 () > > It is not very helpful for further debug, calling dump_page() could show > more useful information. > > Calling dump_page() in get_any_page() in order to not duplicate the call > in a couple of different places. It may be called with pcp disabled and > holding memory hotplug lock, it should be not a big deal since hwpoison > handler is not called very often. > > Suggested-by: Matthew Wilcox > Cc: Naoya Horiguchi > Cc: Oscar Salvador > Signed-off-by: Yang Shi > --- > v3: * Remove redundant pr_info per Noaya Horiguchi > > mm/memory-failure.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 7cfa134b1370..5f8249e4d7dc 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1228,6 +1228,9 @@ static int get_any_page(struct page *p, unsigned long flags) > ret = -EIO; > } > out: > + if (ret == -EIO) > + dump_page(p, "hwpoison: unhandlable page"); > + > return ret; > } > > @@ -2205,9 +2208,6 @@ int soft_offline_page(unsigned long pfn, int flags) > try_again = false; > goto retry; > } > - } else if (ret == -EIO) { > - pr_info("%s: %#lx: unknown page type: %lx (%pGp)\n", > - __func__, pfn, page->flags, &page->flags); > } > > return ret; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb