From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E6EC369A6 for ; Thu, 10 Apr 2025 14:24:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 051966B00F3; Thu, 10 Apr 2025 10:24:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 024CE6B00FD; Thu, 10 Apr 2025 10:24:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE2AB6B00F3; Thu, 10 Apr 2025 10:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE7936B00EE for ; Thu, 10 Apr 2025 10:24:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 495A2140DB0 for ; Thu, 10 Apr 2025 14:24:34 +0000 (UTC) X-FDA: 83318354868.27.7564277 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id CE6AE4000E for ; Thu, 10 Apr 2025 14:24:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bQ19+Bo0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744295071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cogrv9qSy5JJwLnX5CdBGBAIWbaDO9BCFw+0D18Jb6A=; b=tH315Dng2+LF08Mo54IiJXRnBVF1/OoPcqIivSyDs4ZEdggY55ECLldt8q4e9oHMtudMX5 3hIrU6aJMmBEN6L3OqHUB2jIsZj47ILaRWCkmQvOk98Rjw4LWF7jo5p9V7d183qymZA3q4 ZENb16E5c22fxeUjj4Q/KqnNFTDpuoU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744295071; a=rsa-sha256; cv=none; b=H9BnTKWISgo/RkQKqO/sf78EoYh1iA90SohXJVdmnGK9PrVlVMI2DnqOx9IUetoYPdAtNW TXiO38r3P3jlh+Swc0z08pdOlc2CRS8yCv24fEGOG1ZLAia1mk5ZK1vIQvYiAfqQaLuKuI skCpyIqHwPZhNawG7+ckp/OosVkbXyw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bQ19+Bo0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744295071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cogrv9qSy5JJwLnX5CdBGBAIWbaDO9BCFw+0D18Jb6A=; b=bQ19+Bo0rF+n7cf9bL9JL/VnD2ouQnO0qWWbiVXEzpwecFSfQdZeUIdb/zUkXiphDoPddL 5tou4RMGg16o9IOeSfolvFmm/CeYl9woJSCQrCBhNfKddTRCqh01vkCEUOBFvgVwLs83EO tvJcecHOk2cj/vTEXRw6Euo6d4TkUCs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258-AcibvyLHMxiiaWhmRLozLw-1; Thu, 10 Apr 2025 10:24:29 -0400 X-MC-Unique: AcibvyLHMxiiaWhmRLozLw-1 X-Mimecast-MFC-AGG-ID: AcibvyLHMxiiaWhmRLozLw_1744295068 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39d8e5ca9c2so545835f8f.0 for ; Thu, 10 Apr 2025 07:24:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744295068; x=1744899868; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cogrv9qSy5JJwLnX5CdBGBAIWbaDO9BCFw+0D18Jb6A=; b=NeedTAHd1Hu4Imta3F8OpT+TUAt97pfcAUhDvcPHlQ6SUgZmZcLMNJ7SMKSQCM1fry T+cGdGSqSN7MY3rqDYcjPxs8DHDGbPWYScrm5+59v+ISHREN21CUTHw02t7fKf3Yn/So qclHVojJeqbEzvqHiHz9fdulz0l9+ryKZXb9XUPq2Oa4qjxRTr1PjbiqFW9bW6H8azw5 Wod2r5GRI3oxN47Ky+0ySCpdZbfLh4s2rS7GfG3Om9o5Q8pqGSKR7TnbnF/MZchrSl9L 3kMyOIpC373DG1dtklKsIubzjGTqllPruB8QLOfhXpZ3U8NcRc7352XGJa4+t9DMdTyA 7F7w== X-Forwarded-Encrypted: i=1; AJvYcCVJ7cJ/6guC58yDHCfYOd5seU0o75Ju5TBqPdYECyEQqfIjpAG1nPHurTtBSwmjROYWw15A2ONdCw==@kvack.org X-Gm-Message-State: AOJu0YyX4ZbOHQ8aOhlh5OWDIveGmA93E0RCWSDbi3ePXwqCZtN1jAj/ 7Ht8WGQfNjHTVlMkcWE89gHphwukKU10OVNPz9PwXe0dO6WhxEwbndzVUI+lP93RMGDoenPT51p H2Id6WHsoR676up0igLO9zvdgnIs6FEHM6dNXJALYoom2S+Qmm2hsh5lveZg= X-Gm-Gg: ASbGncsvEi+i0z/dh66+QmcrroWsmpPaek9BqORdpIgRKy+YieZe4Q3wfoJV08XHlcj UoNY+v6BGEDs6Szlp+kgryfR8bl8iM4yqeTD5hCHJVHV3suN4WULPXeQqtOWapXspYeLAlpeuy8 xKKZ7c+xfM/sisz//XojjZkP+q2UlvC02jwoLxu5QbpgvXU0TN55Af5hf0lPxQfDs4XZXxdAWZC UlM9TGrIQ/6IZ3gHsdsS0Dup+vq+7gwVpsVxn1lwirY4bpGwhX7t2dfOwn8pPJ8K4jBeLAyeMKN X4Cr6A1VzhhewSxT5VcwIaFUoWkrLGj0BuqT+aWgsED/opUbCHLESguGkY3vEoNtzkkIm4LJ0KS 4nqA5+tDWpDO5/7hvPAcQwA3+2k91gjv7k08mG3c= X-Received: by 2002:a05:6000:381:b0:390:ee01:68fa with SMTP id ffacd0b85a97d-39d8fd478d8mr2312664f8f.24.1744295068438; Thu, 10 Apr 2025 07:24:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8Bn7s6DpPfYgcl/M2M53UOPYHKLL0imCRu25NntEj2VeeysQV0NHjc1D5fGBcavhpUKgDjA== X-Received: by 2002:a05:6000:381:b0:390:ee01:68fa with SMTP id ffacd0b85a97d-39d8fd478d8mr2312638f8f.24.1744295068036; Thu, 10 Apr 2025 07:24:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:5900:d106:4706:528a:7cd5? (p200300cbc71a5900d1064706528a7cd5.dip0.t-ipconnect.de. [2003:cb:c71a:5900:d106:4706:528a:7cd5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d893f0cb7sm4998161f8f.75.2025.04.10.07.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Apr 2025 07:24:27 -0700 (PDT) Message-ID: <32c7a1e6-37fa-4d40-b09f-93712a69f062@redhat.com> Date: Thu, 10 Apr 2025 16:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/memory: Avoid overhead from for_each_present_section_nr() To: Oscar Salvador Cc: Gavin Shan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, adityag@linux.ibm.com, donettom@linux.ibm.com, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com References: <20250410125110.1232329-1-gshan@redhat.com> <9deb3725-8991-43d1-8c3d-56523fabff28@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: m11U1SIwGfYS-ZBtRuKMyjvMdL79k17y_QTDNBQ6Y00_1744295068 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CE6AE4000E X-Stat-Signature: b7rbeizrkfrdykyag1chndagijb9zbg7 X-Rspam-User: X-HE-Tag: 1744295071-688139 X-HE-Meta: U2FsdGVkX183Ws8elFL41hqqw+Qj8dqFlgemrx3aTGKcrH855eD22M0MqVKkYMoRn0MNvSmx5CgUycePwmaMwu3UB5P4BR7RvqZcoHR0wXKFIiMLbjTFl5ISUqGaMm6YlrgQ3eFyS6OS3niS15lAYgxpKDZAnh/BAkF4EI2O9Aw6sXeq33t+fSnywn3GqsknU2znjBwyMfr4o70CbK7MDqixeEf0B1jWiPtV4VP8cRLZEzgDcBBO+hWY7Cbl1CRa6RmUIdzF1aCQJSXCAUxzs7t0+qAyG/oJAiOlI7c6eY7RnNDQbG86TGeiV6GKYWogtUc5M5QqqrD24XEgx8Nu2Q0fCO+ItdntVC5X34khMPNA4OsHZA8byU0drrJZYtCFufQzr3HeT6tniEBen0WgJgK/ufSGbYG482hn8bgoC8ARAshdq0XedvdbOy4Muw0BdDZW0VF2qD9EvJeD7eKFTGfXGv9G/KkC1HRUeKKEXF8TqnQ31BqYAKz5ziqaXdzjrTDjBnOML7VusumMbi1Vsg4A9XHph7e3Ax0rAos18pWf/ibF2LKUjaZyBZkdMKzuMDk8bAWS+oeBDOa4wYYGRvjF1fcpULM7D3zY0POSNHdz5xqMRse+DQqjrZ2tmwYpKA0pyu5ygqIOQlDvmrQYExIwM1C1RH9cJYWxPm2TonNcWEWsptq+4KTDt7Udy9GzuhFOrcJZLwUQqaLmk3fuUxCqafJGqeFknnx+MstdGfYQFwU9c8JXxpxXCaxFAPy8q5QRnLWw+i9B0+lIp4c8FzzgRzAewtZCilAyP+7/3o1uIHp/6TINU3RxBcinL78exljP4t7NpM5Yez7mNDrWdiWUvVOvoHwCOUkw4xXR61CpetY08i6o/QdAULaqwKbVrtYCYpBPl8ha506PJadhT2a8/YnxQD7xGFOO8+CSCvh0c27o/OXrk6p3gQ4au38/LusJNoev332gIF7SVe+ aF3SvEBa MbcoNrgrK8zTJZMkXeTrhRFHBAAaeD6cJS79PAKCOV8HODPkOikpiKZufFR6QL49pVLMZ9orKJ+5AgVuq0eFMfZNdPk8HKO5ceMwndVU12LbL4rQejjYVjzJMUBOxScRXTNgCZ4/desrFVdd8JBFlfKGqinR5zSOrwe2s+S8UzPBshGvyIFMd3WG5KrW7rIWc1mS91MU2CRMhO8bztlche/dqRoeA6bLDuq6NfGV/EiyeWxkbVZGAtpvCQxIPz2+uiysqQ4ZDM0+BdB6awOGxMIGK6IAQGm+fX/8p96tiRoXQIYCrUcqLJaytA3mbK9N3AkWgwgBDjSXlLUgx+MpnsJ1j9vrQfO7lHjMHMNb+gXjz1CnMbXk3iP0sLnUzeFjlu+TkSa7vNC7Cgp4qwfHfEi7qc6ZrqQEhlG7T9V+ykGr+biDBcuH359+Bgoyk7lIoST865FvzAk3Dowj1pzGW47tllzazMW1ayQj8c6N4ZF+lTnycOBtL/xVG8T2MjsIlioyyYWlwYnGxhjUkfzn1o1U28/D9CDT6tRJT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.04.25 15:55, Oscar Salvador wrote: > On Thu, Apr 10, 2025 at 03:18:00PM +0200, David Hildenbrand wrote: >> Staring at the end result and the particularly long comment, are we now >> really any better than before 61659efdb35c? > > I think we are. I think you are right. The whole comment can IMHO be heavily simplified. Makes it sound more complicated that it actually is ... /* * Create memory blocks to span all present memory sections. Take care * of memory blocks that span multiple sections. */ Acked-by: David Hildenbrand -- Cheers, David / dhildenb