From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC756C282EC for ; Tue, 11 Mar 2025 18:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1017C280003; Tue, 11 Mar 2025 14:56:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B189280001; Tue, 11 Mar 2025 14:56:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBB47280003; Tue, 11 Mar 2025 14:56:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF41D280001 for ; Tue, 11 Mar 2025 14:56:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 087FA1C73A5 for ; Tue, 11 Mar 2025 18:56:33 +0000 (UTC) X-FDA: 83210176266.10.3FDD50E Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf02.hostedemail.com (Postfix) with ESMTP id AE64D8000D for ; Tue, 11 Mar 2025 18:56:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=2qF1u9rt; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741719391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s1YRjMruou9Tx5jtWPInc60tJt2gIen0DOp7oUm6XP0=; b=ic8w+LPBi0uwh26gm8HaKH1mpIEYiN2oP5ffwHe/hjKUqpVLqk7sQ27/j9DRO8GLVGX4IH eiqctS50tXdNcTyG6hDIhqSQuIoKofXLfKCv6HbS0hrxUGpEk9bC9BptWenKhNWmCqJ8GI sIXaEHAfpKLBC0zYHK7tfZigjsefqss= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=2qF1u9rt; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741719391; a=rsa-sha256; cv=none; b=A35+AVgl3U3FESamJ7PmoWbQ2nwD3Qis2phqx2WbwwXuN+cSAoEw1SPASxfxe7kl8xRhcp cezB6J63V9x04sADDMosp6qmQZMWpyC78CjfTGkoXNEZoOohycv+Jn18CV4bErGvEp6EpB mmDY4oBCkSTAaFxgIKcE5hrbzvj0HMM= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-3cf880d90bdso18072135ab.3 for ; Tue, 11 Mar 2025 11:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1741719389; x=1742324189; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=s1YRjMruou9Tx5jtWPInc60tJt2gIen0DOp7oUm6XP0=; b=2qF1u9rtOy+5kvvFTcsWmvT147L+4n7/ZLPVNvy7Trbl/dvUO6iDCMROC06jdclEHK +zsf8c6Njz/ReRuKwfpSkDad46wt+kmSdVr6VfM70zVj4YtCMuMC8OCQgmsX65Dhfb3j tffIVnBPilzwDuh4iHpamhc50j5JZQUvUfz135xKfdMZhxPB4YgWV2h3y72/BM8iKYL4 B7UPBj70rFzgHJu2xicfynf6HxOnRrI0y6Bhjo7IRMjA11QIvF/NNX7feccmQNGTGrhE Myhc0VpppikBxRoF6VwdIs/OhwqdKrQHj3Y4BfiFRrrFDnlahKyRuYREuqzwj9lEtQVf eXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741719389; x=1742324189; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s1YRjMruou9Tx5jtWPInc60tJt2gIen0DOp7oUm6XP0=; b=PybY2Se+K/nTFmDssRDxEM5oy6TrGF98uaKfWKa/Ue0D1MC7j6/P0PCDKl/OwcBhRr oTzTDxHBlzSBkcNm/O1TW9dvye5LYe7VJEJzIZUtKKXHkamPhB04lzjSbAh7pLsPpYTX PBewXU5bFkQAH/mQETmLnX11gQtT8EXBqHIGI5eAURptBRzNn/ITcm7DS8gbDp7CZSxY hSDexD9hZm6aUDFGtjzkQaUVdtCxtCJ8Q/6R6zoT0aWkNmnYVP/bCnFP5qm2UANyd76X /236bzM4OevXo01j3NUTkoz2gSdaF0W8pwCaNzeG62Z+WeV09rCiOz/GNLSyoYBOMHKr jD+Q== X-Forwarded-Encrypted: i=1; AJvYcCWiZ7oGP1fRQ13j76nxmSpkHGpNIdb6uaP0+KjUpZ+gZDwtD2PtJPsh7jvCKuyZZfzsAU3upUQHlQ==@kvack.org X-Gm-Message-State: AOJu0YworRm6f9OxnLZq9w9j+g4rkNwV20K348u7OOyhCv9ZhkV55lla 6CMubUzccifXuQO2fxswdZm+s7YG659uYVtn6FQa6C6x1Em5pTUzvsxFhV9c5Ys= X-Gm-Gg: ASbGnctHJA2y4Juw4Tp4uaffBA6y5+W6JjXRE0DGXvFMq5MwKFFTfutegUOiVJZdpvf bNEQFLgXQp6tQWba7yVLpwjUuAYU+pWKrM9nD7oCboD3SPZ4HY9eT4n+ZiZUANybkL4YHWJgTPS KgTws8VlzADdT0QBFyV/y0kZT0+OcQjfOqiUg34/yB//lzglYOxHaxEyXmU7JywNo9tN0Y+IWYs vLxpP9OJB/90zdU0WGp9AB3jDcbDTNYVaMZlhPdPWDokTPiNnTK3owFh2fBuGuLWr4uI56hsTwu kS00sajmrAsbaxF+hkSdcZaMVAsb/3d9oKlukncK X-Google-Smtp-Source: AGHT+IF6QEvMgNWs9dedBUfcF2UZXbN6XsW8AZipdiC80ycaj5jlFprQu0VmRz6Jjl/szbD7bbMzQQ== X-Received: by 2002:a05:6e02:1c0b:b0:3a7:87f2:b010 with SMTP id e9e14a558f8ab-3d4419712a9mr212361315ab.5.1741719388965; Tue, 11 Mar 2025 11:56:28 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f23abbf42csm1034856173.105.2025.03.11.11.56.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 11:56:28 -0700 (PDT) Message-ID: <32c6f6fb-d75e-45a1-b050-4c078a757a50@kernel.dk> Date: Tue, 11 Mar 2025 12:56:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Axboe Subject: Re: [PATCH v2 00/11] cgroup v1 deprecation messages To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?Q?Michal_Koutn=C3=BD?= , Josef Bacik , Waiman Long , Jonathan Corbet , Andrew Morton , Shakeel Butt , Roman Gushchin , Johannes Weiner , Tejun Heo , Muchun Song , Michal Hocko References: <20250311123640.530377-1-mkoutny@suse.com> Content-Language: en-US In-Reply-To: <20250311123640.530377-1-mkoutny@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: AE64D8000D X-Rspamd-Server: rspam03 X-Stat-Signature: a46gmifk9k64pxwi4dyfanestn5e7dps X-HE-Tag: 1741719390-341478 X-HE-Meta: U2FsdGVkX1/3ZQaNS+EafVea5W/kyy1LiSyQxD1CBYxCGclPcFqWhuGrhG5rCSS8W/qa5AKydbH7DsJHozCIlcrOziUH2wvfYuDF2H+3q6GLq16d+x84jve4WViLYWUCAlsu40V/jZrYPpxwSLfDLzUhh39BsxThT878K3gy9v8kVsBL3cq7SLkyYjFFoh2LCdtTSBeKJd2Tm51y7oNarW7hME4BT3DfxzJVBLXwTzWPjz3OcNpJJ49ITbAJ2LKyB+Jk+pJtwNyXNg85r95qEREImrAZelCSm4p6IlHVvWynxEaJ9ovs9ahD3S4H3ZkssdJDoJZY+Rj9ERXky5s9kEQyKgMwinFLn4+YLIm0evzXOKy3Y3T7dimdkZb9rdHSh2uzs9+/HBnpavD1E2VptTOSdLhxHpxzCnGO2RqbxfKFqNeUicpuTcRJAx3akNAFH44KQUKqvS03rafcXQn1Q+pyJCGAKpXfM8PBkBW4K5E/7JjAFzNiMaSeNl+A+d8p/1EbIjcKjNiX7O/+VHvpD0uZzB6GP1bV7NSDfogRZt82CoWvI69AUL1Ejq7MxjVwMrGzgZtRukyaRrlPhlS5qS2q0IlVhSkkBEB8W4sbWrtZ3+sS7SM2oQSN6oFkrHcfSynWXU8JSbglUI/5uLX25FZEyR8NbLZnaKN2atksqurlkncy6o3gjNL3nuC2LdztcBh/9kY6vlYRZQhqSIv/cgwInlHiM5KBbG/9NxkuLkCQIBYdoPH6GQWTTsUgLRoZSq3QkmvHBJXyPN2soenq74wEAV/J2CrCDnkeMWeM/Iz9C6pfMHQupDfTAUcSBdJC0H6oolpBReaKKCYzw1wKkxPMQnC9jCOTbnDXGQsFoGJjzdYx1WXJct9eH166sogkLUePHXqJynJ/eD40LbE5wVblKwnG2zuxuqAvpQxehC7GaQQmYMAD/e/tGRskmA6pqerwvanlihunsacn4Bi 5QYKCMdv u1wwzQ09lpWwb82lc/SBE8O3ZFmUWOpE/Gjk/wo+thouaWbQYnCuUR0FVx0vV9k+0JrHybU83AEr9GRINAEZzz13s0cyDZqkhIX4Ap/ZwVcWDpM1PjN8unbCSEMHR69Qek5SIvQo/jMMPKee25UmMTVMnP5E4fEJePseZCI6GzC9cIPuhvxZJbMk/imaThttgMHMtltZWtFSjikqMb5WVloWjYFSHnqmxKDul5jfGRYPLYw3YZXtq7uccB0jBEzV3OTNEnYRsDhdwRCe+UK7X2Ac4Preah1ZdC8vD9pkeIIqv2E+e3qBTx5MYyk/k0IgaoZqdvMnA6EZ7+6iTpqliTYfowasTaY/9Miyp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Memory controller had begun to print warning messages when using some > attributes that do no have a counterpart in its cgroup v2 > implementation. This is informative to users who run (unwittingly) on v1 > or to distros that run v1 (they can learn about such users or prepare > for disabling v1 configs). > > I consider the deprecated files in three categories: > - RE) replacement exists, > - DN) dropped as non-ideal concept (e.g. non-hierarchical resources), > - NE) not evaluated (yet). > > For RE, I added the replacement into the warning message, DN have only a > plain deprecation message and I marked the commits with NE as RFC. > Also I'd be happy if you would point out some forgotten knobs that'd > deserve similar warnings. > > The level of messages is info to avoid too much noise (may be increased > in future when there are fewer users). Some knobs from DN have warn > level. > > The net_cls and net_prio controllers that only exist on v1 hierarchies > have no straightforward action for users (replacement would rely on net > NS or eBPF), so messages for their usage are omitted, although it'd be > good to eventually retire that code in favor of aforementioned. > > At the end are some cleanup patches I encountered en route. For the block related parts, as I'm assuming Tejun will pick this up: Acked-by: Jens Axboe -- Jens Axboe