From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF578C433EF for ; Sun, 21 Nov 2021 13:20:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A1376B0071; Sun, 21 Nov 2021 08:20:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 351096B0072; Sun, 21 Nov 2021 08:20:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2400E6B0073; Sun, 21 Nov 2021 08:20:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 11F4D6B0071 for ; Sun, 21 Nov 2021 08:20:24 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BE6C3824C42F for ; Sun, 21 Nov 2021 13:20:13 +0000 (UTC) X-FDA: 78832995948.18.CDFBA72 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf01.hostedemail.com (Postfix) with ESMTP id CD0CB5092EF2 for ; Sun, 21 Nov 2021 13:20:09 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R231e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UxW0YE6_1637500797; Received: from B-X3VXMD6M-2058.local(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0UxW0YE6_1637500797) by smtp.aliyun-inc.com(127.0.0.1); Sun, 21 Nov 2021 21:19:58 +0800 From: Xin Hao Reply-To: xhao@linux.alibaba.com Subject: Re: [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig To: SeongJae Park Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211121112417.33255-1-sj@kernel.org> Message-ID: <32a90a3d-5cf6-66cc-fa3b-19753a057052@linux.alibaba.com> Date: Sun, 21 Nov 2021 21:19:57 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211121112417.33255-1-sj@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CD0CB5092EF2 X-Stat-Signature: gpqrbqkdfxcw5ydgytf8qp9op791qpu7 Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf01.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com X-HE-Tag: 1637500809-683469 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Park, On 11/21/21 7:24 PM, SeongJae Park wrote: > Hi Xin, > > On Sun, 21 Nov 2021 01:27:53 +0800 Xin Hao wro= te: > >> If you want to support "DAMON_DBGFS" in config file, it only depends o= n >> any one of "DAMON_VADDR" and "DAMON_PADDR". > This is not true. DAMON_DBGFS really depends on both. > > This patch even makes the build fails with some configs. > > CC mm/damon/dbgfs.o > linux/mm/damon/dbgfs.c: In function =E2=80=98dbgfs_target_ids_writ= e=E2=80=99: > linux/mm/damon/dbgfs.c:409:3: error: implicit declaration of funct= ion =E2=80=98damon_pa_set_primitives=E2=80=99; did you mean =E2=80=98damo= n_va_set_primitives=E2=80=99? [-Werror=3Dimplicit-function-declaration] > damon_pa_set_primitives(ctx); > ^~~~~~~~~~~~~~~~~~~~~~~ > damon_va_set_primitives > cc1: some warnings being treated as errors That is my fault,=C2=A0 i have found a solution, and i will send a v2 pat= ch=20 to solve it,=C2=A0 i I think DAMON_VADDR and DAMON_PADDR must be decoupled=EF=BC=8Cthe kconfig must support it, becasue sometimes = i don't=20 want to use damon paddr function, just only need to include DAMON_VADDR, therefore, it is not necessary to include damon/paddr.c=20 during compile time. > > > Thanks, > SJ > >> Signed-off-by: Xin Hao >> --- >> mm/damon/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig >> index 5bcf05851ad0..971ffc496596 100644 >> --- a/mm/damon/Kconfig >> +++ b/mm/damon/Kconfig >> @@ -54,7 +54,7 @@ config DAMON_VADDR_KUNIT_TEST >> =20 >> config DAMON_DBGFS >> bool "DAMON debugfs interface" >> - depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS >> + depends on DAMON_VADDR || DAMON_PADDR && DEBUG_FS >> help >> This builds the debugfs interface for DAMON. The user space admi= ns >> can use the interface for arbitrary data access monitoring. >> --=20 >> 2.31.0 >> >> --=20 Best Regards! Xin Hao