From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A30C77B73 for ; Wed, 24 May 2023 09:53:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C35C56B0074; Wed, 24 May 2023 05:53:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF5C900003; Wed, 24 May 2023 05:53:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3948900002; Wed, 24 May 2023 05:53:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94E456B0074 for ; Wed, 24 May 2023 05:53:14 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6209580949 for ; Wed, 24 May 2023 09:53:14 +0000 (UTC) X-FDA: 80824685508.05.28634D5 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf19.hostedemail.com (Postfix) with ESMTP id 751C51A001D for ; Wed, 24 May 2023 09:53:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IKjtGz09; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684921992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FrOm8kjaf/kMK6BQFjHY0qv4Ix8HtAKqXfw+FTyX2aQ=; b=eRb++Ho8+GCYRonbc/lPNZXMtVB8w2ck+0rZDIVcxoPRU/qa+dS8z8YGaSjN97L9E9Bs1t vU8LZ8buX/v7qctqINRH2s7kRQ2WqyCxpcU0nuqd+T92ueaepQHOuV2N9BvYKjCssFOXSQ YRwrSu9HMyh56dV20CvDHcYA52utWbE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684921992; a=rsa-sha256; cv=none; b=h6djPyegkhMMH4zOU1+it2D08jZFmqEsSTsF5p8PAXzZISxX8dervfx5RaDTENKZjtuK7n U4CAgYmweaJYv8xJmmVxKZlevhhpxIEJEL/QZwF2HrR7+xXNdRvsNeasimUVgm9BK+EtQ6 nQY66QB0wgyWBBXY/0ouL0FeJbpspZg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IKjtGz09; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3f606a89795so8355135e9.2 for ; Wed, 24 May 2023 02:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684921991; x=1687513991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FrOm8kjaf/kMK6BQFjHY0qv4Ix8HtAKqXfw+FTyX2aQ=; b=IKjtGz09U8TXKu2c8khn2oGWGxV1XKiDNHh+tnB7jByk95DYms1DdKaXgCIk0VAIcI jgUxOqJiTWzB41HOD+mcVdT+oywfZomR4l8e0ZIedsZc5yzyxUbAFSwo6mFfQpHsQQMT ulYK8k5D0NKjxj8ed62yu9gE1xIsXKCaGNwpGc/X1CwVeMzbxUNQWl3L74FKhNjIch8g 6faoSjuX3p1esWsz9eUKDa42zrEu1mbvEq6UfBIzmSY6iGQQEY6yvsfQtHK8jgiMnnAU AeFh8jz+/wFgwKbSqNll8KwPxQuzfX2ptBOTyiFNvm6cfwOig3Is6ZfJvaG+D6hC89UV B6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684921991; x=1687513991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FrOm8kjaf/kMK6BQFjHY0qv4Ix8HtAKqXfw+FTyX2aQ=; b=JfR5l4mYrXEnuMkYOiy3u06EYGs0dSPfVjytAXm4FGC5vt+Y/dru53rDpuHJrkROGV R0aowbHc9U0fsh1FqCb7Upp2T9SIFLrOeQDRyTBSTqQi9LikkPsYIxsllfH+y7VHzkUn 2Hk+7+UtL30owFNj8x9eVbmvfcNcILKxezDhFwCHPQa8fJZCIAbUgjPj1NMfHv3JXDhj 4SWn8Cdeh0iXF3LxnAmQuqw1KjSunq2WF0nwNYxsEsR0vkEQ9vupz7A/HiHvgqo1LMBh veEn5xV9Ncdz6RbbBwjBnKAwSMktr6sMlNhdw8ZKCMDhXRqFmSrYQ9uIQy0MuNZQtRTj 6mxw== X-Gm-Message-State: AC+VfDzdqAiFNPBXLf6IMUPFO6aa56aTvaJxPnN8MbFwU+12ygQ0h/O9 h3eaLK1Jv8tg4a5yu0MvMFrSUQ== X-Google-Smtp-Source: ACHHUZ6EZt3VMwP4c//tmcQVg2w1/GF2fX1tcNr51SPg1SpGZLIb2d2+OSTysJItOTvDJofcjjT2uQ== X-Received: by 2002:a7b:c411:0:b0:3f6:3bb:5129 with SMTP id k17-20020a7bc411000000b003f603bb5129mr7298406wmi.23.1684921990898; Wed, 24 May 2023 02:53:10 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id t16-20020a1c7710000000b003f604793989sm1741284wmi.18.2023.05.24.02.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 02:53:08 -0700 (PDT) Date: Wed, 24 May 2023 12:53:04 +0300 From: Dan Carpenter To: ankita@nvidia.com Cc: jgg@nvidia.com, alex.williamson@redhat.com, naoya.horiguchi@nec.com, maz@kernel.org, oliver.upton@linux.dev, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3 6/6] vfio/nvgpu: register device memory for poison handling Message-ID: <32a8c23a-7db9-4b9f-a2e8-cc978a9b8202@kili.mountain> References: <20230405180134.16932-1-ankita@nvidia.com> <20230405180134.16932-7-ankita@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230405180134.16932-7-ankita@nvidia.com> X-Rspamd-Queue-Id: 751C51A001D X-Rspam-User: X-Stat-Signature: jktrst5kf96kgybgcp86bm6tp4kp7wdi X-Rspamd-Server: rspam03 X-HE-Tag: 1684921992-838985 X-HE-Meta: U2FsdGVkX18IIAImOSSq19y5dWHaM1417QpNWjJCh6yjh/J+0w04YJWyEzPqOV8viqH3ZulNiKB7iuc7kxaFXoAj7pPyyn9gwsrI7QgK153XQmD6QM+ALYgjsl2uZWYd3NUdsYiEIPZG8ijsgYhfpE5HaFfAFQ3Kafe1dpww9AYj0p5lgE18eje8GBKwE4tQQ1rufslDUEckHiKpsWI8Seh3s3SUK4FDJd++LWtmeB+FbcHOZ8VNIGoKVBXr4vD1sd8P2nhlmTEEyOxqbe1DrOXhuFglVxTBcGMTtdTK7cuZQfH4BiHa3X+J4kx+birs8J+WXA8I1blEoJXpeGjzy8yLXsq6NBZRpk2Enr53wTsySS8B6QkimKDms21CeunQ4aLPU1OTx3KGrat9TpFeR+Y2cU9vBtLW6j0z0S8jnFOldi2GHEfuAG2kn5htRBGF6/tNPyQPtU4/kL1BzBfreeMKbehqK/F1/esQkEsuSSLKyTHucqRMQL9WE2aLIhSrV8ReEG4Xb3G8xHeeJ9qVs9Yggc4vEZGA7f5O+KS1a41qPrtDHxDPTuaQP3o+m2A7i6UatS+JrwhNNvH5ki1WCHiDg77men96VqBq7vM/D1kXmu3frkrQh73+dBJmDruRErYtk1jz3Fu/w8MbRvcUQNruSHhQXWi3/bEuD672qv2MyW/yAzZjPdBw+Y3wO5XRnMjqRSH7kiR+KFHGm4inHZcjmwj64+3YfHU4/uVtu4W5HV/2MqsiXHovbb1Ef/SXmEc+mrgY6/ufSGpGEHdWguUWvBqrpn7KLXdfb1Wg58dB6iId34W7vuFqcicH6ucqZyrEl0ZSkXrAj/SMXrP7crrUspq2bS/TqYAtUupxliSGKHVTKH3HofxFDmJCWDYhrq73keyDQPyyOlonlN/yrcLsS281pXSQ950evD+IFpHV8jwgqoy2waHK6Gx27grDbWMLC+aAFWsmFGoI8Cy FcQu3mbA uJMXLo97MiLSaeMtvXETlIucCsCJepshu+SrMl3ifocqj/I2c+OsSSoMqIz/tJxVVyAqFZUGsKTLKTaDSLFjFgVOE4xHyfdkfxV2ilLTsC/LgocbLdFWdDFw+lXp3AKrMZwug8/AzT2QXzAP242Dk73SnBlZjtClLxd/XlJj2QEmGCFD19qSLLkB0CzOYbb7oj47J0D3Em19Bhx3LeseXEumlpMy9ceBDX5CremK3n7rbPar4/nUYSTBZAEhNrIdxtB5O2xLZUr5J9E/NlI2IMxAxVNbMZrpnRlh4YhYEYatvLLs62uBOo8PEhz4qTFmx++6wjYr88NXfP74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 11:01:34AM -0700, ankita@nvidia.com wrote: > @@ -188,7 +277,20 @@ nvgpu_vfio_pci_fetch_memory_property(struct pci_dev *pdev, > > ret = device_property_read_u64(&(pdev->dev), "nvidia,gpu-mem-size", > &(nvdev->mem_prop.mem_length)); > - return ret; > + if (ret) > + return ret; > + > + /* > + * A bitmap is maintained to teack the pages that are poisoned. Each > + * page is represented by a bit. Allocation size in bytes is > + * determined by shifting the device memory size by PAGE_SHIFT to > + * determine the number of pages; and further shifted by 3 as each > + * byte could track 8 pages. > + */ > + nvdev->mem_prop.pfn_bitmap > + = vzalloc(nvdev->mem_prop.mem_length >> (PAGE_SHIFT + 3)); This allocation needs a NULL check. regards, dan carpenter > + > + return 0; > }