From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6468EC433FE for ; Fri, 30 Sep 2022 08:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A36A58D0002; Fri, 30 Sep 2022 04:43:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6818D0001; Fri, 30 Sep 2022 04:43:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ADF68D0002; Fri, 30 Sep 2022 04:43:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77F048D0001 for ; Fri, 30 Sep 2022 04:43:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 534FD1C6FB6 for ; Fri, 30 Sep 2022 08:43:18 +0000 (UTC) X-FDA: 79968112476.19.E8606FF Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf28.hostedemail.com (Postfix) with ESMTP id DCB77C0011 for ; Fri, 30 Sep 2022 08:43:16 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id h10so686358plb.2 for ; Fri, 30 Sep 2022 01:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=wJbYKGc9rVUqC784z1spy0gAYeIDAs7Zl7uyV0usPeU=; b=dVJtM1Aj+b/YJoEcHR+iLQPF1IwnZn9xe3IyYIvrAU2BZJASRsOmVWFRUX4ZgVCJby mK1boO8SEZe3oxZwDpzDSE9RwTirdRfJN3UNgrv0VzuLOMsQiw8q62dbQhVLkrDCVARH OuokrEP/EUvhrCEJLkeMJuJ5DIVSqVWa0vlDPXb5V37ay71s7+ZJoLkFdJW6XHPiNDvP x6qWgGFzO88wmfh3b00w4MXwO/OCdU0BFToopTHf3pnp/5vnrrlFcQcz2hleWdN0x7j7 UAk4jFJLjWFahBTKKQbndcV9x+qDAsf0gZVtrbaKGd3RYIJylfEvQ0FqMKxTqBPvOwVK ZmjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=wJbYKGc9rVUqC784z1spy0gAYeIDAs7Zl7uyV0usPeU=; b=T/wRQYf5/5bVuyNgab6Oh6Frn3MljsmKXmG4Q5RDiBsKouDhifhW2aAzadHT85Kcmv CfYH/xdsUkISPvarLPo2sHitnUUrQGSaBuQTKX0I05nUbljJQstf5t8JCT2y0L/4+Rxi ru+NKpTXoC81wdPRD/tJwE4wHgZeSTLWVJ8ZV6zOiNZUkCtR4nU9off2gLlcCwxh1CRb jMg6+TMEjXD125JkUCz1PIK3PMlaQ1r0XVX6O26LZX4intZXjtHTv0jtN7q8aG316ILI YvDABdmR8WBxhv9J2m1L/mYMElfU/voss1f6uDxPSS7Z6JF1+FHw84+Yx5Ybbt9VL2IM 3ptQ== X-Gm-Message-State: ACrzQf2VIHxzNsksVn8WVjKQI5EwI0PSwu35FUTWhfm0rX/eTNoZG7mr Udn+n+F1WYTkO7qswBvp80ZE9w== X-Google-Smtp-Source: AMsMyM4lfwpOYmzvjyE5qd/xRccqM4+9nhG8g9eMBg9vtMrkoILmi7ik1MCnu54/dTokJkSS4cr3Lw== X-Received: by 2002:a17:902:ef93:b0:178:93cf:d267 with SMTP id iz19-20020a170902ef9300b0017893cfd267mr7757706plb.123.1664527395563; Fri, 30 Sep 2022 01:43:15 -0700 (PDT) Received: from [10.4.189.225] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id x10-20020a17090a2b0a00b001fd8316db51sm1170168pjc.7.2022.09.30.01.43.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:43:14 -0700 (PDT) Message-ID: <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com> Date: Fri, 30 Sep 2022 16:43:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: David Hildenbrand , akpm@linux-foundation.org, maobibo@loongson.cn, chenhuacai@loongson.cn, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com References: <20220929112318.32393-1-zhengqi.arch@bytedance.com> <20220929112318.32393-2-zhengqi.arch@bytedance.com> <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> From: Qi Zheng In-Reply-To: <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=dVJtM1Aj; spf=pass (imf28.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664527398; a=rsa-sha256; cv=none; b=qKVYtQScwTYCmyY9N1X8Q5IDLIFgIK3WAXjz+9OVEKuduc9q5KJArhQqzLNMCrMEnX8X6F 3Q6aiEczkflkG/Qo2lc/vrVeI5KuNRdgzHre5DXkfds3doM33Vl9ngbdFyA4o2oIRtSXy6 IjlUFA4msEEJ4ddHmaPI9DtRZqlbPvU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664527398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wJbYKGc9rVUqC784z1spy0gAYeIDAs7Zl7uyV0usPeU=; b=nAukU9dL4PeESLTVDcfKLq4CYTONhbHn4u6UXvUP9WeqdSEFihH77M9mft6pQ0fJrRDcKU Q5q1axgbMU85SnILZmDsIl8w5CQE45i38JOQpAK1fDX0dUsEBCvzlePOihpe0VqI8U/ZP/ CB7IKoHwIISbxuKqm8zlKTRZbyOe4Co= X-Stat-Signature: fqjyeznkrwspez31tnh971bsspke735d X-Rspamd-Queue-Id: DCB77C0011 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=dVJtM1Aj; spf=pass (imf28.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664527396-605119 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/30 16:30, David Hildenbrand wrote: > On 29.09.22 13:23, Qi Zheng wrote: >> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >> if PTE entry exists") said, we should update local TLB only on the >> second thread. So in the do_anonymous_page() here, we should use >> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >> > > Maybe mention here "This only affects performance, but not correctness." Oh, this is better. Hi Andrew, do I need to resend the v4? > > Acked-by: David Hildenbrand Thanks. > >> Signed-off-by: Qi Zheng >> Reviewed-by: Muchun Song >> --- >>   mm/memory.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 118e5f023597..9e11c783ba0e 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct >> vm_fault *vmf) >>       vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, >>               &vmf->ptl); >>       if (!pte_none(*vmf->pte)) { >> -        update_mmu_cache(vma, vmf->address, vmf->pte); >> +        update_mmu_tlb(vma, vmf->address, vmf->pte); >>           goto release; >>       } > -- Thanks, Qi