From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1E8C6FD18 for ; Wed, 29 Mar 2023 23:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F092F6B0078; Wed, 29 Mar 2023 19:36:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9176B007D; Wed, 29 Mar 2023 19:36:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA8226B007E; Wed, 29 Mar 2023 19:36:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA5C26B0078 for ; Wed, 29 Mar 2023 19:36:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A0512A0906 for ; Wed, 29 Mar 2023 23:36:30 +0000 (UTC) X-FDA: 80623547340.26.6CD91A9 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 36F42160008 for ; Wed, 29 Mar 2023 23:36:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=St8PzksH; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="J/CqCvxG"; spf=pass (imf08.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvGqTWIlGXqbOgey7jqT3j/jdkzCYRWku0GYSqEaXXs=; b=iMZx5VnbsukiL0G0drq+nb9rFcrSaP5RJKvi4d8O6mC4xuAI4XY8mNQIvFEx3QluIH+UnF qn249TZcbkQ/d14zJ1DvhRBnOP+GsDQJNFYdKZ6s5x7Z2RU8xQhG993xeIfpvlHt7gg+0p msMNUvZ7u6Rcn1md+3Fmq9ZnXgzCLQo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=St8PzksH; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b="J/CqCvxG"; spf=pass (imf08.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132988; a=rsa-sha256; cv=none; b=4qvIzYzTcHFAxLuJDEs74KYJR19W9H5SW4p3XQ52f82v39Rj593ajO2C9dmY0cbk6dX/W1 4rXyov1NMCLzy2i/xEiJ91YuU7mWgYm2II/D6gqNTvSvG/cJXz3uNio2qnN4V6nuCmuYBz fX6Z4Cxl29rjnMAaptgtSzCdfd9kyvI= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132987; x=1711668987; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=OTfJOB5+rMhAgZTM4ONfC4vlfxhMaFKo471fkAaO7qM=; b=St8PzksH1ZEMAMvMW1CvbZLbPTeJ+Sim9cGfHlRTUzL4Sit9XRhx9KDd lC6n3AFi1t0uTWOYMAjZ7C6kmS/Ce1il8eSV1n653bvQbSzvN4LQJwMUD UVZSeBormSGRSL9UhZcpxoIq8OBt/o3Fc8RIK848h54gRZuImoZ7FvDrH OfJet5UpcWdTHlz5IEOndDVWginMZgFvBOrEKwgIGgDQMOqOyqze7kOhO H1RY+LBEwKgHTPxxeDf9JfYYrMdSuSltY5TkhEXnSBlw5rvBynYQ9HFi1 MclBULdUgwVah693xdeE1tGqguh32Y/FDeZOVMahm62bod7ErB8wT+o62 g==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="331274066" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:36:25 +0800 IronPort-SDR: kjBA0PVrbswFwWqCbeaNJWZ0Fu6x8pzEKPSydhDPjSKpz34+aCinza8CAzKr/QPr0ZRK8/DrCx f7K0Z/+B1/NzBZh55l0lCD8OiLWIpQtTSxwLAnm0a3UZhO4Flx11mmgVSps0Mvr2d/yHcpkpTd Lak2mE0jH1tm0SatEGi6rmgu4LjAMf83Jz/myNdI8imAu/5RaSCnRCjWrcmRRsbJo2cPjRAjwL IHJgD11nDxMKJ+YN7QEwkrgBgIjNkKdtqvMtpdyUEp9ugAg8CuZuJ+6XJnKmqz2/WDdGMXcdjl EXo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:52:34 -0700 IronPort-SDR: SVaG7OosDeFX0c00xr+5PZTLnHAlGByq3QSN+sEBaCzOumHO3S2k7vz5sEuSdW4/FbqqxQ5KTV 19qu1F4Og7B4BI8RVPAD2cG2p2nHp13u3fZCbQDNxC+mL2oXaMV4+GDKn2MZAsOVgBgbbSp5WT A8ypXptERFS7KDSzrif5qvzRaKuFVBF9BRA5NZno030ED9zA5K+dFF/tHPn8Sm5gYCwO6uyYng FQYvUfM4/03Pt+WNmMiSiiDErzy0PxGTHG2GjZZiE3PYQgSChJCYWSC/dm95/gH3igziOb5SFx Auc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:36:26 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2xj5jpBz1RtW2 for ; Wed, 29 Mar 2023 16:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132985; x=1682724986; bh=OTfJOB5+rMhAgZTM4ONfC4vlfxhMaFKo471 fkAaO7qM=; b=J/CqCvxG/yXtDAZ6Z8y4FVSD6FKO6mFuHtMgkMtbXZxLWpJrTxX jzg15N0WLrB2LHfcj6uWsnuBSOqd2Si1ya5K/ZVO4lPVREU5qrfDG+ZAzfgRnoQN 6rTg8PEzntdT9htvQjOn9TvzpU6OYJJgLWQ/pOb8gEu1BYuaoKfWtpLNY23geZVK 6XrmgWL58pocgNIQNG19ktzATxEb3JKU9zAv3b/nXM1vRtO4uAFqDJjYfFQEyseM iU8x0uoQU56YGx7/+3oBbeIPU54IguMOX09Hyyg2ge7+zCFE4LD1HSan1+JAk979 zgqp41S3evORpTcblSQASnh1TLRx0LFMuaQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JitLSZDH_opo for ; Wed, 29 Mar 2023 16:36:25 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2xd5qYJz1RtVm; Wed, 29 Mar 2023 16:36:21 -0700 (PDT) Message-ID: <329c915b-b49d-491f-80ef-f4c9cdf80600@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:36:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 13/19] zram: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <339841b3b7ce6b2faf56bcaf9d92e298d878ef64.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <339841b3b7ce6b2faf56bcaf9d92e298d878ef64.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 36F42160008 X-Stat-Signature: aszhzua83cexghnjqpjozpz5tji6fk7d X-Rspam-User: X-HE-Tag: 1680132987-518324 X-HE-Meta: U2FsdGVkX1//EPENyHFENu9iedsYz+/8IYe+u5cltzgdeLhsb3mitg2ggxdIYNKhxQrXqP5J/lBxEAkEtiJuaCGxr6m+Ey8BTSOlXQO2uaB+xgGoihSghRnq+LYkX+fdUuDa+l2Gjb4CpTDDQekF7B7t9SeEdb01ztZkW1gulZI2dTi+MY196QyCogQnqiDPAzXvOh/n/9GsWu8GP9VdrA3M/rsW+IIrSTPFk+31NTN0iIEMrDiTaoQMDnL3FSIoyhvI6coILhl7OPrBqFKRhd/pUpjKdtdLSWWUIMX+9zTNXj4wm49Qxss6zgTKzLsV9NXtz9e/t1cnCeMpJnU2E0vo3PZom2InVPG4XbJTCzugowQ7bY043GhRolULZ5N7RCTLe49ifK/Ur9dc7zUKyKKB+gnWUcz5yYMyhIYjFbGzqU4vXCOq1bsWi/31aazd88HiNgVBBhPxENGCL8eX4PkoOwPem+whwrVm8R9r9jIZhSgd8v4ql7F07BXliVnffkKk/8UQ/AY5eYPg6Vu0gKGBgoeOQBI70sHr7Mg/aoJDx6kgVbE7Ee0tiYJlxntU57mtcrs2xl3MvYy+742Kh2eYosi5kerYl0tn4k3vnidVW6s+4ujsHPzdDvhVkaLAlqmO2Xm3XZ1XyeFRC2+z44MhQKdpTfgfwKC8xLbVCgeVwC1gbCj2fIYQepN/UR9CfZbFLJZM+o57NjmIf1VVhWr4T1JSX26sSiZ3xI1GIz1tHs0gRbfXzTFrLHxHTtWPclbM3jqhQi94PcJHESAaaNT2Knb0TBulrsMxLMOQkMdNTG0W4G7CNjludiFxbCyr5Z1MbFPeU1zEGoeejTT6JTGpP2GEn5vhhHlSejoe+R2sIEN2OH5kFNfaUpWm5acSyPip4wc7jMVwB2VQN0M4owCGPxnQnDk502Bw7IbTJxIdGJGJDh/iheSt7yW40P3LJdEqqTyn5CpSHadnU5u b01gg6UK V7uk8KdFE96K8Floujb0ry/7e3nrS288KDwr/uuuPWxc52uoZ8GtzhdF5+QyetBoC8EQ1QkpoTo6BaXVYqYL46x/7YHqxBvjoAJz2wHxNBFQe3QDLQRu1SKO3VAtzRkXqyWrsdm+p4jRcBg9fewbulTYEFWtKeIP2qJCGakTntfVO+Ja3JEhNP4MTvzFk/gsh7qA93/rCR00JMB9OWdf/eBX/VSyRR0mz1MZP+Vy6JoIfmVvfyV1WP8NGjS9kHDIrnliRzLbqk9dGnAkfT+zqIXkfBFm8tS139BvdRFX8yeLYD3gsEfzNXClep7O05sWvKrcV3ZNBG6nw4HlzRrjL7V15cNTHtK3VHoeBdk/Ro+5yrQm3c4dMMNzkGCfZ6rFrtuyGC4oLiu+T2lrVy5AALLL1llLjIEZ5RNaqpQuBEY/MuZKzkwaVV0mh2pz1NCNTrSC+pEJISM0ZcsLytlGgAhe8Xyl9pin0lQBdVjXLFizF6G6m/imCYtXTQ6ONR5OOXpk4RAS+swfWljsOKFiorh4IufkkNSdl8OStRFOM+2ruXfq3KcYO/3ocavNBJclpV9Shqi/kKbyvJhlLOT2gx6shHrx8dkYBYx/00pGRUEP4BdtSr5StpWQTgp5iHtbA3cRB8P//vHHVbH0D5v/418CTyL9+o25YIZcYoXllrrdUMBhyimMr16HM3GGOhY1m/VIHvJZ8Fe4BPCLZbYhHi8UTv15kaX3OjbUPurw6jzzEPyMCKdOfn+ZBQu++Am0uiU/HPaTjomYK8c0QWb5Kbu9sG/1jE1lqAsUtPTtC8truFzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The zram writeback code uses bio_add_page() to add a page to a newly > created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research