From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6200C04FFE for ; Sat, 11 May 2024 08:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E62566B016E; Sat, 11 May 2024 04:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13266B016F; Sat, 11 May 2024 04:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D003B6B0170; Sat, 11 May 2024 04:29:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B9A416B016E for ; Sat, 11 May 2024 04:29:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3E5DC80740 for ; Sat, 11 May 2024 08:29:12 +0000 (UTC) X-FDA: 82105440144.12.B8D6502 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf27.hostedemail.com (Postfix) with ESMTP id B202240005 for ; Sat, 11 May 2024 08:29:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715416150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Ozsi4m4/9FZU+9bsTosNQ1TJKZrwhq9f5tpJ7SyUSQ=; b=6hNzD6+/iX8CkRPlXeJoNPpm3ubwZWFp2dA8eUgHtDlx6bqUg3QydQnikKV1V7czkOfhqw tkboiCbOs5waBuZ1MO07+FN0R6Ueo73dFaTNsFEmhw0whNaI63UXQeRf5yFxHb8sysy8Sc RXlO7B0s3BNZrziWJlCfsBj+1dhr+jA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715416150; a=rsa-sha256; cv=none; b=4HehN2PQt0jcEaY+UFy/Wkj187mvhZl9r9crkCqz5Z7urMpMf0ZHwzygLQnbRQhCGC/va9 T/+Xx+YumaiaDI3ET83ceiY24p0ebeeqWmYAgGQZcHwJP0r5/3GRdSp8/hQD7pR5d1jPK3 1k1bEzuPzcCUiIlW5BgWbVmP6Fl0FGg= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4VbzNk6WdHz1ypGL; Sat, 11 May 2024 16:26:14 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 640C818005F; Sat, 11 May 2024 16:29:04 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 11 May 2024 16:29:03 +0800 Subject: Re: [PATCH v2 4/5] mm/memory-failure: move hwpoison_filter() higher up To: Jane Chu , , , , , References: <20240510062602.901510-1-jane.chu@oracle.com> <20240510062602.901510-5-jane.chu@oracle.com> From: Miaohe Lin Message-ID: <329c33ce-3fb8-436c-2ceb-e6520f0a973a@huawei.com> Date: Sat, 11 May 2024 16:29:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240510062602.901510-5-jane.chu@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B202240005 X-Stat-Signature: 4u3ak335chmdwjumxqx4zmd49suk75sp X-Rspam-User: X-HE-Tag: 1715416148-49303 X-HE-Meta: U2FsdGVkX1+1vSa7g2a1byhY6ypbcWIHhSRqHfsycWgGiYcviw+PSJoWrM582kmYMaiOAm/OWxFZ7LH6IyHqrL9m75HqT+hF8630xLTmgGQZAdtc1BO+jVPIj/jVOgEjKLxzCIDHZqW9ifP7nTGrGvaRW2OGl9ZBmrj9RTJncnwAPkCUZK1/JN27K7cOxYPdr+TgEHpXPCGHbzQV5n5EMnOVBfAMK6L5Ce1n4RdK9K7gkt1AXX1DmZEcRr5oHXPsofvmE2r3C9rakbt0zZ5Fd+MvvgvzFzaVgtmbIt+KxxjC3HHhJmFdX7fdY9BZQhWdIJqR7A0Y+a0IXhCXFI5Y30/s1BTJMPJ+D6AhOwff5/h5qyHOMSwDeUjhnBn/sStLhSelsWW5uhvjXOa0huct60nymCb0u8Sl+tuRwTbQkZ4ie62162A0uBH04wnIroLYhdvU9ACg9YzA05lhofMMZM2KpSNFdzIXjGd1IcMaIYnGpTlO/ln2g9fclRVSj3PXLTh+nWgDfsoFStlJBeLnrC3L5KKGVQOYrRNsI70cFZI955gqvKRxK3cF/XnaH1tt1OupaAhLA6+iEComQ/UCqL1FbbtOdZBVZyf6WSu839JQqKW6OBQQBlxzQYkAOtoVeP0mTD4mEcKrqER4cQ3/BJ/p3I1h5yHaTQCO5vI+7aea5mDT5FaQaonJexSu/vGE309dyPfJnjVPjtNzro9Lyj5jUHxn1k/8asd/D3uu3/Tfl9pPFPE4wIHPCy3dl5dGgqee6ELO9CbqSuaSn22FSvHMGvp6XwCU3xxpHBNVbPOpX+SuVKIRLQmWYb1g87HkqRbAK4i+0g9RA9xYT/fLDmITck8dX+XF+8Dt2gvSrsmuMQ+uob1zsL8EJFsYz5cOcT+fFj5//zQWhzjGjhrK8kIgyIQnwRwb98afh74EHrhaXQkQzrSSXGfLuApTxVp2F9QelXDofE7o5SOg+9I L7dEhedA niA/Dbqk0npBJfCvwS5xKa5yR658xHpG78ScEywfflwGt30+lsMPgxmWMIOg3gO7NLqGiIbxnrfVBPQROS6SLcF1Ll2aZMPXc7zj4l/BFbpwghtpiIox/fednrnbiBqxuFNiqKti6VmgDwY6KwtREl7c5qEktcjxdZBd48Ac6r6lfZn2aQbxcml//xHtq/juHirt4BY+SyuI3fWwsJjjXjHibw3tg5kVf+HFe4niXwQMKftDgsPsHV7j1SvWGkzQM3aYzutavLfGoxXVVSPOVLhy5MAQewgj/FCniuBCriyGh1oE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/10 14:26, Jane Chu wrote: > Move hwpoison_filter() higher up as there is no need to spend a lot > cycles only to find out later that the page is supposed to be skipped > for hwpoison handling. > > Signed-off-by: Jane Chu > --- > mm/memory-failure.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 62133c10fb51..2fa884d8b5a3 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2236,6 +2236,13 @@ int memory_failure(unsigned long pfn, int flags) > goto unlock_mutex; > } > > + if (hwpoison_filter(p)) { > + if (flags & MF_COUNT_INCREASED) > + put_page(p); > + res = -EOPNOTSUPP; > + goto unlock_mutex; > + } It might not be a good idea to do hwpoison_filter() here. We don't hold extra page refcnt yet, so the page state will be really unstable. Or am I miss something? Thanks. .