From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5246EC021B1 for ; Thu, 20 Feb 2025 11:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D84184401E1; Thu, 20 Feb 2025 06:48:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0D0B4401D7; Thu, 20 Feb 2025 06:48:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38C24401E1; Thu, 20 Feb 2025 06:48:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9370C4401D7 for ; Thu, 20 Feb 2025 06:48:49 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 98AA4161219 for ; Thu, 20 Feb 2025 11:48:32 +0000 (UTC) X-FDA: 83140150464.18.5A4F674 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 0979840015 for ; Thu, 20 Feb 2025 11:48:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e0mTXAt6; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740052110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Obz8DtIcfHG2stu+wzVROnq8qGgO18h8ATWsqNdxpCo=; b=Go/MKmXQHlTOdUN/QyHP7mP5oLCKLsZOYWGVRLbywf3ByHAGEOqNuEMgWGV2ASqPdhvjr7 P3ClinU5qFscqtAx5DD75hdzJUciEwzMOde1jlk5T7ldQzY1kG5JF1CzfHAGGvFYzo66jq sbqjLpUeaR2w9YrjTlj/ZfcgnUz6f9A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e0mTXAt6; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740052110; a=rsa-sha256; cv=none; b=frnvIMKvx1IpT5ckg6irxua+TKZ6Yxa5u1z0q5pFaI/3iXjsTPu+2pGUxUP+8jSMwTOlRi 8kaYKEZ1dY/ZWS0LRciuLD42y3WoNnJYIdnP+zT2b2P2fStETUkIJcVq5xw9nYSxl2rR2u xjG7d3ZK7VsPllGnbCWOxTpDBo9HBZQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740052109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Obz8DtIcfHG2stu+wzVROnq8qGgO18h8ATWsqNdxpCo=; b=e0mTXAt6vZqEL43KTifkIyA4nqCj9nsPntA5hwyfkXwUgpyBbpkEJCvcoyHsEp88aNov0U n+GrptzZnygNepoohnqP6A80Jb1+pnqilAMOqdvSHjtKthFB8pImqd9wZP5XRT3Ut51Tpf IK7Ui2mb6BQvpehfeBMMsGZ1VkaOnXA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-ttkvZHXgPvuPMMPHDBeGrg-1; Thu, 20 Feb 2025 06:48:28 -0500 X-MC-Unique: ttkvZHXgPvuPMMPHDBeGrg-1 X-Mimecast-MFC-AGG-ID: ttkvZHXgPvuPMMPHDBeGrg_1740052107 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43947979ce8so3811285e9.0 for ; Thu, 20 Feb 2025 03:48:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740052107; x=1740656907; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Obz8DtIcfHG2stu+wzVROnq8qGgO18h8ATWsqNdxpCo=; b=A6t2OW592z1jT7XCSc+bLmu/hb7ceOISLaX9kKmYIPpMOQjQh4cD8FT8HttsbhbOiZ 9NROALbqGS0YUv4FXZl4pFig3N7p7rLOpbptwuE0XGmXDQpgbUx0TRGWkiWWvQhSPfJM TDk/Qq/is1EAGc4Y+Cr9YLRBH+fCEshhSeNc04FZVeTgd5u5suj+CTP23tSJELMkUs3+ U32bTaA0bUZT/wLy+5wqsUH53v9OM1Jla8cZbSvXET/1aPUz/bx84hz/5cEiODvzrpsi YOUy75qnHzkRXfikIRAX75bx/90VkNuiNnMle0OoEEP7bQvxbbnM8aDRE0/cQq6J5lnz 2XNQ== X-Forwarded-Encrypted: i=1; AJvYcCWsDMwe1ls7ihStrBQu0JteWJCbwax+q1UiuN1pKIlbl4cw49E00QnF1tdRmtCXswguffEQ5NmkUA==@kvack.org X-Gm-Message-State: AOJu0YyRo3GXf6TEujVO+o+lVaHMiUAIw1NbQ5HHbDfmOASsKTzmNjb0 nOlDV3fpyJAtR3H129tWD1ZVMQg/u7z/co6+bRmVW0RHNW6Q0jKWTBBLZ9JKkVK0/Xzhl6sd/It jARco8DbLmOmydPy7DW/Gqf6APstXPPJgp1HS+gcTSeEXM5He X-Gm-Gg: ASbGncvm+yvwG345ZhuUFyfxK/FX6pNc3NQaGIBTB65FWhOxgK0Vm6BvekvMmhtevnL xMtXqlIsF21XujJJJ1Y7MINaKS8zoQUVpEXnIFkkPw2vjhMAzrwm3CqOTBj4nRIUM55EQ0U4+u0 GKM6Es/FKInN5o+dSgeiwGruL3b79VIyBpn2WmjvgFVIT+NgWXoa+aF/72KUVIFIy1DvwyWRBG4 WCI7y2q1gWiEoKsoGaUNxkwQXGmA/FLcLMr1bn8NOk+KvGdJIDk0vPwvXvFWRY9azv7eCDfGlfm o2AR5m+miViL0xgL8X/2hJOdevViFmFAnVsebS3qzVVtWC4nvhHzKHSwYGN1ny68ZX6/LP3h8jv WSgPFdtF9U/4/0V6kTkMwP4DnP37uEg== X-Received: by 2002:a05:600c:35cc:b0:439:7dfe:f12 with SMTP id 5b1f17b1804b1-439a4a69f61mr20900795e9.5.1740052106602; Thu, 20 Feb 2025 03:48:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGHRP/LJurAcFp4FFSGEGeS0FEbAij0sG7TYqSU3OWA5L0JozvOhO++MZ4y3EHmIL6y5HDKDg== X-Received: by 2002:a05:600c:35cc:b0:439:7dfe:f12 with SMTP id 5b1f17b1804b1-439a4a69f61mr20900275e9.5.1740052105990; Thu, 20 Feb 2025 03:48:25 -0800 (PST) Received: from ?IPV6:2003:cb:c706:2000:e44c:bc46:d8d3:be5? (p200300cbc7062000e44cbc46d8d30be5.dip0.t-ipconnect.de. [2003:cb:c706:2000:e44c:bc46:d8d3:be5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f25915146sm20705835f8f.56.2025.02.20.03.48.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 03:48:24 -0800 (PST) Message-ID: <329060a2-8871-4adf-9a45-f0afaedc8848@redhat.com> Date: Thu, 20 Feb 2025 12:48:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/migrate_device: Do not access pgmap for non zone device pages To: Balbir Singh , akpm@linux-foundation.org, linux-mm@kvack.org Cc: apopple@nvidia.com, Jason Gunthorpe , Dan Williams References: <20250219231337.364133-1-balbirs@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250219231337.364133-1-balbirs@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4qwukJeT6sN7QhcHXmW2tg54SFeo_xD5tkfKjnlH8X0_1740052107 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0979840015 X-Stat-Signature: jjmg5mtc86nnkj6oxrtkk3fshgc7seha X-Rspam-User: X-HE-Tag: 1740052109-216543 X-HE-Meta: U2FsdGVkX19yNI7mmVo40ZtQ9JzUm5kxiy1cVw6tfeTfMTTbGo1q6O2kO87jNYvTo6bn68BoUpE8RLkSO4eFA0VIb5tpfa+IGTf2nst2ifN8TksLnB4QcGbyosxShh/b/n9JOXpkWSPN/iWJT4XG4bFZNXg7G0zOW9/+K3pn/iU6uh+HAYsn7kpzfGcxQzUH/ngGjh6IaJl/K8WxUO/aHzmj8LeyfmwgHsqv7G5U71XoSLP7ruPlpnW+hzByeayDMgHbKn6bIA4JrsZyaK0GkwNvjqR0a4OW0u1266K8mgN2enLkDY6FcJBK2r5imyqBEXrqalFpCT6VnhjcRywiYFHrgddvNbnrUz3aqQ1h6qLAqM4KP4o0lTpKJlmPiagt66JDSlbTd0/fR0XK9XhILrVhGBbPWnm0vcPWkZ2vKTYmIeO5iHk7ejcMJ+AIEq86A/eS05Kefm9Dk0vZ6/fibKDFTIG903OVWBo+UKejfi5NfOVz/Y1ek6lHXLpoBoG9wi5DyHgZ7U4FI+G5+lxwP4rJwB1bNv0lV7NXjpSKaOuWtr6S/dUnjtal/y1zTOTUzXkRhju1wnyHNP7bj3PZ6WXkRO1B72hjZFRzxCws3WTklvzzKpNmH8L/4hVCgEP3BWYRQMEXVql2ZzxBAIa63vHvbnlpHoJnWc6q5svGTnN2uo76ZVgIhHsoMaX4OnPm6OVf6kJnGf/5h8k7YqaU9GJ7vV2lrasD0KgxBkg977/kkcgn9ZukN5uTpy7QM8tZQJV3q0BSUHTV3JtpW3g1QKILEjfWuv4KbZj0I7F79LxmD337/GfjZapo/Ynf3KB5Anmv4nwyVBlUbvGviYGqRicrRsOIbjSB9Y650qmk7Q2a6+HNOJsXFp/0mMl7nmVS1hxTpf+zNa4/wX/Eg5g0L/cdQnz3V7xxYiR30KT/ic/etUjZ5XwTPd3ypQZ/LHk2encFKQVHQOQIFc7FDlv FMSx6T8f fw9YpycmZsvHVzNWE9Fdr92/LBG0G2xD9wzTyC2H3UzBwjv7XLaYDmPbw99ftRf7vx9J2PdUFp0Na2no3ETbpPbqxb9FXsQJcKf7kC1wcRXm9W6Cjrt+Qgb21LX6wHxYNfo0Lg+PMWv6/cfz2vUEZlwF2+G1mvYHK/9FoHq15snIpUzJHjzPKPfRirtkkfF/5a+KyWVbHsDsAhvg0NLZhQXFzPQx31CPwmTJKQRa/z/6rkq5FVS0bQ0urRoRyza/BSxXdUIBcE7aiwNMxG7yCquI1srOqaCffm6Rv7tzH0SiQHtIK0Twt/QsC2yJmAB9LUOPVpfFfLbOi9jnx5f/qpecRLq+dtLbh7Z+tslsG52Em+zvtFOkorlR/xH+gbSmvQE8RdGz4PKE8x5jXT75hB67lfT+zBpdfzQNm7yB9RGPr61NhqoRO58LD0+doDpgHn3MMo/DX0sHzB18sPbTLFsgzX/q9gK7uq7op898J0H+4z1KO/4m9RbsvJJePN+/1i76ftUTc3XURZ/uCxHOeFPD6OYjHRXphmpO83lHDbfWlCFzTR2GP++ujw04LNV47MpGb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.02.25 00:13, Balbir Singh wrote: > page_pgmap() is referenced before checking if the page is a zone > device page and this triggers the warning in page_pgmap(). Refactor > the code to use the helper function after relevant checks. > > Cc: Alistair Popple > Cc: Jason Gunthorpe > Cc: David Hildenbrand > Cc: Dan Williams > > Signed-off-by: Balbir Singh > --- > > Fixes: 7f1cfd71153b ("mm: allow compound zone device pages") on > mm-unstable Is there actually something broken? At least for now, reading folio->pgmap should just work, although it might be garbage. > > mm/migrate_device.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 6771893d4601..e0bf771edb6f 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -153,14 +153,17 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > goto next; > } > page = vm_normal_page(migrate->vma, addr, pte); > - pgmap = page_pgmap(page); > if (page && !is_zone_device_page(page) && > !(migrate->flags & MIGRATE_VMA_SELECT_SYSTEM)) > goto next; > - else if (page && is_device_coherent_page(page) && > - (!(migrate->flags & MIGRATE_VMA_SELECT_DEVICE_COHERENT) || > - pgmap->owner != migrate->pgmap_owner)) > - goto next; > + else if (page && is_device_coherent_page(page)) { > + pgmap = page_pgmap(page); > + > + if (!(migrate->flags & > + MIGRATE_VMA_SELECT_DEVICE_COHERENT) || > + pgmap->owner != migrate->pgmap_owner) > + goto next; > + } Coding style wants you to use if () { } else if { } Not if () else if { } Something simpler might be page_pgmap(page)->owner != migrate->pgmap_owner > mpfn = migrate_pfn(pfn) | MIGRATE_PFN_MIGRATE; > mpfn |= pte_write(pte) ? MIGRATE_PFN_WRITE : 0; > } -- Cheers, David / dhildenb