From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DDEEB64DC for ; Tue, 27 Jun 2023 16:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270E98D0002; Tue, 27 Jun 2023 12:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F9F38D0001; Tue, 27 Jun 2023 12:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 074C58D0002; Tue, 27 Jun 2023 12:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E8B7E8D0001 for ; Tue, 27 Jun 2023 12:56:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5A55A1C899B for ; Tue, 27 Jun 2023 16:56:06 +0000 (UTC) X-FDA: 80949130332.07.4B28ADF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 8013A1C0005 for ; Tue, 27 Jun 2023 16:56:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bvgpAIwL; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687884963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zxcgu3g1LzEJDjlBVeiHHZ7/xQjIq5XoswU3EPAmCdo=; b=Wnml8lxN9xO+cKkq2r0SKsj4I1gMOyVx+0wYkUaWP1UonR848BRQa2oclrWF2i6C8z4K/p CBTpxVcaYgYlgEQYrgdiCZJl4Pfo2EjkC2BTxEFUlATmJ4FC446kWOjq2uqfU5LzzFlMWC iH5SqOHb2BzOj5krjsHTBj7rehBgXv4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bvgpAIwL; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687884963; a=rsa-sha256; cv=none; b=uE5hhTrw4QbyKjaMpUUcX6mtz2i3MdxaWZJxABsY+TJuuQWeNp4TRtkEwKr1sgr4CNQ7EI fV/1BWs6f55ol/3X4YMkIKhVEc2/GWpUdrkxJ3CS/2rJLVuuffN4dC4ZjpC78sceM6zpg2 y/gWFGe0s3MtTSj+zyijYKUEZM4y2G8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687884962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zxcgu3g1LzEJDjlBVeiHHZ7/xQjIq5XoswU3EPAmCdo=; b=bvgpAIwLZofT4FckMLSjuCRlGFItFhAJgGESY4GT3RN3T4xm7T7JRBZ65h8u3ri2tTAqLd 8NUQEHK/abKvMjF8lSGszh7PFxUvTRzqT1xLRkF4oWHiS0V3EkmgAJOKweV+x9i4H/ReT7 NTiQ0SEsfFujgvRradLSdmLVfX8qASo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-361-vzW8LbBLPjKGUB8TJ3-Ntg-1; Tue, 27 Jun 2023 12:55:56 -0400 X-MC-Unique: vzW8LbBLPjKGUB8TJ3-Ntg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70F083C14AA5; Tue, 27 Jun 2023 16:55:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD05FF5CC7; Tue, 27 Jun 2023 16:55:49 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> References: <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> To: Tariq Toukan Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3280196.1687884949.1@warthog.procyon.org.uk> Date: Tue, 27 Jun 2023 17:55:49 +0100 Message-ID: <3280197.1687884949@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Queue-Id: 8013A1C0005 X-Rspam-User: X-Stat-Signature: i7eheme9dex1ikug7717hex1escb9etw X-Rspamd-Server: rspam01 X-HE-Tag: 1687884963-458675 X-HE-Meta: U2FsdGVkX19ffNV/WBUsoVRXQR1nTtyU3uFOFLgfXdLNVnMroP8EgaN/nFZ0xXEgo/ovLHS5tuPn8iU+C+rqu4WowhAmd5utpb4OCU7589VJEQh/Vup5MsjAzHspa/B7t7KA+40oZUeSf+HPqkBID5jQwjhrGRpb0RgCxBdXS9Eo0xlvfjl7zKJ+z1p0V7bXhwO4p9dthE9iX3uWYC784ILD1wYtq6bLvThByVLeHuPJS5zWKq1ZlLFzXbSUwyZzwGt04GS5mAG2EB6Mjn5RHEahOhf05huUgAJA3XuK2UOB6qGMBtZtbBmobJPiV8VKhMtL5JYzvQSRs4IcrMkvRWojdNeOKVXucZgD/jSUKwcwdezncQ9TX+AqkChKjohV24Ab7tRtXWZ4K639ZenZKDf6GS/iathHB8eqJpOKhjpJ0oVProb2hg87V+Ne6ILHETYe6aHgI7/cgc5CQ9q5MSc7hfg+6BlAjEPbLyiyeQyJBszDMjsE6ukwhLpUjUIKTxF8Pa7fUSHSXy3xJmpq6F3zdmi+ADNiqZRfeUsIvzlK79/SFBeduVnVnzmbDqglC6Y9AViRRqswoae7AiImJcDczkJsKqhuoGd3ie64udhS6N0KZSwp8ppmff3Uu0LEWfCd9goxrr5q7KW8lcNgyANEPFRPC7KB+xF0uxjy+dO7yeYFOdsw13X2WCpirYC4JG+WHpYLEHupZo7T4kTDoC4AEDY02r/fPeIeQAYUR25jcWyXjb3kcMZj7h/yO+o6hbT6uz+moL0npOliNpRWM4KyHC0x6Sxy+BmAFvXQ92zlSku1X2hNVB1AjDBMlk8IaYfP3nTY9Lveg0DTblYyYsMRewotJGQajrsTNV9Bi7b513hjuhmNpHkPil5+VgqRG4Ys21lxbgmgVNU1s/dxj4do4EyjaTt7xZLpaMDtSa6XlRr0nAyMp64T+TaGji2X0r1Rzoi6KO4GA/8RN0C KOLCaPRY dvnR2ZeNHJYeaeivdfWXTD/2EWjvfDXFxmoDHPcLHxAT8vUtXOwrBNtos7Z1fM63IJMyIFqbPmdpaYeFhEnETI2v6HSrIVrJrPFgAqHbjwJjSrQyVmNn4rcSmTYkYcWQKK/6pSuGUttnm2/8xZfPg4KrlwpNISUArZAWiWhe6Q7yeh2qYWdxIPvLWVEuSHrH9TGUr8nG8sY07ln8VaK3VfzhDrJyFaaUHK2mqddfA57kyfiYve4k0nvEp/+I+TilueyN8fgRCS99vG8Z+BCFVp1mU6G8GSVW+cHkP7lw3SyS1Lc8bIB6AS0TFbDCryzCqknWX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Tariq Toukan wrote: > WARNING: CPU: 2 PID: 93427 at net/core/skbuff.c:7013 Is that this line for you: } else if (WARN_ON_ONCE(!sendpage_ok(page))) { If so, it's not slab data, but we've got a page with a 0 refcount from somewhere. David