From: Luiz Capitulino <luizcap@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
lorenzo.stoakes@oracle.com
Subject: [PATCH 11/11] mm/thp: x86: cleanup PSE feature bit usage
Date: Mon, 15 Dec 2025 16:16:53 -0500 [thread overview]
Message-ID: <327e07e0ff3579857b11d14c837ac6231cd113b4.1765833318.git.luizcap@redhat.com> (raw)
In-Reply-To: <cover.1765833318.git.luizcap@redhat.com>
Historically, THP support on x86 checked the PSE feature bit to enable
THP. On 64-bit, this check is redundant since PSE is always enabled by
default for compatibility. On 32-bit, PSE can enable 2 MiB or 4 MiB
page sizes so it must be checked. To clean this up, this commit:
1. Drops arch_has_pmd_leaves() from common x86 code. For 64-bit,
we assume PMD-sized pages are always supported
2. Checks for PSE only on 32-bit by implementing arch_has_pmd_leaves()
Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
arch/x86/include/asm/pgtable.h | 6 ------
arch/x86/include/asm/pgtable_32.h | 6 ++++++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
index 08d109280e36..55b88de5178f 100644
--- a/arch/x86/include/asm/pgtable.h
+++ b/arch/x86/include/asm/pgtable.h
@@ -313,12 +313,6 @@ static inline int pud_trans_huge(pud_t pud)
}
#endif
-#define arch_has_pmd_leaves arch_has_pmd_leaves
-static inline int arch_has_pmd_leaves(void)
-{
- return boot_cpu_has(X86_FEATURE_PSE);
-}
-
#ifdef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP
static inline bool pmd_special(pmd_t pmd)
{
diff --git a/arch/x86/include/asm/pgtable_32.h b/arch/x86/include/asm/pgtable_32.h
index b612cc57a4d3..3bd51cfa431e 100644
--- a/arch/x86/include/asm/pgtable_32.h
+++ b/arch/x86/include/asm/pgtable_32.h
@@ -45,6 +45,12 @@ do { \
flush_tlb_one_kernel((vaddr)); \
} while (0)
+#define arch_has_pmd_leaves arch_has_pmd_leaves
+static inline int arch_has_pmd_leaves(void)
+{
+ return boot_cpu_has(X86_FEATURE_PSE);
+}
+
#endif /* !__ASSEMBLER__ */
/*
--
2.52.0
prev parent reply other threads:[~2025-12-15 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 21:16 [PATCH 00/11] mm: thp: always enable mTHP support Luiz Capitulino
2025-12-15 21:16 ` [PATCH 01/11] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2025-12-16 7:40 ` Baolin Wang
2025-12-15 21:16 ` [PATCH 02/11] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 03/11] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 04/11] drivers: i915 selftest: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 05/11] drivers: nvdimm: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 06/11] mm: debug_vm_pgtable: " Luiz Capitulino
2025-12-15 21:16 ` [PATCH 07/11] mm: shmem: " Luiz Capitulino
2025-12-16 7:52 ` Baolin Wang
2025-12-16 13:47 ` Luiz Capitulino
2025-12-17 2:03 ` Baolin Wang
2025-12-17 18:50 ` Luiz Capitulino
2025-12-15 21:16 ` [PATCH 08/11] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 09/11] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2025-12-15 21:16 ` [PATCH 10/11] mm/thp: always enable mTHP support Luiz Capitulino
2025-12-15 21:16 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=327e07e0ff3579857b11d14c837ac6231cd113b4.1765833318.git.luizcap@redhat.com \
--to=luizcap@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox