From: David Hildenbrand <david@redhat.com>
To: Daniel Gomez <da.gomez@samsung.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, hughd@google.com
Cc: willy@infradead.org, wangkefeng.wang@huawei.com,
21cnbao@gmail.com, ryan.roberts@arm.com, ioworker0@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Support large folios for tmpfs
Date: Fri, 15 Nov 2024 14:35:24 +0100 [thread overview]
Message-ID: <3269e0a6-29a4-478b-842a-629efc8d5d59@redhat.com> (raw)
In-Reply-To: <D5MS4CMG4N8F.1M5WPZ1T5UT0I@samsung.com>
On 15.11.24 14:16, Daniel Gomez wrote:
> On Tue Nov 12, 2024 at 8:45 AM CET, Baolin Wang wrote:
>> Traditionally, tmpfs only supported PMD-sized huge folios. However nowadays
>
> Nitpick:
> We are mixing here folios/page, PMD-size huge. For anyone not aware of
> Memory Folios conversion in the kernel I think this makes it confusing.
> Tmpfs has never supported folios so, this is not true. Can we rephrase
> it?
We had the exact same discussion when we added mTHP support to anonymous
memory.
I suggest you read:
https://lkml.kernel.org/r/65dbdf2a-9281-a3c3-b7e3-a79c5b60b357@redhat.com
Folios are an implementation detail on how we manage metadata. Nobody in
user space should even have to be aware of how we manage metadata for
larger chunks of memory ("huge pages") in the kernel.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-11-15 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 7:45 Baolin Wang
2024-11-12 7:45 ` [PATCH v2 1/5] mm: factor out the order calculation into a new helper Baolin Wang
[not found] ` <CGME20241115135428eucas1p2b266175fadfb08cad9264c89fd395407@eucas1p2.samsung.com>
2024-11-15 13:54 ` Daniel Gomez
2024-11-12 7:45 ` [PATCH v2 2/5] mm: shmem: change shmem_huge_global_enabled() to return huge order bitmap Baolin Wang
2024-11-12 16:03 ` David Hildenbrand
2024-11-12 7:45 ` [PATCH v2 3/5] mm: shmem: add large folio support for tmpfs Baolin Wang
2024-11-12 16:19 ` David Hildenbrand
2024-11-12 16:21 ` David Hildenbrand
2024-11-13 3:07 ` Baolin Wang
2024-11-15 13:48 ` David Hildenbrand
2024-11-13 6:53 ` [PATCH] mm: shmem: add large folio support for tmpfs fix Baolin Wang
2024-11-12 7:45 ` [PATCH v2 4/5] mm: shmem: add a kernel command line to change the default huge policy for tmpfs Baolin Wang
[not found] ` <CGME20241115140254eucas1p2e77d484813d39b8e6c8c0dbd6046f3c4@eucas1p2.samsung.com>
2024-11-15 14:02 ` Daniel Gomez
2024-11-15 14:54 ` David Hildenbrand
2024-11-16 3:00 ` Baolin Wang
2024-11-12 7:45 ` [PATCH v2 5/5] docs: tmpfs: update the huge folios policy for tmpfs and shmem Baolin Wang
2024-11-13 6:57 ` [PATCH] docs: tmpfs: update the huge folios policy for tmpfs and shmem fix Baolin Wang
2024-11-20 21:35 ` Barry Song
2024-11-22 11:12 ` David Hildenbrand
[not found] ` <CGME20241115131634eucas1p2db22b75fcc768a4bb6aa47ee180110cc@eucas1p2.samsung.com>
2024-11-15 13:16 ` [PATCH v2 0/5] Support large folios for tmpfs Daniel Gomez
2024-11-15 13:35 ` David Hildenbrand [this message]
2024-11-15 15:35 ` Daniel Gomez
2024-11-15 15:44 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3269e0a6-29a4-478b-842a-629efc8d5d59@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=da.gomez@samsung.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox