From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE2AE7AD7A for ; Tue, 3 Oct 2023 16:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DC5F6B0252; Tue, 3 Oct 2023 12:58:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08D766B0253; Tue, 3 Oct 2023 12:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E70306B0254; Tue, 3 Oct 2023 12:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D488A6B0252 for ; Tue, 3 Oct 2023 12:58:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AB3251603E4 for ; Tue, 3 Oct 2023 16:58:02 +0000 (UTC) X-FDA: 81304757604.11.676CE60 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf21.hostedemail.com (Postfix) with ESMTP id 772501C0017 for ; Tue, 3 Oct 2023 16:58:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=LOvNGpJO; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=B+M5wR9X; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696352280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2FQ7Cu/afkL6EriG0Uiq965GFYkq5JFljrsPV+qIn8=; b=jdKXJCWLJFySEQksDwulxfRt9K5CvZp5PkOvLsJdBGJY7z6JF0CX+iPBWxYlpK8mOCBPpg 1BFvVeWloxETu3zI5Q5SxvON/J0ZXUUjUDV32zEsU4O8bMZpj6vmBJXP3IWuIka2sf8PzT eqQclHrLvUQVNZjQtr+z711j/b2lKfw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696352280; a=rsa-sha256; cv=none; b=HNRobvi14fuC68ASjielY4wX10BzL4OBvekEtIAj5eUbuRG0bMzV5BO+zyRdwd2aPuMO86 WrLzsGigT4TVKMxUoOh27ipOQUaDEZ31zGXO0NXS7GFgMkpRob2YhwMyIcV2KPgK5VC8e6 5WtsaIGuIqH5R440KQBxej2yv8+HwBc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=LOvNGpJO; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=B+M5wR9X; spf=pass (imf21.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.20 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 702E13200B0B; Tue, 3 Oct 2023 12:57:58 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 03 Oct 2023 12:57:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1696352277; x=1696438677; bh=V2 FQ7Cu/afkL6EriG0Uiq965GFYkq5JFljrsPV+qIn8=; b=LOvNGpJORUwJ+gnnJ3 SQOqcVf8X1032fc2EgB7r2YcuiMQitNDg/0tJ9vb9FZBtuovzUkmIig9fTzQQnLH EwmFn7MTsgDpooNLbNlUB6b5xLgQ6eS0/VJezsWQiB0uhMIk0lWGP+5d0R4dDQRF GC2zvsBPjKmHAwz1nruBxHRb6wUETQXUUPEujhrRIc3HP19+ApeS0XRxnwgpWUBK 8Htx4DX0lq3xo8oSakrxxbsNXOAhQDyvoKMXt4F1hDOrnXLPakmDqkLqzvj2eZGd cBW3dtKGFlpuvZTf15nffXAIr2Jk8t/tdihnr0PBRC/ZHhGy8J83kyFNK99ZFczu 8dtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696352277; x=1696438677; bh=V2FQ7Cu/afkL6 EriG0Uiq965GFYkq5JFljrsPV+qIn8=; b=B+M5wR9XKOQzUfvOYQDdsd7u+Lsm1 qcE6NqAKlY3Snkcg6MI7WrfVsZ4ME+H2OA49Jl6Bjt338iBImrBYA/6RppClxSbn 3RPGjXc2UC2Gisegg27LE4R+wTF/SjZPi0/943A+0q7FwB1GQw9Ab/pMf/cJ40wY Icpby1udhs/unsXxL2fR1iCc+z03Vdyet82SpMC0H9XLYfZ5+x3Ec1TITQR1YSCW 8RWIn3vxuYC8GYtaQaV85+bJiqNYapiaYGGx7l+lvZdFNBF41H5gfYXfhOjrbtZV VRzdhzbR8fWw0vvF2ktA9kFj5LgTXVKyJ+PdTouubvl7CMmwQ3djPEi9w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfeejgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B5DCCB60089; Tue, 3 Oct 2023 12:57:57 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d MIME-Version: 1.0 Message-Id: <325de88f-1237-4910-aa2a-97707bedae26@app.fastmail.com> In-Reply-To: <20231003094912.08cf57998135446ef475dd19@linux-foundation.org> References: <20231003144857.752952-1-gregory.price@memverge.com> <20231003094912.08cf57998135446ef475dd19@linux-foundation.org> Date: Tue, 03 Oct 2023 18:57:37 +0200 From: "Arnd Bergmann" To: "Andrew Morton" , "Gregory Price" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Gregory Price" Subject: Re: [PATCH] mm/migrate: fix do_pages_move for compat pointers Content-Type: text/plain X-Rspamd-Queue-Id: 772501C0017 X-Rspam-User: X-Stat-Signature: d8tofw376b37j95bmp13odxyukz8bd6e X-Rspamd-Server: rspam03 X-HE-Tag: 1696352280-166077 X-HE-Meta: U2FsdGVkX1/UwzxMtc6G8rRCxijKhTTx7nMcRlBxZl2vS7pjO++4/i9jITblwM0zDy+hasdqY+pGXijJNnxllCePMlUxH0sJvFCSsaCDb5l3KIlYN1fUOidgf31Eqm0GlkQ5Uu2VxADU3OEv8pF73Aqe3b+7fx7/AasSUbIMocIGRQCn1U76SU1EyFsBuATHvyXGuyxfqWa107ON8w1Sl1BYBkeIIOyG09x+ginUcixtfUn3vXOw3w8JjOYWbXhs6XdftewPS0pp03SAgeWo7kWcC02zo4WqoDBz35ylSnp/AAmylypOHjbaVC+XcJuaqre2EyDxh9M8tF92I9vqkjCSjiNwQiSvna2qWSFP9ey+EZLNCfl9WMe3FV1mcEvkUxGrLf+bdD7F8Pac7tBEOI0FDOsY04jRfarPucgAmYPkKaUrJCz6qtx/8iPJmaFFIqoCvEs3Nh2zPtGAFmjno3oXHMZLw+/5H7tso4b15uC8ag5KG34E23EP3JD4VRVSF4XvreX1tTTw72+FREF1gHcqAC68IibaTw8/bQ/NEmtt/Bwg17b7Bqn7YpbvjWASD9FUZgjIllcWCGzOp5ct4dM4cLBS3MNmqA5U2KQX42GwV9GOXTrTxqLtsckZt/fcH3wHopsnXpOHD9DgS4OszlKiMDI396Z2tg+6Agm1juv30VLlbVMKZmsjaPS1D1auZD1srUsaLDNmY2cFpWbBsOIVYDl5mfYqKP1+5L3a8jXdb6+0b+lwtZPAZ09VtyDneiW3djXorM3bvcLma3MpVetXP4pV9K4ntytvAy6AaYihCZxQ2pbAJeF5KZA0VQu/AN+trNu2K7unIZZhbHZWxDUhJaEE6CGgzCfCsXqa4OY67Sm0khkOownNiGbN2qFCljWtV4WZiw++AGE8N6LuZOItAXyYQwVGvUf1krehzz+cdqb2fZuXWaSm5eQptQAB3SmxCJrXHUYrRBcvprQ MdwsNvIG mjYcTYJnQ7ATWEdK6tuBM2kOTMXfO54G7Fbi1PemFX+EMZkUQlysg+2SxceO2NWMuQgORntE7LWy0VztBCuoAFTpzuV+ICazy3vON5rLFCAnn62xBXUOLoJuyZL8w+82uyBvQTUX1xKIN6B1DWstSZrogM1zab6aKLq4Dx3dJ3mDYIAQ3oUtlGw8eaJn/rcAHQCakH6kvm0TTdzL4CY2QweZC/vK2fo+mSbn/yp6D0Lt/IZtdx8NOhM2+StownsYHZJdaoWp+xee4O4Z6VqWQM2hqmXVtntyetN+S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 3, 2023, at 18:49, Andrew Morton wrote: > On Tue, 3 Oct 2023 10:48:56 -0400 Gregory Price > wrote: > >> do_pages_move does not handle compat pointers for the page list. >> correctly. Add in_compat_syscall check and appropriate get_user >> fetch when iterating the page list. > > What are the userspace visible effects of this change? It makes the syscall in compat mode (32-bit userspace, 64-bit kernel) work the same way as the native 32-bit syscall again, restoring the behavior before my broken commit 5b1b561ba73c ("mm: simplify compat_sys_move_pages"). Arnd