From: Dave McCracken <dmccr@us.ibm.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: RE: [PATCH 1/1] Implement shared page tables
Date: Fri, 02 Sep 2005 11:40:12 -0500 [thread overview]
Message-ID: <3251CEDFF07A229DBFB81CE0@[10.1.1.4]> (raw)
In-Reply-To: <200509020158.j821wtg00465@unix-os.sc.intel.com>
--On Thursday, September 01, 2005 18:58:23 -0700 "Chen, Kenneth W"
<kenneth.w.chen@intel.com> wrote:
>> + prio_tree_iter_init(&iter, &mapping->i_mmap,
>> + vma->vm_start, vma->vm_end);
>
>
> I think this is a bug. The radix priority tree for address_space->
> i_mmap is keyed on vma->vm_pgoff. Your patch uses the vma virtual
> address to find a shareable range, Which will always fail a match
> even though there is one.
>
> Do you really have to iterate through all the vma? Can't you just break
> out of the while loop on first successful match and populating the pmd?
> I would think you will find them to be the same pte page. Or did I miss
> some thing?
Man, I spaced that whole search code. I was sure I'd tested to make sure
it was finding matches. I'll fix all that up in my next release.
Dave McCracken
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-09-02 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 22:13 Dave McCracken
2005-08-31 11:44 ` Hugh Dickins
2005-08-31 11:51 ` Arjan van de Ven
2005-08-31 13:42 ` Hugh Dickins
2005-08-31 14:31 ` Martin J. Bligh
2005-08-31 14:41 ` Arjan van de Ven
2005-08-31 15:06 ` Hugh Dickins
2005-08-31 15:39 ` Martin J. Bligh
2005-08-31 16:40 ` Dave McCracken
2005-09-02 1:58 ` Chen, Kenneth W
2005-09-02 16:40 ` Dave McCracken [this message]
2005-09-02 4:26 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='3251CEDFF07A229DBFB81CE0@[10.1.1.4]' \
--to=dmccr@us.ibm.com \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox