From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1C9C7EE2C for ; Wed, 24 May 2023 15:04:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72D5D900004; Wed, 24 May 2023 11:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DD81900002; Wed, 24 May 2023 11:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5811C900004; Wed, 24 May 2023 11:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4513F900002 for ; Wed, 24 May 2023 11:04:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D612C40A04 for ; Wed, 24 May 2023 15:04:22 +0000 (UTC) X-FDA: 80825469564.23.411CAA2 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 5B595401E5 for ; Wed, 24 May 2023 15:02:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=j8dtYIjP; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.52 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684940533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rwf57azNybT9v+Lg2CMN2sb9fLVIIGUOGeYghvdjLPg=; b=vaOXhQHkTjmdpcQgJY8Jmc0ODFt81ajY0IhsvlKKPOcZEScChQQgw/pgJRb2jkHGi4tWSZ VKEpzmbdliO8uWBuKYmrZAnLSa9tS3vlTGR9DnrToK2+VBlDoXY9TC5WJi+9cp/eB/O3D0 P0w9Lcx7CpBLhLxkD48ZdKkF5/F+t9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684940533; a=rsa-sha256; cv=none; b=P+5K70/vkbeKp7hbE/bOqFnRmrhA1I+okkIMfTVVDs6t2sWNw4e/kEbbo5MdeRICegRJlz eY5tQOpEjVm1JPf1WmAeLF0qbjkrHJ2vP84V7TWQA4kOl3i22Ftg+vdTSt0m1YDMSLO1Tr 9Jwyo95TyCdQTq+BtP3iIq/1AQV3G00= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=j8dtYIjP; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.52 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-760dff4b701so8094739f.0 for ; Wed, 24 May 2023 08:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1684940531; x=1687532531; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rwf57azNybT9v+Lg2CMN2sb9fLVIIGUOGeYghvdjLPg=; b=j8dtYIjP94479te1+EaV/gWEzZPD0jKPaxH4IJEOWq8N99C7cbFAtuJuLoz2zM9Xqi QK/ykjGbpTIocJ5YYHyCbUKtC5O+RF0GYzEFyQHX4ozqaIoPwqpu1xgMpeyoRS4x9/4D 3bJqKNey7+kopR/WfC3vwVsgiXZOyjzNtuYnRZS2tlN2pIskqNSsy511kaGSLQicY9U2 PIh7J0ws9nxdSC+5OAs9uTKu/bU7guocHNCRSVGQQ47I/ae/dW8njJGHGjH+Bl0XLs0v KneThcxWvH6kmsmfhPxpkIyG+ZDeOEFPch3BpZ9GH2vgp9cVQupwP2mpPmKlWkn8pCeB b/Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684940531; x=1687532531; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rwf57azNybT9v+Lg2CMN2sb9fLVIIGUOGeYghvdjLPg=; b=jJS5u/AkUk10GtveVki70Am+Phi7tDC4zMUSSI47Jzm2JUM09XAyEt5Gx0rt1LQDPm TVsUn9TghpQ3g9HlXpXVlAhBT4hIrlO0CC9m/YfJmDitfe/F8G+dmMZagC5PDFQF9F8W fpsPtEdXp5aXfNz2cpi3+E401tlH/rDG08Jj09i22Sw7Tr03s+WBpS8JuegknNuI1Qfk RIUIZ37DhCJRx/9AdMLSd+B2Z/hdovmvseoa9nNK4Less04XsHT0syPdp4dYPiRlp5uS bksbqZEcZv7o29vf/p0hK+SfusZo0qDCHOwTt2HR91sQSC7sIHH3FnUpi3jclpZa6shd 1wAA== X-Gm-Message-State: AC+VfDwoPmlNwAH5ckXsbLNg25Wau+X9U6X37IZMeY/FPU3pIozXh5fF MdxlA7by8eG9Z8gdcwITew9x0A== X-Google-Smtp-Source: ACHHUZ50tzfDRcH1j6S2Z6TgSbqpVFNpX8Jv88XOuQFTADKkXBGAMy329r3aqgfQXEN+hNSP1qppLQ== X-Received: by 2002:a05:6602:3420:b0:774:8571:a6dd with SMTP id n32-20020a056602342000b007748571a6ddmr3685006ioz.2.1684940531189; Wed, 24 May 2023 08:02:11 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id f13-20020a056638112d00b0040fb2ba7357sm3209457jar.4.2023.05.24.08.02.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 08:02:10 -0700 (PDT) Message-ID: <3235f123-0638-b39f-f902-426059b87f81@kernel.dk> Date: Wed, 24 May 2023 09:02:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 00/20] bio: check return values of bio_add_page Content-Language: en-US To: Johannes Thumshirn Cc: agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org References: <20230502101934.24901-1-johannes.thumshirn@wdc.com> From: Jens Axboe In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B595401E5 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: f6pudsx7f3isu8k1nnkaq78tjf74ki5i X-HE-Tag: 1684940532-803914 X-HE-Meta: U2FsdGVkX1/RWdNVrF50asNNyIEud9mQFjokjBwuh9x2grFaxCxGJATw0KDoq4A4Epe9lN+O74tK9KJwcaKW+ahTLnA9sBRmR5YXGzUiK5gAPS9CX+FiXD0FbehYN0zKCXcdgC/L1ewX+05MC4zpwsZMaJB+IJ+pvpROd7BkeIQm+6DRcU4EvxadbeM/I6ygJb5FTBixTQs1IcHy5m8W3bwEqWc1bexWAbiyHqgto6iQbTz7EikIpBuM/4RMUg3lsEwI79DsU92dAN+1jPhVozFhzhJCpBey9GNvtKzgiBIkU4DFxGdfA1wSjpsWF3U/ffg393tSny9WKBDtHOXw9T8hZXvO+Sw08gjx/Nlh+3sl7iuo2uaNWqZfK21OxuSDHy4XxQkRV2h0bJT6NkPTAzDPZ+jmyffv5s2m6xus448ELNBlu6HEe29vi31qs3aqc/jGEI3E7eOZSWWjk345dklsS387tjqH9RFwJTQ3021XdEMqfj0WTJM6lYu2UBOFVLFLQ+vZdznZDLDZFgNY70XWfLQ2ob9IDZa4gAkLiSD889uHSloaI6QKW0Z6TllkLvksVwb4TuWehHWVQC7fGFqT7yAgULtYQunz61frPJuzDltRrMWnmIpChbGy7bv49/rh+SW58YMV9XZ4DU9FSc7kzvow7TFPLiJkZ55xlTBuJti0rbfomWu6cvVRRMTWw8dXi031lLSm/hU7kTvfSgt0QTcnl8hux1lrSpoNtZIqyyN+Tm7cg720DvtCRGFTfCjf+d7jAdoG3TFeaA8hNJ311hPX2JWcmutZ/L0WQuij2rzXIzIa+/fiHyiRRZanwQ2Os+A5WvVVzh1wPKGIfq6ehMNmsmiZGULmJ3/ii13UJhpQYYVA3mX8j8X8CVgWL6KNnFjVLm9YIl45A1P70snp5TzXej0kgjX0CaGwTEe3GqNwWo9SxDs8Sr3fwLoxBueBq7RcKnSG9cUPlm4 6FZmqLeE ZFYn+CXHGm37AmlkcdF3bt9DnFNDpOJIGZDHOYJh6+UR7sfvttBVwIs4oN97XVkk1oJdTkTjHX/WgIIOznrAqlwF9yp1iELprD2c6F12EQ+lkZgsS1RY8q/QRfY+B7rPKkxsSxq8z+9NbYbdwDFLyTA2sY/sE4t2AUjN+WLUi+YUnwFMF8Tkg5S5nbL2oOGEXwuNx81pMdPts16MDSAWI+12JI5S+FZNP5aMCcZTqMMeliJDybGZliK1oclcswnQyd4+0vmwrWBfVKqfDPvVnm2VDv1kAWrxgDUNgo011IhNxHiTaBtB8afBLc/j5/DaK8FHqe2TT63bL7cze1TIpTOMpu8xZWssx35OjR7VitC2WMX5755ew5G3SJ5LUXwaTGQFut5i9YBwCeH9tYKh3FI6KINN4edmrnWH8E/c/eMa86hWVzfXsykZGvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003767, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/2/23 4:19?AM, Johannes Thumshirn wrote: > We have two functions for adding a page to a bio, __bio_add_page() which is > used to add a single page to a freshly created bio and bio_add_page() which is > used to add a page to an existing bio. > > While __bio_add_page() is expected to succeed, bio_add_page() can fail. > > This series converts the callers of bio_add_page() which can easily use > __bio_add_page() to using it and checks the return of bio_add_page() for > callers that don't work on a freshly created bio. > > Lastly it marks bio_add_page() as __must_check so we don't have to go again > and audit all callers. Looks fine to me, though it would be nice if the fs and dm people could give this a quick look. Should not take long, any empty bio addition should, by definition, be able to use a non-checked page addition for the first page. -- Jens Axboe