From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C443CD1288 for ; Wed, 3 Apr 2024 10:11:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9BEB6B0083; Wed, 3 Apr 2024 06:11:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54C46B0085; Wed, 3 Apr 2024 06:11:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC5CB6B0087; Wed, 3 Apr 2024 06:11:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F1B66B0083 for ; Wed, 3 Apr 2024 06:11:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 26327A0CF3 for ; Wed, 3 Apr 2024 10:11:19 +0000 (UTC) X-FDA: 81967803078.16.2A2E79E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4217F40011 for ; Wed, 3 Apr 2024 10:11:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NelZDL2D; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712139077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q10XbPWbwPAYz3tVe+780L2sWGchjiaH8ntssWQEh20=; b=JDq3iJnOFQ7htuh9qh8P+fWt0veNdKoCAxzhIcKay0edUYa9MRMI0yKZfWPIGnQYww4yFe 0CnsRLm90Rj6WogfvaH2zecLJxLnk5bZQ7eu/bweInjSbGxiziiVnfkkgxNgNj65+Z5Iwl +fxGv+pdWB9OCwi28jiBTDSa2e0AsdI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NelZDL2D; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712139077; a=rsa-sha256; cv=none; b=ZoduAvAjKnFBEZZ476SS8PltURhjZn6pOfjiim7Suk2u0PPmJ3ocB0oFs5WitEglNpE0r2 RA79blCEb6lxhcKlch6cVV7bay8wkjSuyX0HisnkDOTGkxbuqI7FMQtZn7zptlurwfFWbZ 4k3j2/uZnmDquWnwhY3rWX24PBol0Vc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712139076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q10XbPWbwPAYz3tVe+780L2sWGchjiaH8ntssWQEh20=; b=NelZDL2D6NrJu1Uf7EyIE3S07UKewXjSFatlmERjpKgGlhCop9GMZIZjJCiUZtdJ3Vaof4 ozcGhoXocj1yje6eik3q5FysmPyqmUQ2V8lYw2CXnbY0qtC7G4nPtdm/+u8jzK1FrepV9Z hp2ZBOD17cgQfANqRGQ/6Muq28m+AXA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-n6tZ6td_NZGxPdmOiGxErA-1; Wed, 03 Apr 2024 06:11:13 -0400 X-MC-Unique: n6tZ6td_NZGxPdmOiGxErA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD06C185A784; Wed, 3 Apr 2024 10:11:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51AC140C6CB3; Wed, 3 Apr 2024 10:11:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240403085918.GA1178@lst.de> References: <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3235933.1712139047.1@warthog.procyon.org.uk> Date: Wed, 03 Apr 2024 11:10:47 +0100 Message-ID: <3235934.1712139047@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4217F40011 X-Stat-Signature: 4ipr68pjkkpw4u11n6jwg8fwbxwsgz67 X-HE-Tag: 1712139077-600047 X-HE-Meta: U2FsdGVkX1+ralw+XYUGIXOGGv6yDKIAxIf7f85HYUq7s9HTLUryAm/kjbDmU8+/B8wCk4xBk4f3Lq9eBEmgMbBaIZ2zCQbpxIzdcYyLqXVFckD91enU867uZHQe5bgFKzGWz6Kki4aHALNkcKS8eqGvrM1oaPN6lF/5K7sEZZLwRbcsmPlp3NeyAoMa2644Jv3USs2H1NFgfnfQ5GHQ3RNs92lFiC1mygMfzR7DVVaghmEnKVitUI2z3hoHJkxoIh67n0JdVPvd2LOevf37Wl85arrO4Z1bUA9w3mPOsfJ3DnU6aeTQ1vk5lKhQGfKP1MzfRUvbX99me0ODfpFHsDtQqY2NJvFXv4C+ir94SwfNUWZNIkJKRscj7pzDaif+wrq5VWM91PymCEeLpsdwJtFmd1jfCwvK+MgPGE/DMA/HpKMgyfd+ZPXMnpmJPcGxSlOI+xxOUIvLuJJ6MWqbVlxSVzZ4B6g8M0Zr1n3VLLXFfZ1lNdlK8cAVScL0mk0nzjxoaIRjOAeBsNm2vhkf8/Z8WM3eG0NS/4gVLQQZ8eTxNiHd4q1mpwyZvjA854mOClWxiyMGOoBA6U4F6LCnTklr0yyvivJtKKhTS004tjF0g2bHHQKOmCYNBnmtCKFCNHFgS/irAb6cUPPiwHThC2fmXHJLQVu7YRm7K1vWRhEOc+3128UFKOIAQkCb2ehmFoUjvdwpgUX7J7l9O3dMYU81+2cISmCFVyE5QxX0rR+uESDub+iT94OBE1cl5ufVm3134NZXNRt4x2he+OaY9hpOYKeY0JANky68hq3oxTj9iqeYrn0IJ5n7NtPp1aG4Po3LgbGhn8yUtSIFm8B/fUgOPFDg6xccul6r8cwmb5Q9SBYSElTphFFxG2jgGKgnN9w5/VBo+R30lPjXJ9od3fULHuRRv8iUyrR26Bi31fnkGiBH+A/n2EjVgl5nuhXKwt2vAymcMK1gjcYinZ9 TPvWVqVM xQJG3l6oebZlAoui1BdfBw/jcMbE9+39PwvOW0/QrEru6dh+SaVSfRl268MnX0No/WZvzVD+8l++8LnEWCkpEiYT1V889XzU/KdgDeW0joAMSgV1Uui676oTAOwKJbVUVsNIeIbgSb8g26AI8nvVQP1ijieedymt9NoUv3cp9QfoBqZZGFAt9gCiIPJ6NU0adYIAOp3IK/QtuCOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 04:34:07PM +0000, David Howells wrote: > > Export writeback_iter() so that it can be used by netfslib as a module. > > EXPORT_SYMBOL_GPL, please. That depends. You put a comment on write_cache_pages() saying that people should use writeback_iter() instead. w_c_p() is not marked GPL. Is it your intention to get rid of it? David