From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3A9ECAAA1 for ; Sun, 30 Oct 2022 18:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 626FF6B0073; Sun, 30 Oct 2022 14:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7948E0001; Sun, 30 Oct 2022 14:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0136B0075; Sun, 30 Oct 2022 14:52:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3E4696B0073 for ; Sun, 30 Oct 2022 14:52:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FC7080521 for ; Sun, 30 Oct 2022 18:52:57 +0000 (UTC) X-FDA: 80078512794.10.4BDBB87 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf09.hostedemail.com (Postfix) with ESMTP id A7394140009 for ; Sun, 30 Oct 2022 18:52:56 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id 130so8951120pfu.8 for ; Sun, 30 Oct 2022 11:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8elokwRQaKyAP0dM+0zhrI4gx5N3/CeBtqzPukuUnAw=; b=YUcGwd0QsHpWm5d+rOP1CAI28Pyn+kV7aCrc0+3OM+5XkOTwufAR2n42u8HF7hnyaI jC5RpPKjR51SkhWwgPkoC0dYeQLZo00ObVmsNzX4s74Fp6DkVJnJq85PUD9JnLaLJRVS 0weUrPp9RGHpSE7bb/3XvL+E0xyv+I95LDYSh9HIi2+NbubdlEdoiAvFCsDdSeBWhTe8 mfPWHjC8Fga8Rl3vtLtWOtwRgFSa973dzYcqET8G0cwQqloY9mqTULWcX2EwylEHWbXd JG50hMNU3R6bZ6fEV0fvkKxsBHTxYrFBo55ANUbWTj2MDirSLDcvd/SB5oAV8i6M5BDK tqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8elokwRQaKyAP0dM+0zhrI4gx5N3/CeBtqzPukuUnAw=; b=Q9bD8w8Zhxl1FsxCrIZcHjFB29DjOOx6WwWUsFylZpAGGjblC5CtDY7WLBNmO1dBkB iPm0TzrgIK+QUwwjyRebUDmyEgZyxczo/lQRM4jHCtadT1u3PHw3CsMYULEFe9lgus7K uyreW7x+Wd79BSEV6A/SkwEu5q3BA976cVbaw5PGfgZ30oSi/EVHPNuBZbmSxbimxH79 SXPP+d70YcvnrMBqbKndu1+To0nfkGXZgHxstx6bXT4xDh+hsEVv5jVZ1uhouZ0QNrHo DHwnDPloWDpwfx1isV1ba8blegaeWhP3ehi7uObdKXA68npEePqW9XHuFG3mq8Dfx6zA RSuA== X-Gm-Message-State: ACrzQf2uo6AzYzs515vNEHixTE8hFus3yVYu1pAB2lk1pDM6Y8c41koh dIdV6TcnqAChnIPMxetl8M0= X-Google-Smtp-Source: AMsMyM6jIFTKWkHx2DeQKawqkSo5aIPaMrRPSIaPPkTGyp+gAAy5hs16vCm9pFqP9WPtnZCljLFS4w== X-Received: by 2002:a63:d90c:0:b0:462:cfa2:285b with SMTP id r12-20020a63d90c000000b00462cfa2285bmr9215780pgg.202.1667155975363; Sun, 30 Oct 2022 11:52:55 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id k3-20020a170902ce0300b00176b63535adsm2953022plg.260.2022.10.30.11.52.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Oct 2022 11:52:54 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2] hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED processing From: Nadav Amit In-Reply-To: Date: Sun, 30 Oct 2022 11:52:52 -0700 Cc: Mike Kravetz , Linux-MM , kernel list , Naoya Horiguchi , David Hildenbrand , Axel Rasmussen , Mina Almasry , Rik van Riel , Vlastimil Babka , Matthew Wilcox , Andrew Morton , Wei Chen , "# 5 . 10+" , Linus Torvalds Content-Transfer-Encoding: 7bit Message-Id: <3232338E-77BB-42A8-9A25-5A4AD61FD4B2@gmail.com> References: <20221023025047.470646-1-mike.kravetz@oracle.com> <7048D2B5-5FA5-4F72-8FDC-A02411CFD71D@gmail.com> To: Peter Xu X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667155976; a=rsa-sha256; cv=none; b=XjvXiKie7h1B+jceLTfTbW0rsNtExOiMfNUnGYRStLM1jRpKELxHTtOQTflR8o/IV0Jaev acl8UuA0TlC7RP79FbZEV5k3UDyBVTyM0KCez/IzETFGJmrzI+VbAgVFarbeptfJNBCSCL iIyAUDCpmOPuKYbFXCLGeZGsSl3kc38= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YUcGwd0Q; spf=pass (imf09.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667155976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8elokwRQaKyAP0dM+0zhrI4gx5N3/CeBtqzPukuUnAw=; b=tGUnp8v63BZP0kDPTEPdfFL2WPDnq4iaaBVzJKyYDCVS3toWoMqqti3jJHQgErsdaF8HpB o7S7F/NiQAo4UwV97blzOOwdZxZq1Wlrg3jR2/gLJ2NlcWbQs9hdkOcwx8Srw0j93RppTR 6C1MysNWLReuPykPBHjHcaM9yLrr9rc= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A7394140009 X-Rspam-User: X-Stat-Signature: w3zxuqnexkydp1on9xq1cokkko1ftown Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YUcGwd0Q; spf=pass (imf09.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1667155976-18913 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Oct 30, 2022, at 11:43 AM, Peter Xu wrote: > The loop comes from 7e027b14d53e ("vm: simplify unmap_vmas() calling > convention", 2012-05-06), where zap_page_range() was used to replace a call > to unmap_vmas() because the patch wanted to eliminate the zap details > pointer for unmap_vmas(), which makes sense. > > I didn't check the old code, but from what I can tell (and also as Mike > pointed out) I don't think zap_page_range() in the lastest code base is > ever used on multi-vma at all. Otherwise the mmu notifier is already > broken - see mmu_notifier_range_init() where the vma pointer is also part > of the notification. > > Perhaps we should just remove the loop? There is already zap_page_range_single() that does exactly that. Just need to export it.