From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F25ECAAD8 for ; Sun, 18 Sep 2022 22:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C648C6B0072; Sun, 18 Sep 2022 18:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13A46B0073; Sun, 18 Sep 2022 18:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D2F940007; Sun, 18 Sep 2022 18:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A1BF6B0072 for ; Sun, 18 Sep 2022 18:41:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 66EAC14037A for ; Sun, 18 Sep 2022 22:41:44 +0000 (UTC) X-FDA: 79926679728.03.186CD85 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 0472D40005 for ; Sun, 18 Sep 2022 22:41:43 +0000 (UTC) Received: by mail-qk1-f171.google.com with SMTP id d15so19450505qka.9 for ; Sun, 18 Sep 2022 15:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=T3gVy8PY5F80NKzToZR+FbLhKAMIz93GHIgxt0CrUHc=; b=IdhMRMeVpLQC67KcBFbCc/Jk0NGq4dg7JkjAwoTSwVgFyHVLpmo57WQ2VAAFPSpOJR r/9qz+pdnTpAd4aPzMyGQSWik9rG81luFOikAvBJeo/smV0jCiTpWVQRbtdBD11hJ5k5 l0DbhUSUT8rbGhN/x730+aAlpW9MR1K1+gYSN2IJK+rVK5hpDSv1JYkHcMi45dtuqGjR fSgMTT+gm/9mlBfp9hEjn7wRVetzg1vsIXa0ief0VysCXiH+e5dsCFW1G4DCBFE8A40K xr4IsApIfjEqUZLbzo/a9wIdVKrsR8252r9e6m7jTn8timZ9ipitjOxOwiqosjNzfFUQ jjIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=T3gVy8PY5F80NKzToZR+FbLhKAMIz93GHIgxt0CrUHc=; b=CbRYWBdfYpIpVnsFstdpzhXW0EHARCDUE2ycK5fz0DymZB/kzfV+egH/ayWkZvReaT ASEby0EPFoEN4M9bHeY986xbzupl0jSlr50+HDqwLGSH90IvL8BclGMlG03pVPsCemRe ZI+0C40v3c4Q/6zT380O6L5EvQ18lBETDQhUBoKdxFA89RkOqAlC0vCLujNjpm4G4tAN AF/V/XIrmalPQ43FWiPoDBNTvKd63Pb8zbnFN5hZv650RXc8e5YB498RAl8eyt6K3eO3 PCrxUF+MPVA4ElmHAv07ho9t0HuL3dwWXHMNHvxrLECGU6CI0ZuYKlpOIG0tNlyDgWsS vp+Q== X-Gm-Message-State: ACrzQf1rXMJqvRQNg23pUTn+c18XX0lHCVvGhWyllLVeBVnGbs40hB5H vrAb58LO38RNsspwbj/GiGk= X-Google-Smtp-Source: AMsMyM79ModVLCgaO51KZdimfwEWQbDJb0RVfNll2I2jhJXQhJFNDD2szD3/oSle4SS7VVvj1xrxgQ== X-Received: by 2002:a05:620a:2441:b0:6ce:bc87:a3b7 with SMTP id h1-20020a05620a244100b006cebc87a3b7mr11277117qkn.113.1663540903292; Sun, 18 Sep 2022 15:41:43 -0700 (PDT) Received: from [192.168.1.50] (ip70-191-40-110.oc.oc.cox.net. [70.191.40.110]) by smtp.gmail.com with ESMTPSA id d8-20020a05620a166800b006ce0733caebsm11017959qko.14.2022.09.18.15.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Sep 2022 15:41:42 -0700 (PDT) Message-ID: <32303ffa-3f0c-5a83-fe97-69fca07c3b32@gmail.com> Date: Sun, 18 Sep 2022 15:41:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 16/21] dt-bindings: reserved-memory: introduce designated-movable-block Content-Language: en-US To: Krzysztof Kozlowski , Andrew Morton Cc: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Mike Kravetz , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Florian Fainelli , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-17-opendmb@gmail.com> From: Doug Berger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IdhMRMeV; spf=pass (imf27.hostedemail.com: domain of opendmb@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663540904; a=rsa-sha256; cv=none; b=x6PWvMZrE4zg7/54OyQlgxexQPORy72lh9NyMxW8SkXpMQvL2DjCbB3Qwx9rFv2Pig2Fgq OxtZDBTVuTdzS+N61CgwAuNs/GBTh4nI/Grzp5+ezliMTU3fCvmQx4RvIFQNakIP1uE/Wa FzCmOQFP3WgEvWwaFJlR15tzuo4Jxd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663540904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T3gVy8PY5F80NKzToZR+FbLhKAMIz93GHIgxt0CrUHc=; b=47xTIilChMOPvtpQ0ir2bhlt0OwcjGG4LryJBkSCLA5ssycjT6tp3IXf9bmPnN466FlFhT yU6XGBT/xj1cySxTXHi62uiRO/BU90p9ZixO42P2mOVvJm/OXHgh0i0s+iwqIqCmN4SgQX HPxmF977CejF7J4eGOhMKJ/DMerbGp8= X-Rspam-User: X-Stat-Signature: i1pmu7umzgbbm35qtp6fzra97mqywb54 X-Rspamd-Queue-Id: 0472D40005 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IdhMRMeV; spf=pass (imf27.hostedemail.com: domain of opendmb@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-HE-Tag: 1663540903-325266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/18/2022 3:28 AM, Krzysztof Kozlowski wrote: > On 13/09/2022 20:55, Doug Berger wrote: >> Introduce designated-movable-block.yaml to document the >> devicetree binding for Designated Movable Block children of the >> reserved-memory node. >> >> Signed-off-by: Doug Berger >> --- >> .../designated-movable-block.yaml | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml >> >> diff --git a/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml b/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml >> new file mode 100644 >> index 000000000000..42f846069a2e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/reserved-memory/designated-movable-block.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: /reserved-memory Designated Movable Block node binding > > Drop "binding" > >> + >> +maintainers: >> + - devicetree-spec@vger.kernel.org >> + >> +allOf: >> + - $ref: "reserved-memory.yaml" > > Skip quotes > >> + >> +properties: >> + compatible: >> + const: designated-movable-block >> + description: >> + This indicates a region of memory meant to be placed into >> + ZONE_MOVABLE. >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reusable >> + >> +examples: >> + - | >> + reserved-memory { > > Use 4 spaces for example indentation. > >> + #address-cells = <0x2>; >> + #size-cells = <0x2>; >> + >> + DMB0@10800000 { > > The convention for node names is to use lowercase and generic node > names, so just "dmb". > > > > Best regards, > Krzysztof Thanks for taking the time to review and provide feedback on this patch. -Doug