From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC679C369CB for ; Fri, 18 Apr 2025 11:50:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D59D0280150; Fri, 18 Apr 2025 07:50:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDFBB28014B; Fri, 18 Apr 2025 07:50:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABCEE280150; Fri, 18 Apr 2025 07:50:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 89A7428014B for ; Fri, 18 Apr 2025 07:50:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 74DB2161BDC for ; Fri, 18 Apr 2025 11:50:50 +0000 (UTC) X-FDA: 83346997860.09.A34A142 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060.outbound.protection.outlook.com [40.107.92.60]) by imf01.hostedemail.com (Postfix) with ESMTP id A507040003 for ; Fri, 18 Apr 2025 11:50:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=P+Wk3xk0; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744977047; a=rsa-sha256; cv=pass; b=UqVki+RMMcwistWj8owPbjfRbVTzBY7HJcgpUAN0JimcWZe2i1wn1YaCGoTQoWuE7PgwjA WCw31Rp+6ql31twU+OvoaifptWcJqjnC/oqEInS0Z5EJdFVsaTSfYGAgkw3BOLTCo0OSSw kOlNOI1+zjnvbY6T1joTHmGfmlEr3qo= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=P+Wk3xk0; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744977047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UKmZfJqjXfa/n2W6Zhod9PjD7dfyHW2huZNXMqW+h58=; b=uLoP7KurlsoNzjqSvYLa9R9PnyUYP5oWYFuGyfImpd6EzvL1z2s3auqbPBeoKE6Gw3L+Xw pQLEZn2EzKSorXwUbl/ntqVoTPtKKYie+m6Hke67SeTUWx0EVuMja5AuyWdmVBB5+zeCKD uo72LkFEIscYJ8Zzo92mbWMEgwYM99Y= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XvOfRvc8a57VWoaHm3Lq4tZkq3lwoK1YBc0PbvRVApu1flkI3C5LiYfPxuu9ArnXRb/Qdk6I51vL42WEF42erZhatqNjtQFxw+Waqv+8HbjoZmeTjSP2o214YlfCrdUYPgEmzPGBtt4SkC6aS4x1TXlfkkkHzLB6FawC8B7rDnvm2iUGrEsemzcCFANgTBlnTl0gU6nwsYpXurR7v9vBgCz9ClOIjC3puJl8ytaywUVK3O6JwR5tdROQE3PTppL3AeygG2ds/EMIHMS592vOHgIRE9we6mb3U1zxeZfVm05IZzKbDRv6ZdR8XntILlFygh+1tN9EJiH+39GXrKvytg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UKmZfJqjXfa/n2W6Zhod9PjD7dfyHW2huZNXMqW+h58=; b=oz09AG3NuX0vyvfOvCYhHqZKSZZhjkTTZ/chN0HX40xeSQCu0A8Doe21Piofe4+OiMAbtak//WvsNKY01fAmnq4HDq1Ezjon0+A14pJRcsxgckCbQ6g2vf5MxxGLLi4tYT4tbyvbTdg3bhO5JsypBIM8QvpyOAvxMGQWie5Pc3BsbpINy6YiwrI2fDbbcnwjc9zsuZ/yXGzrp/9psff8dlvmwFoIWk9dxOKdbxCMt8cet0UOWEyZPjAcB1zs/K2wMhVJLwr75qlLk9DJKsYJejd/Obh8E2q+Th5jVkN/8/iGrIBQ+ZVfWy7WCdk429PmISEHLlQDDPerqvV81Cci7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKmZfJqjXfa/n2W6Zhod9PjD7dfyHW2huZNXMqW+h58=; b=P+Wk3xk0hxMjRvtMdzl0sJ5vjDfKW5th4Tjpe8B1ArKDDXdfFWYzuz8JBBzlXQ1Wt+WnspjZsYk6sLYL0iDsdwli+O34UYG9nyqeniYDQuK8I3UARICl3H5PwuRWd43H3WoVqB5hsmPOQsOIdmJ4CA2EetxXPDBjolncGeijvtExM/WMSdlv9r7fmFjtkl1D7/UC4TIUwJRijvXBH8cfT4OnptJiPFfdxx40z+JEsBkJKxQaOzIkVtjCpu1UWxJpWaMKFcN0rjXhZtChkeCI4QE4UHjpIz9VkqREIdNhZoogew3hzBVww+RSopHheVmS0krAmhU30qWJFFUdsK/JGw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DS0PR12MB7851.namprd12.prod.outlook.com (2603:10b6:8:14a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.25; Fri, 18 Apr 2025 11:50:44 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8632.040; Fri, 18 Apr 2025 11:50:38 +0000 From: Zi Yan To: Gavin Guo Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mm/huge_memory: fix dereferencing invalid pmd migration entry Date: Fri, 18 Apr 2025 07:50:35 -0400 X-Mailer: MailMate (2.0r6245) Message-ID: <321CF34D-79CF-4B14-AE3D-5815B8D74E8A@nvidia.com> In-Reply-To: <20250418085802.2973519-1-gavinguo@igalia.com> References: <20250418085802.2973519-1-gavinguo@igalia.com> Content-Type: text/plain X-ClientProxiedBy: BN0PR03CA0027.namprd03.prod.outlook.com (2603:10b6:408:e6::32) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DS0PR12MB7851:EE_ X-MS-Office365-Filtering-Correlation-Id: f0b85d06-e76d-483a-f676-08dd7e6f3ca5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KvoFXhyEm4sCVHRzoyW3OhYjuZ4zmeKvWTfFc4LY+VlCcQR2BiSVPW9vHCei?= =?us-ascii?Q?XNbwh2z+sMukYUF342sSB9WcvbCSeEdDCc9aJUCJ1pFHomtc6LyITMuw9pRo?= =?us-ascii?Q?LSUzHdKTlYMR/OJLJar/NzHDdtoZg/ez8gPqgK04r7snFrZj6TcUybwLD6nh?= =?us-ascii?Q?usl/etOYetaZRdIIUpT4G3S1qCJ6pK8cqEEEf7R609ksozT9Beq6mxl0Bq6w?= =?us-ascii?Q?jtw3qrzNGqG9d8uw9HCejCVypkOPnZwSrh+xcOth51sMVwEV1eGByRAxTV8w?= =?us-ascii?Q?KquH4BIXxAQSVGji+mQhePX75bHEmVMRecEJ3xbcJ3wG8Hw3qW0Gg5HEqFMy?= =?us-ascii?Q?iPWwJR7uiHgGcpzFntHMePRVDHvHqsLJHRZ6sDdSpF5BeYrjre/spgpvCfJv?= =?us-ascii?Q?PuWDDqvgUaKNmJuj9+EikANOLAdjXJISrdqCAQ/IhxAZ6q+W2pnO8OEXndqE?= =?us-ascii?Q?9P2kFWIlf/To18WJIMckn1OmfvbnLkVfQWV9NYay129RrGIXlSeflpkrrDEV?= =?us-ascii?Q?/J3ADjy9PT6Y/nlBhV5Idk/ypFo3P9/ToBrYUkzJfDeWfQ/63sEJv5NWjWR8?= =?us-ascii?Q?Pk+lGZxJ7Gdgo2jpmXLr1ExUOwbAk8RbhAlA8k0W854PlJ3UMQAkm89joqvw?= =?us-ascii?Q?vZP/0V4LnjOE7e6jHdApMHs6y8nKLuSFQ7DxLTDEyjr0XDKeksrNeix5crBg?= =?us-ascii?Q?FZVtz0MhvKSdVJOK6larPb9iYY1xjB0Wv/WOFIlYgQZbvZEg19L9EMISrZVs?= =?us-ascii?Q?27/vJKkQEszBd/NgXX70tErWJhSxo8Ct79f9+AsNkI+pNFBYUoVEEIibkLrR?= =?us-ascii?Q?WMit2OTkh2meMNoSHWaCM/7gwZn4e3qUzry+HW4y4WNdUogrbog/YN/r0CXU?= =?us-ascii?Q?BQCs7sqWHu92QovEDATTdOOOa+rk1TU2ZuJ62LgNzQ0tQXTzbOWbUbNBYc7q?= =?us-ascii?Q?LA22Io+qWBubGxK67bauBbUGLwynhM7SPjf4vcVlTAwz42RKe5UARbZ7nyYF?= =?us-ascii?Q?IghSrcy5PevQleFVr+bgx3y5arUgyV63Wyuflia9pT/EUqqwdtRYJrVrV9l0?= =?us-ascii?Q?Zp61vq6/2n2REb8ny/IPdPgQOkNy8cNm6uPPdiBL056xHpnH8v1BeZgUi5YA?= =?us-ascii?Q?414RpSQm2qwjH7F92qyunCEc22xVhbDHutawu/U7E5/OGXhK1x13XxS/3tDc?= =?us-ascii?Q?ALvYYw0Rb8MxaqgSt0b+rVyFdrU1TFv8Fjg4+qbilAFlUYcR+XglCw8EH5Kr?= =?us-ascii?Q?5jbeLnQEzGz7xfN8KV7E6MynoiSW0K3Xi0ePQwOJJj6DHrLjegzv+xmqBQp2?= =?us-ascii?Q?GPHofi9bSGRDjctNaTX1sKr+CD0enZa3DihYuO1WGnZg18EryB4c/pgrpnfb?= =?us-ascii?Q?QgvcrwND2QU53uLlu6kEUV28GlLqVAQlbBJSjpb1vxRvDpgGgRpLH0zwTyW9?= =?us-ascii?Q?GD/K3aB2zdY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?asnCRyit1jt4/hpNCu6AAx22ypPDeqr6UxXu1gCo8hWnNrsiNlZBZwk6yLyP?= =?us-ascii?Q?QnZJRujC/1q75rbQjG3nzKrlNoqTlGdEM048rpU4EWas/7UWyLJCyTVXid4z?= =?us-ascii?Q?hClzdcsOGoaDn8722isQMCzqzeOfP/vA52CSi3LrXVt/RvwTogLua0mW2YoE?= =?us-ascii?Q?7PuSnbPF0+lAm9jKhrQdqXXQcRAOCtbTvPbB87RAylOIcxUjT5O10B7UDhl8?= =?us-ascii?Q?92iY68ut9iDgxVnRVwdJAZJatlp8HEHnsP4cnVlzm5s5SOrdbMwC+XBXkoiD?= =?us-ascii?Q?7c7YHEbjdlyZe+AdUnYf8uNAhCeWahFtF/eH53fABI7zhXOLxkGhPWWQ+MFl?= =?us-ascii?Q?D4yZzM6TyN66BHzlLictYXuAQYcvwEeHzeZvClbuC36ujSsSnZbT/sk82k0P?= =?us-ascii?Q?TQgBQoKceRYe5Gdqsg764aFJcdbJIS52rq0IXTiTMxmqqj+dPngBjBJH4+CM?= =?us-ascii?Q?2X+8HJtrRcd2bkn24ztcI0rJg5pMKLE07iZPs6lDrexTGuJlbwWrYL9rFaum?= =?us-ascii?Q?fA0QgMGg/jwcGVS6SBjBVo6BLO8U2ROPND3uo+6x6vO7z3WSrbkhscg5pKLZ?= =?us-ascii?Q?+YEtlimPE4UXene29p21cZv2KTfMUm6qoTtlPbk7w3s4iEBtFLZFugEAZYCw?= =?us-ascii?Q?3a7F+kaLyXfDm2GnviUscxc1EuUSCBLbuEGpOhyjTW3I4baIYypUp3ztwxL3?= =?us-ascii?Q?8O4lq127S2GrNWg6tgQNSHLOAyJh2C/pxn+GEPtGEIjyjP5JYe3KigclP0Aa?= =?us-ascii?Q?Tngftz9UJ/c7DP0tnduz1umCU8bcs/hyZ1Sep4lRkojSrhMSZCS2holkiJVK?= =?us-ascii?Q?E4Cs1ljpkVntz3ZCCcl5a9DEDi0936899Ps1X91PkFx61ewYvPnZS5ZIhKsL?= =?us-ascii?Q?pm2i8NaeEozmJFue8kaC6DMog33qvUw0UIoU2Tew4Wh/qD8xcZlg9T677EOx?= =?us-ascii?Q?jat3T6uzgD5tOFzMyx+xEsf2vQHKB7P5g4lXki03Aw/vPOOi9Hq1cNAdpGce?= =?us-ascii?Q?1da4ELQ+8yj4pkqseqmcRgtSrI3ddMOQUZklgVZVyc3Mi1+Kw5jqebRETCdN?= =?us-ascii?Q?Yv+tglA6pYlgpH9WUdQDhXTTMo1T1AvbxwoAhkfUvo+lSC9uKOT7f3odKycn?= =?us-ascii?Q?Nn4M5Up82OJmHmfKMY9+XOQ3ehL/+hd8EVFvDOa3n+yRn2jgoRxEAqfl88Oj?= =?us-ascii?Q?yW1Ud6S0PP/TVV7fGlSuhFS+zuQQnnsgjJE49oeAY9vP8WqIUSLCSjZKhFrG?= =?us-ascii?Q?YNt+kBQ/SN4K4kyz5cx3bL2cszu4xI9CoFXWSDamt/kMbLKaVx1v47H7WzwQ?= =?us-ascii?Q?yBMS5hZTeIhETjoBoCOCIU5N6n4oBj/8k/X/wioHi9YykkNYT4WAc4jw0L4k?= =?us-ascii?Q?mSfhFDOo7KVAmDZ9CuHHil5X6omGkEyflcFVMAuh+GDaKbD53SNOTVKcBDmt?= =?us-ascii?Q?09DMbfSfh9qTBdPXenPWaq8PiOVOOVEnIhy+XYiKHVf0oN6cJE3f7KvH575w?= =?us-ascii?Q?+GRy8YDE7Fah179dXJYawPdyUbsqfk1SCyrva5IRFvlrYJZm6g4wka+DPcEC?= =?us-ascii?Q?GjJw2qrzXRKftVnpvPM289Ik+esUq9o8jmPIJqtM?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0b85d06-e76d-483a-f676-08dd7e6f3ca5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2025 11:50:38.1603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3gMPyEW2Q31ebAm8+MT2nZQ8MNGa6Aw08ij5Qw2PLWibJl0YBQX0IHxdJBBiWvc4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7851 X-Rspamd-Queue-Id: A507040003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: y7uzhqbu1yqoheifmksswc3b7wtchprf X-HE-Tag: 1744977047-917361 X-HE-Meta: U2FsdGVkX18S9stjhL5xaXkXQ/mAm0xBfS8n7XztdLxpJz22p4c9w0+FIef9DqiWXe8O0CzGpyMvjM1iW6d4/W5GuHgMIoYDNQ46dgTAeN174K27h4TTDhai65WvDkmUv94ytooS/oe3iKqiQaI9TI3Av+rBo4t6I6zLEMhaOTgSySJYM/7s6B8lv2lwEFKXVKYnX0WbX/oz2cVF6szatJcCyeRBo7k0Osc/VNuLC8k/zgZ1cmYIHkzIMgcWVmvuls0b59XdDxcguXft+0mONbtUPS2Owv3j14s4rVnrvn7mQopxouerj9ywONtMf1WrjuNjp980HBGNUITjgYYD5VndsdTlhGZYXiId/3J3PJDmczbkzgI7kb8oFHBh+dkfwc4znVaTGFo0+alNTGIyu2EjK+rIoOnQY3IzvA2Nhkisl8OBnJKe0m2b6/2ZOJUy6bsEkWNJkLLHaegtNQo1MHtoG9TlFr8NYqHVnTqx8Vu0eRlccNPYXlx6vOzjvMdiily7zhQxHCkv/RZxokeNdafK0ITpPq44jOBLnkvNzXZTnPw8ChnuGHe8n/KEaSU7r/HgoT3DeJc8NUzyiHcrL4z5+PC5o3z2NbKVIKc89XbHYo5EBYwsxZ/CGkr7imQTsZlj/VO2Jz5g8mu6BP6LzISag7NrXMc4C2bg6prfpgEesG03jaITCJTEycTrXzVCJVzQGzyzijb32unCVbCcxF550Yl/T5snWTGSNyOSsBVGRS8ae5TStDVX5dOYQcAMKXTPRaP8eqEbmunrxUPZgfM96CWLda+YFbTf+Q/wer8IaZ55ELyjwvMErLAHQAFrB4oohAMxhwdGiPG8irJuu4H5ImllQG15zEX0HERrdep0heNdzo6I77CfpH4xgJXc4TcZB4HRpmiOYWWUeHUCWXtq7nkdmLrig3kSnTNDiy1PdAqDwMZuLgQHCeKkQvccpAy8p5FZCEjX5FJhibD FpHzKY1e aWiTKPxfgNh+rNMWG2AcwO400lW5pgDekUV7ifb4BK/jKShHCjzz0+YNMvAlUKciUld4CxBnVxJHBXTkyECGzxsQzcr8wzJPOzl13DRwlq/mECAD569oKVYXdavwvzNlsBvPqcvkY5u/h6tXOPxc7vlJHy7UEYX23wa9ozRUYz82A3EB+Vae2QHZDc8QBUuY/rWVa4+/qIa09pZi56AJxLzGdBiPbvp6duya2eaUTkZcXRUGdZbW5MDvopPws3/AKieqvDWDnqQUA70JirUpl789hp3Ba3KBTkha8UXjpcjV2l8r0V/HIOtDS+SGhZEcUrG4EjjOC/WvzBUVKRVs6EskYrpbMrBtbezgoVoe35+hRcEjj6GLYVD9dvkp+z5qJDOCbrSXmnxOhX+E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002660, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18 Apr 2025, at 4:58, Gavin Guo wrote: > When migrating a THP, concurrent access to the PMD migration entry > during a deferred split scan can lead to a invalid address access, as s/a/an/ > illustrated below. To prevent this page fault, it is necessary to check s/this page fault/this invalid access/ The rest looks good to me. Best Regards, Yan, Zi