From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143F0C433E0 for ; Mon, 8 Jun 2020 18:16:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD71820775 for ; Mon, 8 Jun 2020 18:16:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CsGp6Bkf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD71820775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4FCA06B0003; Mon, 8 Jun 2020 14:16:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A9676B0005; Mon, 8 Jun 2020 14:16:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 399096B0006; Mon, 8 Jun 2020 14:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 2214A6B0003 for ; Mon, 8 Jun 2020 14:16:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C813C181ABEA1 for ; Mon, 8 Jun 2020 18:15:59 +0000 (UTC) X-FDA: 76906848438.24.home15_320bdcb26dbc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 46D64601C3E for ; Mon, 8 Jun 2020 18:15:59 +0000 (UTC) X-HE-Tag: home15_320bdcb26dbc X-Filterd-Recvd-Size: 5343 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Jun 2020 18:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591640157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cInUqj2zxtHKpKYLal5TJdIffhXkWirkcKp6cu0bNtU=; b=CsGp6BkfEmwv8psykSfqKeapjxflLgZ1s93bUv0D6iQSPZ+Qh+ImjgBHnOGgUw5r+Mc/n9 vthL50OU9iFS/EDj91T/GbY+3qbcAK2UG2jJvdRNsiF9b0kRBaoKAhlXMo3Rp9lAz/Tjoa HsPeY79m/EzzAwdlHIAfNAoC+7mOm1A= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-cx-72YyxPtOtCNlOO6IOcw-1; Mon, 08 Jun 2020 14:15:56 -0400 X-MC-Unique: cx-72YyxPtOtCNlOO6IOcw-1 Received: by mail-ed1-f70.google.com with SMTP id m23so7232335edq.6 for ; Mon, 08 Jun 2020 11:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=oIo80SnB/PSIWlFE9jQ3/SK9wb3PpgcPr98lQXyYwj4=; b=BIjtOqqVtNzXzvfb+DLS6jkz1clzHpK3Nq0T8ISqanvTu8NdrxyxtFwWrOf/NH4pWD wjl1WQ5eNXS/3S+qGpbmBP/D0Buv1Db22nXbicP3PjKSE2KSp76pNnk+1oen0LPYlgAL TV9OgvKQTv/YspYtNrtrFDcnKFkExeC8SGP6C7BtVntDDQjYDiXOuEMn/LAogE4RjJ+T HSFQTmFRTy6oS0W8wWDqSrop7C6JHx/GSjMXHBe+fOXKn92AU3sEsJupML42VzI0DCoN kAe0L3y6M81DJ0NB5sJSfp3WQbHZkU6jjRxadP9iwiepvK0Xh92nTzBgEuQU9/LBADbh w/kw== X-Gm-Message-State: AOAM531c3hAYeZ6v06QrYSic8Hjuy1iHWFhC2p2/+Hpp3SygutJGsLoG 0+RXE4pVQxZtesNbu6xOHI2lCWUy6z/5KspLO8u6z8i9OYgCtZQb9zJpVqB6TTwyFfeA04esPn+ BT8pmEarIFUY= X-Received: by 2002:a50:ac84:: with SMTP id x4mr23961558edc.124.1591640153224; Mon, 08 Jun 2020 11:15:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFuIoKxqy0jjsfx01sqRkTEypgRvXwuITW6/q5hDponWWttStC6KsdShp0bZjj0Gw9JwhjrQ== X-Received: by 2002:a50:ac84:: with SMTP id x4mr23961498edc.124.1591640152969; Mon, 08 Jun 2020 11:15:52 -0700 (PDT) Received: from [192.168.3.122] (p5b0c659c.dip0.t-ipconnect.de. [91.12.101.156]) by smtp.gmail.com with ESMTPSA id k3sm13152866edi.60.2020.06.08.11.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 11:15:52 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules Date: Mon, 8 Jun 2020 20:15:50 +0200 Message-Id: <320E495A-1A3E-423B-A3E7-088004771E45@redhat.com> References: <20200608154917.GA8408@infradead.org> Cc: David Hildenbrand , SeongJae Park , akpm@linux-foundation.org, SeongJae Park , jonathan.cameron@huawei.com, aarcange@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendan.d.gregg@gmail.com, brendanhiggins@google.com, cai@lca.pw, colin.king@canonical.com, corbet@lwn.net, dwmw@amazon.com, foersleo@amazon.de, irogers@google.com, jolsa@redhat.com, kirill@shutemov.name, mark.rutland@arm.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, rdunlap@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, sblbir@amazon.com, shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, yang.shi@linux.alibaba.com, ying.huang@intel.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20200608154917.GA8408@infradead.org> To: Christoph Hellwig X-Mailer: iPhone Mail (17E262) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46D64601C3E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 08.06.2020 um 18:11 schrieb Christoph Hellwig : >=20 > =EF=BB=BFOn Mon, Jun 08, 2020 at 01:53:23PM +0200, David Hildenbrand wrot= e: >>> @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page = *page) >>> MAX_ORDER_NR_PAGES); >>> return get_entry(base, index); >>> } >>> +EXPORT_SYMBOL_GPL(lookup_page_ext); >>>=20 >>> static int __init alloc_node_page_ext(int nid) >>> { >>>=20 >>=20 >> I've been told to always smuggle new EXPORTs into the patch that >> actually needs it (and cc relevant people on that patch instead). >=20 > A separate patch for anything remotely controversial really helps it > to stick out, so I think keeping it separate is a very good practice. >=20 That used to be my approach until Michal told me to do it differently. And = there is a good point for it: Reviewers actually understand in which contex= t it is used and if it is really required. Having that said, I don=E2=80=98t have a strong opinion on this.