From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732DEE77180 for ; Fri, 13 Dec 2024 07:50:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5C656B007B; Fri, 13 Dec 2024 02:50:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0BFA6B0082; Fri, 13 Dec 2024 02:50:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FACC6B0083; Fri, 13 Dec 2024 02:50:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 823286B007B for ; Fri, 13 Dec 2024 02:50:02 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F0251120BE8 for ; Fri, 13 Dec 2024 07:50:01 +0000 (UTC) X-FDA: 82889161698.11.37E1AB7 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id AB097180004 for ; Fri, 13 Dec 2024 07:49:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734076180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XyFu8RWb0D6F8QA6VsFKAlk9vaLD3qeJ5gpKk4caC4M=; b=ff+r+OebfN032Yk4DYMRkLv+sDjZg1IyMFARxtDBkkN7byW4cwZNyL/knIBUp/JpXudevm /RnTM7YHy1ZTsAFjbfQTM7Vmo8uUrFFdWfssT2w0BaiOiHAcPnmb9NNlNmsWO2ipeCSbQM FwVAfmg8woKxvxYv8007PWBGYeaChsQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734076180; a=rsa-sha256; cv=none; b=iBNOEqlxNQGOioCla34TXKtV+kI8juBlAOg05yErGHaFQIrk5ApIUBsFWrOaAOM9X5u78g OIbyvCAx8l9uWUi8fG4FzfjNQB39PkB/NB9Zxxxw+bqXvpPy7S4Y+HlBdytCqvtBQLI373 4g1gLyO+ajSuvh0YajcyzEmg+t9IYgE= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Y8hJH6R6bzhZTj; Fri, 13 Dec 2024 15:47:27 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 8D9361400E3; Fri, 13 Dec 2024 15:49:54 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 13 Dec 2024 15:49:53 +0800 Message-ID: <3207edaf-826b-4545-9c9d-906bfb4d312e@huawei.com> Date: Fri, 13 Dec 2024 15:49:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() To: Matthew Wilcox , Amir Goldstein CC: Lorenzo Stoakes , Jinjiang Tu , , , , , , , , References: <20241205143038.3260233-1-tujinjiang@huawei.com> <69b72e3d-b101-4641-9ce5-51346c93a98d@lucifer.local> <041dcc1a-0630-27b9-661b-8c64a3775426@huawei.com> <568698a0-c2f2-45d8-9d8b-e22e942fa422@huawei.com> Content-Language: en-US From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Queue-Id: AB097180004 X-Rspamd-Server: rspam12 X-Stat-Signature: bhhz6ssrpkjg6bczkfkxbcptcnqohadw X-Rspam-User: X-HE-Tag: 1734076195-887194 X-HE-Meta: U2FsdGVkX19mg2cGux1nIafOn+z54MXWgGZ1V3vM+FA0z3k9OG6XlZUB2OeMwyv/Dff86V6/WcyzTbhIEHFybkA42HOR7tQDNxfWsz0pp/KfogzrzPaxhxPK+xBydI8xynxvqZQ3hJl/YvkIE7WOuvht6oZtzc+H03UJPBv1jPFyDq3aaHC4XrKKp9rA7cVfmYNP1rHLdJZtUu3PC/ppWwxe4gITTfvHx55fua+vJztOK7qtwRlPNfuXoUctkS3AhwXs/dtvOwYlwCEMxbPLblhQfxHUdY7qLcv20IfC0iRF20zGbB4aYCAx9ymcfo6DgAT6IM3jYRHTPL0KEGIEBMuhwgvBxGkP8zpNQjh7fn1aaMRQAPeJrxTlqDxMGWLRKcE0bc2/ct36ZWPBKQessMA/N1BERaehGdreExqNbvcCN4M46cnhvfMJKOIOw5TnaRC0Qq/YpAlbSZwmNAXjfb1zU5aRD03uw0L/N/8D65ZaVvREiMhGwtYF8n5Uh1oDle4knJ7ltoZ0I56hoKVLNzDKj9kiKjEZqzs4rSmoEwiaZJcZT53rtn+jtfj9+vi8rKls4WWb26FBq7J0FOvG1Y52zshchNccGn4neAxmeDdBZbmNYhsn2VBPQXk84TvyEI0p8PBUoDHAEDZYSb9pnUBLsJ+bRKgH2+4SoO4ge4dr0UD3NvCouYPA456VI0BPAsVM4qQLFGp4LdE3vwWlg93nAqpOX+2CpSQBy1XUvZ0bwtWKEScQ6RgrzMaLw46jFLCvxuJ3vpdF7ACia0uwZcwriCn3wv0EmV6ALQIs5Wx96IrjJRWC6qmSDjlsoURv1rtjZQM+h7sxwJ6KidHDl9IvwMnE5rFMp5ODabumDIu3bQYSb6k/kQJ5ZHGa2zAnEucgmjUpuj6nkJlPDv+f9AC4H2wF89JiKye2Gy445RHWnz/ZAkMXhq9KIlC8KqCk5NoOfZVyxGJEXkoNKo1 mjsYXHRz rRcIOJNlFyPdSM1Cf+O1pjyT16vc66ipsTVgu4L+XTuVUgsZ/Px1iNAMuyETC1rpVrFb4G6OYCzcqwaDfcxP4o1H1Wbb1QOJR12RRju76epDxKwU0/S6H2+mQCq7gUujg7gMs71QUDgXv44mh3P3WYbOjiGge7BlsSWHZQn9Of5cQMRlvddkxOxr8sKXTRKM768ECxee7WoqyueyZEDimdcdEEIharWpxkCi8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/13 12:25, Matthew Wilcox wrote: > On Wed, Dec 11, 2024 at 10:43:46AM +0100, Amir Goldstein wrote: >> I think this patch is fine as is. > > This patch is complete crap. The test-case is broken. NAK to all of > this. > Hi Matthew, regardless of the test case, the original issue is the ovl don't respect underlying fs' get_unmapped_area(), the lower fs may have own rules for vma alignment(own get_unmapped_area callback), thp_get_unmapped_area() is one case, what's your option/suggestion about it, thanks.