From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0462FC369D7 for ; Tue, 22 Apr 2025 08:50:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 412C46B000D; Tue, 22 Apr 2025 04:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C1D96B000E; Tue, 22 Apr 2025 04:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 262626B0010; Tue, 22 Apr 2025 04:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 080326B000D for ; Tue, 22 Apr 2025 04:50:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C4E9514162B for ; Tue, 22 Apr 2025 08:50:10 +0000 (UTC) X-FDA: 83361057780.15.3FF9D0B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 57FB8160004 for ; Tue, 22 Apr 2025 08:50:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EKE7G593; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745311808; a=rsa-sha256; cv=none; b=FVWfFV9PVUagyB2C+86dA/DPVwx/C8SjyBt62dTzTawNAuSASBP0DnxHSKXE5VUsgp18Zx Y2vm0zxNwW6nCv3XbO/YvvFt6wEAzyafumv88/PC/kO6JqObCISmvgqMQtItQXh9BGuPUe wx9/XXpc2s8COtPqeVNXVwIWbvOOWFI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EKE7G593; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745311808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z0fcTSDbZFobMICkC0Dhe3mC0DwS7Ydit7B1nvC9kvY=; b=3gjhMPAU6TENcbghFihWT+VF8CcppHs0MgATE+0HZdNIGOG2SLWfTm75Aidmo9LK2RObnc kDBziDMpSwKO754idzN8Mx3O3KmO4Kxf7ptGQL0IE+VOwgFNaK6W9OcjaFVP9uJN39rooT E+mDJFd2gLKKbdzA4N5b672UsndCfdo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745311807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=z0fcTSDbZFobMICkC0Dhe3mC0DwS7Ydit7B1nvC9kvY=; b=EKE7G593ORWs+3AjWjah1BFDJaFVFMgVOVzNXyQgRWh30hxrhasEp4IObpjMuoSi2+Qzrc GPd5gcWAHog4cygJamg42VviQH9AR3mkD+T5lHJmNpxkjFkhvjfg8X5tod3jUVtSR1jF6L RXj9n2EkKtgGP/GA1CcrkHd996krTLc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-F2usQfenNHuuRyeAw_DXsA-1; Tue, 22 Apr 2025 04:50:06 -0400 X-MC-Unique: F2usQfenNHuuRyeAw_DXsA-1 X-Mimecast-MFC-AGG-ID: F2usQfenNHuuRyeAw_DXsA_1745311805 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso35218595e9.0 for ; Tue, 22 Apr 2025 01:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745311805; x=1745916605; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z0fcTSDbZFobMICkC0Dhe3mC0DwS7Ydit7B1nvC9kvY=; b=JJ5mp0CfbOgi5gqHoACCuR/yAK/Ou/XvjU9ypD/KHi5v7ux3t3leNWi+j2xaSUUpp0 bnnx6vAPl/yXG/gQmxErBGQhuei6h4/UD/OHB01vC7sMvK2Rmcya2SnF9yvD80M6RiIC dZSd2pXbFdbeBooBqFXY5UOXHgoXIy48jXHO8rVRuPSvpDhxFaK6xTlyjush19pjEtjJ mrErQIPoqroW/iYnvITpKR4ET6myV3D7U0FJEaY4g/bad4LQky/EWSTSKASoucPeARh7 izArDMZ9SEHF3qtFfPbXuhoRI+HvLbel+rWYEbMylaJH6/yHCLktpuU9ioQd52/4NlOx 6blQ== X-Forwarded-Encrypted: i=1; AJvYcCV/F7uHsMPDYdPHK6KYc89KgwdpXAJD7rvwqv65aZ0pHUaKi4kD0KMB5IPEt4WBbHMS3IkmV3klVg==@kvack.org X-Gm-Message-State: AOJu0YxPbc3M3TjZzxzrvWVdX0RZ0A0NE3JWpqWhtMcm2tUE8P8AOQaK C8JI1EkdrdbgKNjC5juo3RclLccSq/16TFqHtccXKj4r+dvGmPm6IF4CZCmhZ1LbBQ8b1wiDD4l q7gjmCDX/3S0GaojhrGpOu/Zrul9g666mRpg4fqQFIoyAC1Ge X-Gm-Gg: ASbGncsopYFzyT7Zrm/QM5ylXrD94STstVJYA5Uh18ZkKcBudeWU0O2HlEpUFCrCZ2F 6RSHW+w/r5vMcEyUqjx/KplAKEu5HY4aMYDreOOZcJ/013Oia3QFztSuFE9+iXlyjQ8t9UiqeGD AyeXQj3vgrOTNQJwBnKPgG4NdYtfqJW9aYnsZp5MdywOuHuDAAQW2BymWsclnitVjxExa3pFH6X mzzXbeDYbH/SlUjqjb+itmId7ux0ZUzpLelvMDPeHlKVBGKm2Yff+iC7BUcsoJ1+Zo5Bwg/vT3u dqSZPfxic8j0Mx34pMtZOAO76p4S0nz7vUV6TxjiY+9c/xA4nFrIznV8rZRu3dbuGNkaJQNxFdX e1+9GAVmlYrAPdmJC3Pnpsm/3JckRC+u1lSjf X-Received: by 2002:a05:600c:1e0a:b0:43c:eeee:b713 with SMTP id 5b1f17b1804b1-4406abfba46mr120321245e9.20.1745311805254; Tue, 22 Apr 2025 01:50:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECr66G2BVj6iMCdSW6EqVysasyZkIUlqhuAbaMtOvHNydc9OHzsoJRl5icUzYIKQjhjTTlZg== X-Received: by 2002:a05:600c:1e0a:b0:43c:eeee:b713 with SMTP id 5b1f17b1804b1-4406abfba46mr120320865e9.20.1745311804859; Tue, 22 Apr 2025 01:50:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5bbc07sm167240545e9.17.2025.04.22.01.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 01:50:04 -0700 (PDT) Message-ID: <31ed0cc4-89a3-4f92-a611-06322c5d248b@redhat.com> Date: Tue, 22 Apr 2025 10:50:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] khugepaged: Refactor trace_mm_khugepaged_scan_pmd() to take folio instead of page To: Yang Shi , nifan.cxl@gmail.com, rostedt@goodmis.org, mhiramat@kernel.org, willy@infradead.org Cc: akpm@linux-foundation.org, fan.ni@samsung.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, npache@redhat.com, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net References: <20250418183920.273154-1-nifan.cxl@gmail.com> <20250418183920.273154-2-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: irLIbuqU_ZDtU-LfuLYh8TX7KcXbB24Zpb6mvHCECJU_1745311805 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 57FB8160004 X-Stat-Signature: 5t8jnonbde4pgaaaq61jwh9kmqpws71i X-Rspam-User: X-HE-Tag: 1745311808-961040 X-HE-Meta: U2FsdGVkX19x+bshl231Rv5F8GV9GUbUwi6wBRDJYgYWxsrMXmDt+Nt6KuvMX1NxZ8HZ1SWlq2FUh4292bSjfdbUSFTRghZ61xegk4CzUnCLXR3JRsF4RHwrIXrezqF2pxIM5cul6l2gWGQlc9VFRt1wHsFU1I9Qf2j7wLc70yCX6YUzNxCbl2mJNy7a17k0BC1Fg9LdynjBEoOt1qX4yUraUKWGrr36dgpyWlHlmO8sswvK9csSI3EzdeE5GArlxYaS6YeDIUZt6wLHpavTT3MkCRIyuwIru3RNJ10jvms0tXsO96pbCfCqHeVAyyja6S8T/iw8a15PZO1gEVhhQ3paEpT0qas22EUAOHboKp8uq32/yufVL2PKsOggTg8focul6B3oq/UJXGXOwtwS+/GGxW7y8XSI2TJ42UviO/zucKpW3TSzR3sMAbFDeXYFMOz40Q6T4sA0PLH5hWuFGJN0vdhjsf3x8wK9mxM224j3/mlQQunR5hBzoNJGEn6FlfL6H5t9yzhYXcht20EUU8QsqcUOZuJS2NkcoFdUzkv3Da/Jk2yup0oWUQG+j/YiXsYf1SWdDqnZEz0R1dLTaVcQcNZA2+N+RWrDiiN6b7K/8tkJzQtZmIJdmxXy/hzch6ytLtTGqt5UO5oG7TmYDU94OJm2a2GHKc2t4xdNL/Z8PV4exccHhQYGgwIClrUAMj4UOb+Y8szzFRVirGecrr8HA72F0qgOreKkgzUqtuTTG/4Sj/0kxOfzB9KE4bWl4OxQDLeIDysyFGBj+0RjvpTaBXwFocUYm7yPdtR6mO92q3LS1CG9l/JfvbGxK9SfrnL55b4vALqXeIBpgmxIh8NsES0CynPgdyUnVnzlApWZZS5fJPVXAk+8u9gdwKq8oNIW2uqg/5GgqxIQYaC3OBUyjeqkK64Gqa5peCKSuMpQd+1kHrm0L2WwgnhZMXDv0TR58xftCFtwMg8I3BT XaybaD1s KphD4TzST+J6B0V5VGq+ZW91R7l35sFo7xSnMpcUDSQ4G6nMIyUq5vnlOEqYCQIHf0nz/wC6jy7n7IobUALTl1NrkgROmIk5+RF7pcR/12DeRNePxzIwaouF04vIHZowwb8H+PvW/zmMharu7365HlQkCKxJ9OlzRt2Flk+JoB9W/H/RleEDoDttNG5JFTXzhoYjury6o1j+GcsHvR0/vo4JI37jKSgMIwUyWYAJCRMIYKDgYo2kDHd+sHGptlbvXnupGaIZ8CnTJ5bZaQxAvfBffwNMqKgzdhZqfGURwfqhD7dX5tAcC8KoBEk1U3gG6nlfk0r///CZQIuW3otAn6KKi3nBOGRzUH18Sc8LFSSE66k0tSp+d0YZ/cvzSJUOQG5ZWJuQD7KrP1llfYcGILSrQsHImxaj2t0o5hMIYMWdc6quQWwzqSKGvxdcD9nSqruhlbdqlhmtyvJZ84p08Td2v8mnUB8IH0OEuKD4RfY7cv7eUxJ5XD02eej4Fb3HOO6kMVCcPBgMPz/MAHgcpqHKLzXwFuImFYhA/j/f0qMGrFs7nEfvUx0AozfLmtickSUwMCdSak6vDP52u6APc0MPrU7lMgo45aLN3tC/JNAYND7BglW2Fn3ErC1q2RxBMj9jyHRdgPss9TGPnReEONpKa+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.04.25 00:40, Yang Shi wrote: > > > On 4/18/25 11:34 AM, nifan.cxl@gmail.com wrote: >> From: Fan Ni >> >> trace_mm_khugepaged_scan_pmd() is only called in >> hpage_collapse_scan_pmd(), where the head page of a folio is passed in, >> so refactor it to take folio directly. >> >> Signed-off-by: Fan Ni >> --- >> This is a new patch added to the series. > > The change looks good to me. Reviewed-by: Yang Shi > > > But I think the two patches can be squashed into one patch. Agreed, something like "khugepaged: pass folio instead of head page to trace events" Acked-by: David Hildenbrand -- Cheers, David / dhildenb