From: David Hildenbrand <david@redhat.com>
To: Yang Shi <yang@os.amperecomputing.com>,
nifan.cxl@gmail.com, rostedt@goodmis.org, mhiramat@kernel.org,
willy@infradead.org
Cc: akpm@linux-foundation.org, fan.ni@samsung.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mm@kvack.org, npache@redhat.com, mcgrof@kernel.org,
a.manzanares@samsung.com, dave@stgolabs.net
Subject: Re: [PATCH v2 2/2] khugepaged: Refactor trace_mm_khugepaged_scan_pmd() to take folio instead of page
Date: Tue, 22 Apr 2025 10:50:03 +0200 [thread overview]
Message-ID: <31ed0cc4-89a3-4f92-a611-06322c5d248b@redhat.com> (raw)
In-Reply-To: <d987a374-c83b-4067-9d47-62f3b758c8d3@os.amperecomputing.com>
On 22.04.25 00:40, Yang Shi wrote:
>
>
> On 4/18/25 11:34 AM, nifan.cxl@gmail.com wrote:
>> From: Fan Ni <fan.ni@samsung.com>
>>
>> trace_mm_khugepaged_scan_pmd() is only called in
>> hpage_collapse_scan_pmd(), where the head page of a folio is passed in,
>> so refactor it to take folio directly.
>>
>> Signed-off-by: Fan Ni <fan.ni@samsung.com>
>> ---
>> This is a new patch added to the series.
>
> The change looks good to me. Reviewed-by: Yang Shi
> <yang@os.amperecomputing.com>
>
> But I think the two patches can be squashed into one patch.
Agreed, something like
"khugepaged: pass folio instead of head page to trace events"
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-04-22 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 18:34 [PATCH v2 1/2] khugepaged: Refactor trace_mm_collapse_huge_page_isolate() " nifan.cxl
2025-04-18 18:34 ` [PATCH v2 2/2] khugepaged: Refactor trace_mm_khugepaged_scan_pmd() " nifan.cxl
2025-04-21 2:54 ` Baolin Wang
2025-04-21 22:40 ` Yang Shi
2025-04-22 8:50 ` David Hildenbrand [this message]
2025-04-21 22:38 ` [PATCH v2 1/2] khugepaged: Refactor trace_mm_collapse_huge_page_isolate() " Yang Shi
2025-04-22 8:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ed0cc4-89a3-4f92-a611-06322c5d248b@redhat.com \
--to=david@redhat.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nifan.cxl@gmail.com \
--cc=npache@redhat.com \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox