From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDF9D4979A for ; Tue, 3 Dec 2024 09:33:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0277D6B008C; Tue, 3 Dec 2024 04:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F17BA6B0092; Tue, 3 Dec 2024 04:33:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB8306B0093; Tue, 3 Dec 2024 04:33:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BD5906B008C for ; Tue, 3 Dec 2024 04:33:33 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DF923C07D1 for ; Tue, 3 Dec 2024 09:33:32 +0000 (UTC) X-FDA: 82853134812.11.C5501DB Received: from flow-b2-smtp.messagingengine.com (flow-b2-smtp.messagingengine.com [202.12.124.137]) by imf02.hostedemail.com (Postfix) with ESMTP id 1B72E80018 for ; Tue, 3 Dec 2024 09:33:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm2 header.b=WvAQLTs7; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="i XnTSKv"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf02.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.137 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733218398; a=rsa-sha256; cv=none; b=k9SR1wugaUgVHGGY3TJoJsaNeuBA6k3eDq8VewnpC8DiQPEjNecqqC3bouBJcktXRMyohs hLz7/bU5py30X5ZJ7TpoF/zKg1GDYAjpFSvBb939eokgY+zNRjkvKDHnbkbMFyeVgrG2hM M3+X5xuteMCZ1knP+VPUXgbEt9d1sO8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm2 header.b=WvAQLTs7; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="i XnTSKv"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf02.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.137 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733218398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xJ2Db/Ov44qvxA3KXnEDiMcsG53llto9u0HWU/q9HkQ=; b=00b/Y5hMAO0pILSqkPXDfvX7hsVJw9ix+eSLkJsE2UuKsA2+woPO9g5LyYr48ewEEnET92 mDav7C3kEaH7N3HpowAxl2Hur98vfDF0CtKv4AXjGN6fRO+YwV41C8rHIirrrcOM3mxuvA akWuzKcO6CaMNoJse78fNsetA1cN6lo= Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailflow.stl.internal (Postfix) with ESMTP id 8B69A1D40959; Tue, 3 Dec 2024 04:33:29 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Tue, 03 Dec 2024 04:33:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1733218409; x=1733222009; bh=xJ2Db/Ov44 qvxA3KXnEDiMcsG53llto9u0HWU/q9HkQ=; b=WvAQLTs7qmbrdJoKTR7pT9Gk0X h8Wt+cN8Eigwdz/zwoocQWTRceUGUqzpLzMDvdMZD2blBS9yqi5xPJJ7kn77hbuM S0N2gd4UXEwndzrM/3d4uXRCcuGhkUKddRaOJQe83quDf1qVd15gTa2kzPxhLSwG AAqLw1ThH8Vhw1qyeLPFfdkjhD7HJbPnpLHkufhUReh45+jVSgYUxntuUGyN2X4V bThU0mpQ+V7dX+1VgJujgrMgkm6WGkF8VOJ6j3BenlnlRB/YbH02DQvu4HJGo37R JHdJnjLoWa/U2Dsgq8vkyfa0qxtnqjJ+fjzZzUSqfAhjx2IRZsXJ8HG7CycQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733218409; x= 1733222009; bh=xJ2Db/Ov44qvxA3KXnEDiMcsG53llto9u0HWU/q9HkQ=; b=i XnTSKvtGHIpxehz+s85uxS1tTOYzjr1V1erjrk4LyK8OI1X16CrO+iW8MlL8aR4F sLeL7cUtJAlQDrsqE4WLu/fmxblT+a0HTSyfQcRv9FHuJHGKHn5tcIB0t1udgW/N izHwXOrhxXjRArHGY1GVkZqqTT15LISIZz0FDre9Z5cC+xavQxVdRSXFPumP7OnS Han8EOQVVpm/XaFxPNwT1lNLgtyH41nb8tyT7e7li95Ybf3ZnOce3eWiVKJtD0fv rPw7XbjBA3xeLShRERRM9Rw4M+3XKnq2Fe4WUb659cl0EBzIzFJ6LxKLpS/IX6D2 8OH5iLEQ+4gS8EAJhO/OQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddriedvgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddvjeen ucfhrhhomhepvegvlhgvshhtvgcunfhiuhcuoehufihusegtohgvlhgrtggrnhhthhhush drnhgrmhgvqeenucggtffrrghtthgvrhhnpeefffdujedtleetieffleehjeffudetfeeg hfdtieeiheevueeggfeuiefgvdekvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuhifuhes tghovghlrggtrghnthhhuhhsrdhnrghmvgdpnhgspghrtghpthhtohepvddvpdhmohguvg epshhmthhpohhuthdprhgtphhtthhopegsjhhorhhnsehkvghrnhgvlhdrohhrghdprhgt phhtthhopeholhgvghesrhgvughhrghtrdgtohhmpdhrtghpthhtohepphgruhhlrdifrg hlmhhslhgvhiesshhifhhivhgvrdgtohhmpdhrtghpthhtohepphgrlhhmvghrsegurggs sggvlhhtrdgtohhmpdhrtghpthhtoheprghouhesvggvtghsrdgsvghrkhgvlhgvhidrvg guuhdprhgtphhtthhopegvsghivgguvghrmhesgihmihhsshhiohhnrdgtohhmpdhrtghp thhtohepkhgvvghssehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrlhgvgiesghhhih htihdrfhhrpdhrtghpthhtoheplhguvhesshhtrhgrtggvrdhioh X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Dec 2024 04:33:21 -0500 (EST) Message-ID: <31d48f53-eaf0-445e-b9e3-7c56070ff6ad@coelacanthus.name> Date: Tue, 3 Dec 2024 17:33:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv/ptrace: add new regset to get original a0 register To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , Thomas Gleixner , Ron Economos , Felix Yan , Ruizhe Pan , Shiqi Zhang , Guo Ren , Yao Zi , Han Gao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org References: <20241201-riscv-new-regset-v1-1-c83c58abcc7b@coelacanthus.name> <87v7w22ip6.fsf@all.your.base.are.belong.to.us> From: Celeste Liu Content-Language: en-GB-large In-Reply-To: <87v7w22ip6.fsf@all.your.base.are.belong.to.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 9cw5k44ou33j5q34zpbnysixjy4tw7bx X-Rspam-User: X-Rspamd-Queue-Id: 1B72E80018 X-Rspamd-Server: rspam08 X-HE-Tag: 1733218385-869978 X-HE-Meta: U2FsdGVkX19plJgDXEVJsNJ3hQwoVU0hD3yXl+ncrTEJh+BVxgJqWEptC06T7Oj1Q4V2Ewz0JT0kI+FL+2R6cCdWOnnLrXwyv2K1prqnyGCntSQ98JmggEyAIN+12PsFRuW+GQiwP5SzLgxycmgTx3IrLfVpfBSCVm0oRtZTmU6Mr2RccKn2Kix8J2bQa5CRdHQeJHW/Kz8wTTJAweEEzAhYGeROUwYkL6L02Kc8PyC4dqZWICpgN5sGyNiq7wPgw0uM4qwHGrBC5SRWjT64BMoHujJ7dY6948Wu8fQApEe4olugws2zuWOOEqh4L3Ct2TtHm8t7572QyQQET32ons1Y37SlqYBVnYEySaxUqHgdmquwAK8U2fFYtkpPjfZBA7ddTC6XVrPFy9qQE7U7OGFXqS5rurD5eQnvMn2InMk0LK4lA5/X4l6Dh3KirpEhZ2370m5tQ4a/TmycqFMX5s7Lmg7TjtE+0uyiqWE63E5aw0LhPG30jhSCTDQRbZ9oXWkV6XdARDb+MPpUgWstiiya2GLclTmWe05/4fSPzQXyGToUhiFNCDVYPI+UHiPE+4Vy8LQ4y6pqD7N90RASRTLJTv1orQtJ+dOui2Y6uKOVBZP3uW0PZlhSUvltM7XdZ/FtGIC7YCu/srm2A92xmny0PzepNtFemGea932+LGDS2oBBckqh/tQ4K85Kv7t+olMQnCbSbQFXjJXpJ/TZc1VonMY73QBPBC/SQ27CWkvzzrrZa4nGmn+7q5tGUFbNpeLcKLRAXuIsecjd2aTsSS4IgJkkbX0VWKpM9beg8xHGtDl0WdXRRyLS41mYLgF4iVCij48f+pFXJhfz2fJgR/DEtuzs1W2gWiLXUmC1QKF88uV9jNJnA6NwN34L5xfb3C1n/lOPI9htTn1EbJo1euN18Nb8xVSL6RcPMzEbpenaDVYI5NBW5Mx7xp0PDTZn2Wga8RkjWjeSsocgK1k PqfpOBId jx1kUHs19eeIasltnSbPN8FvemDVR8ZuqgGKIDTj66diJe+1yi9+f5jQ/dSMSwwwjxVdUxdk8Lv737f2EH4qekDILnLQ16xCiTwbkP9vEgZoircdA8R25JhbcaMmv4dQn3RDOFT8S54E1WmRdvOMISynm1H03GVYJgdY4doaZPcvSciZU1hEHBcBCfq34cBjhtdBo9E+mMytmmeTd/Som4ddX6iO1+wdKCflCCG/+ZZcQ6/UM6kthoE4jWcCncS2pNzXtIs67X6WA8K/6QSynEt4281ujsSIMAH/4twwKhwgRL8yTJNTiCc8zsA8n25B3hJFoFKwidbhaHdNdUNZ7uftFk8YQl5dbvi4g0zU+N8NVCjY+M4n4dVQ13MYm+wVqdpiH4AEQQXdacqlS0dKZKbGO2SnIW6eGy/GHGkaxuzmu/hA95oYEr2jAKenFhStZnzLMs4/w1J9rk21XoDClL2W3F1Tbdy5pwpwlbKcvtSFsz8h9OVL/9npDMWxKYmTpd59iq+TewHG1NRp+q6zNXWwRClsUofkswK/GanZ7u0+kPMMKFFWajCJabPXPac1Y0JiZxD4jvrRvK4k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-12-02 23:44, Björn Töpel wrote: > Thanks for working on this! > > Celeste Liu writes: > >> The orig_a0 is missing in struct user_regs_struct of riscv, and there is >> no way to add it without breaking UAPI. (See Link tag below) >> >> Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to >> access original a0 register from userspace via ptrace API. >> >> Link: https://lore.kernel.org/all/59505464-c84a-403d-972f-d4b2055eeaac@gmail.com/ >> Signed-off-by: Celeste Liu >> --- >> arch/riscv/kernel/ptrace.c | 33 +++++++++++++++++++++++++++++++++ >> include/uapi/linux/elf.h | 1 + >> 2 files changed, 34 insertions(+) >> >> diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c >> index ea67e9fb7a583683b922fe2c017ea61f3bc848db..faa46de9000376eb445a32d43a40210d7b846844 100644 >> --- a/arch/riscv/kernel/ptrace.c >> +++ b/arch/riscv/kernel/ptrace.c >> @@ -31,6 +31,7 @@ enum riscv_regset { >> #ifdef CONFIG_RISCV_ISA_SUPM >> REGSET_TAGGED_ADDR_CTRL, >> #endif >> + REGSET_ORIG_A0, >> }; >> >> static int riscv_gpr_get(struct task_struct *target, >> @@ -184,6 +185,30 @@ static int tagged_addr_ctrl_set(struct task_struct *target, >> } >> #endif >> >> +static int riscv_orig_a0_get(struct task_struct *target, >> + const struct user_regset *regset, >> + struct membuf to) > > Use full 100 chars! Linux code style prefer 80 limit. > >> +{ >> + return membuf_store(&to, task_pt_regs(target)->orig_a0); >> +} >> + >> +static int riscv_orig_a0_set(struct task_struct *target, >> + const struct user_regset *regset, >> + unsigned int pos, unsigned int count, >> + const void *kbuf, const void __user *ubuf) > > Dito! > >> +{ >> + int orig_a0 = task_pt_regs(target)->orig_a0; > > 64b regs on RV64. Oh, my bad. > >> + int ret; >> + >> + ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &orig_a0, 0, -1); >> + if (ret) >> + return ret; >> + >> + task_pt_regs(target)->orig_a0 = orig_a0; >> + return ret; >> +} >> + >> + > > Multiple blanks. > >> static const struct user_regset riscv_user_regset[] = { >> [REGSET_X] = { >> .core_note_type = NT_PRSTATUS, >> @@ -224,6 +249,14 @@ static const struct user_regset riscv_user_regset[] = { >> .set = tagged_addr_ctrl_set, >> }, >> #endif >> + [REGSET_ORIG_A0] = { >> + .core_note_type = NT_RISCV_ORIG_A0, >> + .n = 1, >> + .size = sizeof(elf_greg_t), >> + .align = sizeof(elf_greg_t), > > ...and sizeof(elf_greg_t) is 64b in RV64 -- mismatch above. v2 has been sent. > > > Björn