From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF24EB64D7 for ; Fri, 23 Jun 2023 12:50:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17ADA8D0002; Fri, 23 Jun 2023 08:50:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12B248D0001; Fri, 23 Jun 2023 08:50:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35698D0002; Fri, 23 Jun 2023 08:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E29D88D0001 for ; Fri, 23 Jun 2023 08:50:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 92B261C8F9F for ; Fri, 23 Jun 2023 12:50:54 +0000 (UTC) X-FDA: 80933997228.21.C41319D Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 7FAF620012 for ; Fri, 23 Jun 2023 12:50:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q524DUGT; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687524652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3J6qedKH7rACUI+d8+QjoI1iru+7/a5M9lap7RdXq+s=; b=YpSn1Ay9bCGqxYramXIh69YtoXbytYh9rqBjg2c+RF+kFQ4JtkItj+Z63eKVxzkjTUgkZb P3BN6tByH2+iiYOomky+sbXqOMrIQ3JXeq+JJBlaabZeghd69608CojvMao4Zy1inCegi3 gb/rw+EvP2O0fq+k5eUI+VAjNyHcE5I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687524652; a=rsa-sha256; cv=none; b=stQoexGbRLxQ8fmAifEREXhvFQsG0DJZ/YKTIinZLqlyac7DCjkNZtZvxEH3SXNRsvnmRg urk/bH02lYE4bGiwP0fmgyBRqWz1VlL2AEn0U3GhYK9IJ4zkswq6/M/rqEZ2EubVLskrLo 7sclez0ym1MFgDl239DKlu20NSQajIA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q524DUGT; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-66872dbc2efso106261b3a.0 for ; Fri, 23 Jun 2023 05:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687524651; x=1690116651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3J6qedKH7rACUI+d8+QjoI1iru+7/a5M9lap7RdXq+s=; b=Q524DUGT6itGV4gw01qJj/zWbJLa4vy2WCXqnWOngK0C3q+dq5EKhIS0CVZv0oxxho LJ6tY9YfoIHNM/tflF8trZPv/Spx8OYgEAYGDhp6iajWSx+dfQpGCxtVSU4j+uchKR2K 6jjaYk2avrTfJwxxTgNPxH+prD4PA2RYda//8FNhgDDbtNG8gCEmPUtJ+VXKPa4DXVej a5KLbc1PmFNVMjg9t+MjU8GHA1HEy3OLaOZU0A/n71b/fjkikDpbyETS6JPqwOfw6qlc 81KayU6/lII4/pSrE7vPjFTNx81tmGljnxk2j498q4g7qxCoplXlCdPQ4N13nBnNs8tt 8JpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687524651; x=1690116651; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3J6qedKH7rACUI+d8+QjoI1iru+7/a5M9lap7RdXq+s=; b=Q6ortdJujeiXGa+YLQanLhyacXxshw4dX/XPKhHqr7cUr/R79SwOifAC0GT1PqrSmf wJ9gjgKQfeA1+nBrPX7pCEcZA3DaKpBUQLfJAFIEJ24rUOeHXNiHs0fVAhZ/Hi0bJ8JK zYoZ7RQ7DXf5bQODiwd59iBDNtMEG+3SVCH622yTHn6Qw+UAz9RWLBZH84N574sA/XO/ FoCCEbnlfRPddtES/bRlQDei8Avy8HQgz1u4G/ynHRHOcFdcO4OTt81x6zRD0eNErj9L gyO6S7+KoyJVeMksdXnjxRUL9Va/MhZbwrAYNo1dTg9/WbRW0C6uDxf+w8ZiW2/dBXuF +l1Q== X-Gm-Message-State: AC+VfDyrlGh9lIwx1Q3448e2JQI5n+V/YNSz/iV2IA3aqyBlf7+/OCCq ID71oqAtGLsUnYzMEo5Mje5qkw== X-Google-Smtp-Source: ACHHUZ6Fjrszr4MOiG7PTx+CVGVeY59XJZwzJifNOvY5NLzJaatECslqahuGwHQe8HJSyn0Dmf/QQQ== X-Received: by 2002:a05:6a00:3186:b0:668:7fe6:c220 with SMTP id bj6-20020a056a00318600b006687fe6c220mr14325912pfb.3.1687524651198; Fri, 23 Jun 2023 05:50:51 -0700 (PDT) Received: from [10.4.168.167] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id x21-20020aa79195000000b0063a04905379sm6063171pfa.137.2023.06.23.05.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:50:50 -0700 (PDT) Message-ID: <31d3f685-3017-25d8-5b0b-2795ed7049bc@bytedance.com> Date: Fri, 23 Jun 2023 20:50:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [External] Re: [PATCH 01/29] mm: shrinker: add shrinker::private_data field Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-2-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7FAF620012 X-Rspam-User: X-Stat-Signature: 34jqe8qdx3qz4dsphhexmmh5iquip1a4 X-Rspamd-Server: rspam03 X-HE-Tag: 1687524652-523197 X-HE-Meta: U2FsdGVkX185k7IhuuIDJq6ApLm3giVYIr+toSs/gBHub/MNMEPdw8nSrCAobdYk7L8zJksWC46iK22y5cqygrkNTpz0ZkCh1hC0PZVdrcifH2kf+Z264UpZEQDK1KuMCbCe5e0kfCJoyzpFcap4QwQsmLQFzSSgRkn/fAkTRGianHzfrUliuc0w1u4leEQ+WSFuzbPp3/hMY0teFdn5f8ViFMmuyOP6yLg5kLYhfesXQGfzOTMpvLIr9P/vNmtXUJl/r/tCXJG+gNEFWDoN5wkleJ1bpGEGdIUkZT6IxOk/eND6cX9eIcVjK1f+twf2mKyt58tBwrVrp+nO0dFjbKBETZQJpSKs2Q1gXfM3aLZMVHWJ9iazwm4kzBklUtuTK5TaGkRKamjI/XS326fDZ2kKwkCHPPNGl93Pa2JVGWSwcb0KDABE4jR7/DWlFeNcmUvgtEX309fAgW3QqnX8NHjg8yE8w1EBIAPAfM0ejCMQWaFYBQLuP2ip9htmWaWLFK75o6J/OdjH8feIJsmmvRgvNcxlphuBkSXSRtXmDCn1TnlJtZsUNfwQcrMN+QJlA9CYlLwCPH+9Ov2oV0xG2MWbZDhJE9+/pnuIXr5kxJxXGxf6AzsLLFtcKYSYAgtFB00UIOahrQ1pApyRY+g6E+OVnG4wxr0p7sD1F2QvyRaRd/g8RhDMfnyxFBQQw24T8TXTsh7SAsL7P1l/WUW+TpcECtymTOjoNsAmZBxK6kW982ksr/5xFCzRbfnzAw6hAS0iN0QiugYgjdl8Gz8KzR+ehfcWRFCeqQoC6Yyd+N+CArud4GEuK1QvIAXjWn62/L4ym99LgI+q9ZW/eJYjqjaG1pZVdbnNRjQXWgfqx+SZqUS/G2HXsW1q9RBagSz1yWvQg8iITLGdSkiM7ax6Sul1dsk/HFKZbfoQwd8iGU6G13KkHmNSC+HxU0kj5c11nJE12GNOgE94J89If1R flP5AXQt qOcmT4Qm4cEyB9n3R+xp5fOzK/Yb1IFF9CkvaqTmOfoMZWIAtS3STTfQYx4Mb8l41Oazy9j89Z1jt69m0WdKUPjyaCexR24nKJ/o71Q2bgTPswFUm2kYQbTyPakOfFdvqf6vmUqr6qzLcqnp+877aoJVw4BnyjoQD+cpkV05bOiBymxzK+H7Z14ZRCIYl+IlANXtRpGuKljIMqzWJ4QmtpBdJZlTtcaJnMTFrIJ/EmkuNcxyZQnc0sTMUTScZZC4Ufcfe9Lk8Xk7z5u8HoaOHF625gA/mXYadS3+sq77HgNmqZ3VLWOxy1Ybzv/UVpyvXMFiLIbqKsDTNPMBpfAMePZtxYiHuhgXfCBqcsQ7hMjpjqLAJndwYBYmrNq1d2xQR55xtvNDoA/gdN7NzbYXW8jU+UwSvh7hXkgU+/mgujlQPL7dtWwMmVXW618rvkzAm1CnK8Z3fkTqToXxIS6QYyMsnqH8fnXfNkjPp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vlastimil, On 2023/6/22 22:47, Vlastimil Babka wrote: > On 6/22/23 10:53, Qi Zheng wrote: >> To prepare for the dynamic allocation of shrinker instances >> embedded in other structures, add a private_data field to >> struct shrinker, so that we can use shrinker::private_data >> to record and get the original embedded structure. >> >> Signed-off-by: Qi Zheng > > I would fold this to 02/29, less churn. OK, I will fold this to 02/29 in the v2. Thanks, Qi > >> --- >> include/linux/shrinker.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >> index 224293b2dd06..43e6fcabbf51 100644 >> --- a/include/linux/shrinker.h >> +++ b/include/linux/shrinker.h >> @@ -70,6 +70,8 @@ struct shrinker { >> int seeks; /* seeks to recreate an obj */ >> unsigned flags; >> >> + void *private_data; >> + >> /* These are for internal use */ >> struct list_head list; >> #ifdef CONFIG_MEMCG >