From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6634CD339AF for ; Mon, 28 Oct 2024 18:11:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC28B6B00A2; Mon, 28 Oct 2024 14:11:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72826B00A1; Mon, 28 Oct 2024 14:11:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13786B00A2; Mon, 28 Oct 2024 14:11:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B34F96B009F for ; Mon, 28 Oct 2024 14:11:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 469F6120CBC for ; Mon, 28 Oct 2024 18:11:40 +0000 (UTC) X-FDA: 82723803414.05.80D2DCE Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by imf20.hostedemail.com (Postfix) with ESMTP id D51BF1C0006 for ; Mon, 28 Oct 2024 18:11:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=ZgpvCfWo; spf=pass (imf20.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730138888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8p+XeF371FBdizlYdFFfI+9cvX4PxDYJkCjxcGvOnbA=; b=oxajC1EYexD/yTnJMTJk7LaCfCKtIRnLr3IoglKI7pIKacWGYvjllBue1BZUmq/0nK+zSG YJV0GIFUWa2vlV9Hn15RoYxyojr15CG6zCCAM/dD1znVLlOmWYxjFyNAL99x+/JzpCT/xq AicM62g+qQw4onzU9in911EFR+0GUVQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=deltatee.com header.s=20200525 header.b=ZgpvCfWo; spf=pass (imf20.hostedemail.com: domain of logang@deltatee.com designates 204.191.154.188 as permitted sender) smtp.mailfrom=logang@deltatee.com; dmarc=pass (policy=quarantine) header.from=deltatee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730138888; a=rsa-sha256; cv=none; b=y47LVPT/fMQDa5qohhp17DNSmVZ3oxHLmcbb+MH+iXB5yRjOR4+c4J8ScnE27O1MeJZdMT f7sTzeAE6AaLSU6d/TdqrrITdGBSPIw9+Xli+YxrlRS2EHAvsvBfBTKwxUnEhKR9DA3AlZ Ymrf0mC9XlldLWL4ZEqhw8Ek9p2d92c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=8p+XeF371FBdizlYdFFfI+9cvX4PxDYJkCjxcGvOnbA=; b=ZgpvCfWocWsIQTbiuMoGgvu81j S/fCHcyzInt5f0gPKd+LIK7OJ5mxEaoNwY3if96O+eQaCdejZ8p5V3sgl/v9nalWlDJO5DRXi/kIn wvHhSbq4aAwqMIMsOMusADIniYrFBNpOPovhNcwteIj9k4BUkv8XY28rtPNRm9woscrRzWxlXqEZb x/tnpblDzlq9tceUkjNsArDEQcZsmuRZZSVXzOBFycNxqU3EB7/U9E1zPZg62v7QNAB9eXmVwn9dD fGPW5l7LzLYo6jMaIh+Joy5PZ/qKbf8+LukxoA/IHSVyQYhrFtbPf9diRx5yqeRINUUkSejoMIZIj 4p2sRADA==; Received: from d104-157-31-28.abhsia.telus.net ([104.157.31.28] helo=[192.168.1.250]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1t5UCo-002ZVS-20; Mon, 28 Oct 2024 12:11:07 -0600 Message-ID: <31cae8da-74fa-4a45-a88f-ad76572246d4@deltatee.com> Date: Mon, 28 Oct 2024 12:10:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: Content-Language: en-CA From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 104.157.31.28 X-SA-Exim-Rcpt-To: leon@kernel.org, axboe@kernel.dk, jgg@ziepe.ca, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, bhelgaas@google.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com, m.szyprowski@samsung.com, jglisse@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 01/18] PCI/P2PDMA: refactor the p2pdma mapping helpers X-SA-Exim-Version: 4.2.1 (built Wed, 06 Jul 2022 17:57:39 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D51BF1C0006 X-Stat-Signature: 4u8ucpimhsneeiynf667nwsa66m1xwej X-Rspam-User: X-HE-Tag: 1730139068-157696 X-HE-Meta: U2FsdGVkX1+yFov2dsMyRJtrgRA0kdl1bQ+isP3TVeldsHC9D62oN59tJkFQf0IhLVTAkV40FEGuc6LZ33uDtt3JjoOV9WvEveEtx5lE2aYuNi20NHit4G1shEhZCrI2wGd2J4zw6PLaQAOmwWdDB5qqNBAhMjmH5JU+15YjFpL2O6qAXypcLSoSle0YYIg3d6+UlXYWTVpYExDqMYhwGvEeN8E+564hLzsqV5/QxmcliqdKpwzFAQoIcwGP+jICOXuuhE1NM/cw0r2bZjpLrnfZ9P/BtBsU8OfWlz82OXDEqHEK2DDA+gJouQwOBM14E/BbOuFdYsTpsbGbDSMZjVth4+nhHO7JR+jMEfzwmD1InPXk79xZtH6uNnlyiL1IoIDU/lh8cbHmcky4xJHtlKQZXHRUVos8Fx15zwaRhu4IbdDofLzco5cVFDLuzjcnkIelVMAQ9O+8xWGG+unv1L3rXbCzfyqvIXQfzOnEwokTFI1JM+mD75ryATir+J+0O1gL0M3jRe5iTOdKOWSfe/OdSkue1JJ/sqzN6XASIFtEuvQoccPt0T570B1R2mZF8ZyqMjbXfSjGKpPn1NxhgRBdvxC0ogkAclfnhZHXManZ3Oce2UZiJQqZJvEYzLnCgTkjk8H35rmGV19jIA2gkuYhSjzcD8YlVzZPBUXRUHhsTI6DvAQTI0VTcNHZEXIZBVPuF2w2JyUj5HmJDGPAUPiq2IA3EnFtHxhoeD5hSGLGjNH0ERBnRsPQ2b2bx5dNqHVN8zkPhCIrmDgLiqYCesNLtfBJUc7qigygejju4zrOzm+yBlIHSHlVvKZgMIZFwQ1Yr2pkwXK8050x3u2b1P4YT2G+g2GgXoGg3TWRCu6zUjkcIOeKVD2zVKiPoNLQgSYwC9RKM3WDUL7NKQu0iyeWLpDyHgv12wDmX4GxFHSt0ltrC9JEJn86YRJ4DZ+er8FnYxwNMRGSsH+oGvZ WcyMMDhu zYQq841Ue5qxjR9SpMz7HVKvXtkYnmpNfJsDx4u0XQskWqPcQVVj+pn1e5dpwZ5yIoFI0tNEMJ5+781e9QpbQa5Wh2daKxz38ewC7guDN/AHpzw7derse6RzTBP7lp1wIHCPnGxIg4cZ/O38iFBUW2gU1ty4y9mdwEOu3A6PRYV9ozZXL+UU8TiaxX++033sWMWF9iItSxEZg3lItVHKYfCLVRAVUxFlmvqz8EFLwqNO1ScmMOEgA1RJ/b/mqB++iX++dinD2OBRrJArSUg/TNmMJmFa/GhCjAftchpqZ8RHyLr5FTwP5ByXZRVGkjb5D301WrLZL4CcwPq5dnBSuSW0ILV3pCuqXv5FxZGI/0jwpFAEnCFzWmXGgRe2CNiEbJ1mK9aA5Hu+50dnMksY7B9xVZDTCS+eUPE1Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-10-27 08:21, Leon Romanovsky wrote: > From: Christoph Hellwig > > The current scheme with a single helper to determine the P2P status > and map a scatterlist segment force users to always use the map_sg > helper to DMA map, which we're trying to get away from because they > are very cache inefficient. > > Refactor the code so that there is a single helper that checks the P2P > state for a page, including the result that it is not a P2P page to > simplify the callers, and a second one to perform the address translation > for a bus mapped P2P transfer that does not depend on the scatterlist > structure. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Leon Romanovsky Looks good to me. Thanks! Reviewed-by: Logan Gunthorpe