From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C2FC433F5 for ; Mon, 28 Mar 2022 07:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B56F8D0002; Mon, 28 Mar 2022 03:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 465948D0001; Mon, 28 Mar 2022 03:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 353F38D0002; Mon, 28 Mar 2022 03:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 272C58D0001 for ; Mon, 28 Mar 2022 03:33:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B798122D37 for ; Mon, 28 Mar 2022 07:33:55 +0000 (UTC) X-FDA: 79292980830.07.C2B2B73 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 0010540038 for ; Mon, 28 Mar 2022 07:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648452834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z9XZp52oACkgIKoqkexoluVDy/BwEPxs39tIximHMiw=; b=iOZmXL+8a7mu3WfPxQQKIlE1spUMk3Jwb4f8vldhY7DE8MVIv4BvUT3+8bGVzmPb1LmgcV D4U6grrpznpCsHGuym6B9J+P3Wn6bE7FWnuuD3iGDALxbbJqRyVi056EogNtVJFFbiICfg I+ehuOHoo1sfXk3pySjcBSIJG+0fSNM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-rbeoFXkMO3uniSfFRkzXvQ-1; Mon, 28 Mar 2022 03:33:53 -0400 X-MC-Unique: rbeoFXkMO3uniSfFRkzXvQ-1 Received: by mail-wm1-f69.google.com with SMTP id t124-20020a1c4682000000b0038c8e8f8212so5135756wma.2 for ; Mon, 28 Mar 2022 00:33:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=z9XZp52oACkgIKoqkexoluVDy/BwEPxs39tIximHMiw=; b=miDkczRuMtdb3NCV1DCbPsBqNcfHB0oMnlb9f3uzHF1hSSk9rRLB+/iSUYQLgW4cMu chtpWPzXn2lptgtayySZjDXLd5bjfsRVf0QgfMTtynYzGOJFz7ehFYmTCxIsP4gheZBi IMOzfpJElCTxlcBdbxNz7RO/+tzWlZyZkVwVEaViNjdI4JAW3UV55byZsGY+w6Kvn8x1 3dRURRxOsDtz3zmDoS3rw3CgoL8H3+dyRg83tyVIdv3yGbhcLQ0f0K/aw9xaY58cAMmi Cua/xaOEE6WxrXr9Zys0BUSMmTp1LXEIjvcLDfJyuR0mw3Fg9XX+TAF4ntb9RpBWT1Yb B6oA== X-Gm-Message-State: AOAM533VmXSS3KKPrK0h4uQOrP5Y9hOqjSoJmdt58SXoRK39d8wrFaPj izybImV2BXgdvMwmM4q/1kBtMvUUeVImBlaFsgp0Qt+KrwT0Yi4lQ8/au+rQLMpzVyrkjsciKPX GZaoZJ6QxR1k= X-Received: by 2002:a5d:6750:0:b0:203:efaf:9fc1 with SMTP id l16-20020a5d6750000000b00203efaf9fc1mr21339407wrw.252.1648452831777; Mon, 28 Mar 2022 00:33:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8CVQchI+J8cFZu7EhBEKy/ErIlY77zkJwrFB6+EFgoMzhF+/lltIFD1/JP1p10sMWtyn2jw== X-Received: by 2002:a5d:6750:0:b0:203:efaf:9fc1 with SMTP id l16-20020a5d6750000000b00203efaf9fc1mr21339374wrw.252.1648452831464; Mon, 28 Mar 2022 00:33:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:2200:50d1:ff5c:5927:203a? (p200300cbc704220050d1ff5c5927203a.dip0.t-ipconnect.de. [2003:cb:c704:2200:50d1:ff5c:5927:203a]) by smtp.gmail.com with ESMTPSA id n65-20020a1c2744000000b003862bfb509bsm15389618wmn.46.2022.03.28.00.33.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Mar 2022 00:33:51 -0700 (PDT) Message-ID: <31c9ea16-2271-c616-3e32-ea0dc725a4c4@redhat.com> Date: Mon, 28 Mar 2022 09:33:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones To: Wei Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, mgorman@techsingularity.net References: <20220327024101.10378-1-richard.weiyang@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220327024101.10378-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: feqn3i5jqezc6o36fzsghcahft4mk1mz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0010540038 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iOZmXL+8; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1648452834-837857 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.03.22 04:41, Wei Yang wrote: > As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and > reclaim from zones with pages managed by the buddy allocator") , reclaim > only affects managed_zones. > > Let's adjust the code and comment accordingly. > > Signed-off-by: Wei Yang > --- > mm/vmscan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 7ad54b770bb1..89745cf34386 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1031,7 +1031,7 @@ static bool skip_throttle_noprogress(pg_data_t *pgdat) > for (i = 0; i < MAX_NR_ZONES; i++) { > struct zone *zone = pgdat->node_zones + i; > > - if (!populated_zone(zone)) > + if (!managed_zone(zone)) > continue; > > reclaimable += zone_reclaimable_pages(zone); > @@ -3912,7 +3912,7 @@ static bool pgdat_balanced(pg_data_t *pgdat, int order, int highest_zoneidx) > } > > /* > - * If a node has no populated zone within highest_zoneidx, it does not > + * If a node has no managed zone within highest_zoneidx, it does not > * need balancing by definition. This can happen if a zone-restricted > * allocation tries to wake a remote kswapd. > */ Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb