From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F07C87FD2 for ; Thu, 29 Aug 2024 18:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12C956B00B7; Thu, 29 Aug 2024 14:41:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08D306B00B8; Thu, 29 Aug 2024 14:41:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E71116B00BE; Thu, 29 Aug 2024 14:41:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C876A6B00B7 for ; Thu, 29 Aug 2024 14:41:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74438A8AC2 for ; Thu, 29 Aug 2024 18:41:57 +0000 (UTC) X-FDA: 82506152274.22.30A9FA9 Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 23ED2140017 for ; Thu, 29 Aug 2024 18:41:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=fFV3fCAd; spf=pass (imf09.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724956796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i4KVoHC/rTR85PP8ETqYzox9jgCZ/yEP3hbtTkzO924=; b=Q4w/pr/73bamm9MlgTwQd/52qUJFxjLIUSWmHhoXgQ+Zpl+xjaw35rH3jFOs6x/+lyQ83C tPdUAo8zQZeARvuM9wE9KDzYJmRFaAQJxAOQnWWsvBzpUz9BYL15CxzU40SDPCZSLNCvEA kdBjKUbfSQDb0G8wf0rtxLHUs4BKlBI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=fFV3fCAd; spf=pass (imf09.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724956796; a=rsa-sha256; cv=none; b=SpP0yFUGtTuolGaWkqWwSYBUOTDRjWNMHbZkuwMNaikC3Pf8pjKIPtsmJ93EsATH8lPqP9 Gl+4ur7Djvxq2UEFqt8TAecs3LySlKHxLDn2mr3zF6IFhtQCBJMaSSqCxvBWZhn/v7XM/l rzqkPToxTZPirVYxAh89hSSR6Zo7stQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1724956912; x=1725216112; bh=i4KVoHC/rTR85PP8ETqYzox9jgCZ/yEP3hbtTkzO924=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=fFV3fCAd2JCDywKRm0nBUrpg9pLzHjZjlKURxQwDT1clwRMsPHZH64UDHYVj5Dl6Z V5w4B/mYo8oY1GqGsrufC2ynGrxnEFT3etPzBZtGgpeXjcGSMCTZz56lTX0Fw11jJ8 t0imqDxXjw22c47TBinoK7Lhq6IVpYPDL71c2u6aS4ZWkUQNpOR0a8chl3SCOdGpwx eRqDo07yOBa4z2Y15Kyi/JZ9/CQzvAHc0krkM7G1JGMim0Zqwfd2I8gCedqfcth9RN nuTF0hBFylrmjmISrR+vm2UghpBgJACWmymtLESdCSA/5mQc0IP6+EN3M9XqAxp25b wNKihpoZgARuA== Date: Thu, 29 Aug 2024 18:41:49 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 20/26] rust: error: check for config `test` in `Error::name` Message-ID: <31c429a4-9cf4-4cd1-98fe-4be75ffadc50@proton.me> In-Reply-To: <20240816001216.26575-21-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-21-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: e7003a03934d6c259a79677b7b24467c965d107b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 23ED2140017 X-Stat-Signature: 4d3c5rqkobdbx17ou34n9nx3pgpzryes X-Rspam-User: X-HE-Tag: 1724956914-296311 X-HE-Meta: U2FsdGVkX1/bbNX0FcaKkv2gP095xlGEbEESgBZighMqlv2AI/VPWqkv4zKbsLxB8lbhyxqB0bKt3uVOTrFhE4g6jH3bCCT4802wwy99WrKo8vozNMN8u0hHPVvSUoEJ5sfLpOTHwyez/VAZ0iK4utvTXERVorkL++/IWOeJkBP+0d+pmNxTx1Z+z3GAAmXQ0eWm/XB7Is47VrBw1btwwtGsLQBQIzKjsBGWKAMCQrbozDDw/im+EmG+lznY5cSTY/sjS6RgTxE+i7s/ZXvFq+cSd099mWP5rZSrNhj5BXJr7Yf6Y+IlLdIwHIWeQXUIRd1jnKwN3+IkEj+lgyXG4xOkGQJhDNvH56fdkQYKAYgDt4gqrm2dQuh6Vl2BBOvKSrNuZcbQubYYngEr/MkaJAIGhmcOYOWZPmrY1k+q2IMSY3/jSw0WrdIzv0q9KGF9MGDJ1zVLnMFeh96WnU1irocy3rPxA/Gn7lG405waNEMMCNCktNDIklvfxYV6PctWScgqsPG9OyWDnMIYqJp3pEhG5yw4Ss86aZBKGVjeadKd1BZJFaw9Q1vIa3UCYV9WSt6QkTc1qlcxc4bRrZizViyUUWvTN7RuZaWa7FURf3mPioQMAdsgspSm0SLwZvwZVJ+9MYNHwcSltcrvNztdWAvfNzF6qBxqEZRHd1vpqAtTW6H9tNiAf9HqUm+Tp2jC6FrTQyWZDXAyP5dBWovvUMBrBF9ON7f+rYh200WT8S1o7r9xFElWZLTG9OmkVk0DjhAOIasyNmyFR9pAS7dvte1x0h7lISDIRsAbCcFZmI7b/NvcK9n6grBB0dsWJ+v5v2tV1rPeMXpJhiYWpx8b/gzdGRJNjP7s+eAcWXfDGIPqml8AL0/rofXQDCULQ/zynwn9pyCncVzJjcIgthq24zD/GrWAaqFCk2Z86EJGXMnvRmDSlow4iRnCmTDNcAh9TSrs4o7QB5sq8lAZDtZ VmeSbZY2 jgJCI+p1j0jBc0LDaBel4WAh5FKe1U2JezQSBYJoc4yqO0zm0lTXYqybIjSfacx+U6xwYmw8tNV5TPOiwyvHwFKPJwQ0Jyb3VJIEUINWcedQfFlEP17XLF53MiU+Ar5yDFJ0xi5o3EHk2+4fyObIQvOekrMl/hr43z6TlAUqq+kPQBtZhye259r3WVwikCIJQQMhEGGucwBeNnYYifNNlBqIIbkw3LLb3QTYKIO0IEDRY0Ped+6Fx/e4ADb3yj81Qdrhc2BneN7F7qBRK7BoeAusxxW4535vKLy2lyaPRoO6WCyBPUWGbn8Cr9Ufc6lGpArD4GjjNzfZ41Z1Et4+JcSJ/D7tCXmavhtWbyN+8zH7X3xMR0FGWQhYAcQVbpqHSOTNmCh8fzIPiZDbt0Ge2DogWBhSGUWjJPXeMCNMDOEZAs48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:11, Danilo Krummrich wrote: > Additional to `testlib` also check for `test` in `Error::name`. This is > required by a subsequent patch that (indirectly) uses `Error` in test > cases. >=20 > Reviewed-by: Alice Ryhl > Signed-off-by: Danilo Krummrich Reviewed-by: Benno Lossin --- Cheers, Benno > --- > rust/kernel/error.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs > index 2d012cc3881a..7adf889b9526 100644 > --- a/rust/kernel/error.rs > +++ b/rust/kernel/error.rs > @@ -140,7 +140,7 @@ pub(crate) fn to_ptr(self) -> *mut T { > } >=20 > /// Returns a string representing the error, if one exists. > - #[cfg(not(testlib))] > + #[cfg(not(any(test, testlib)))] > pub fn name(&self) -> Option<&'static CStr> { > // SAFETY: Just an FFI call, there are no extra safety requireme= nts. > let ptr =3D unsafe { bindings::errname(-self.0) }; > @@ -157,7 +157,7 @@ pub fn name(&self) -> Option<&'static CStr> { > /// When `testlib` is configured, this always returns `None` to avoi= d the dependency on a > /// kernel function so that tests that use this (e.g., by calling [`= Result::unwrap`]) can still > /// run in userspace. > - #[cfg(testlib)] > + #[cfg(any(test, testlib))] > pub fn name(&self) -> Option<&'static CStr> { > None > } > -- > 2.46.0 >=20