From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBCFC433DB for ; Wed, 20 Jan 2021 10:40:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A7562333C for ; Wed, 20 Jan 2021 10:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A7562333C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E3376B0007; Wed, 20 Jan 2021 05:40:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 092046B0008; Wed, 20 Jan 2021 05:40:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE8826B000A; Wed, 20 Jan 2021 05:40:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id DA08C6B0007 for ; Wed, 20 Jan 2021 05:40:00 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9C4DC1EE6 for ; Wed, 20 Jan 2021 10:40:00 +0000 (UTC) X-FDA: 77725808160.28.wash41_600041b27559 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 6F5AA6C36 for ; Wed, 20 Jan 2021 10:40:00 +0000 (UTC) X-HE-Tag: wash41_600041b27559 X-Filterd-Recvd-Size: 5303 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 Jan 2021 10:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611139199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RtHg9smHqxIpjluq3oLZYsQNrVvpjsSlKeat5q09TUI=; b=cR8SkLUmVPqMfnkRp/AW3QC6yUw0ej0mj3eYlXunLqrvsLc6FK/P61c837qVTLqait/gC2 UHSH7MzSdj84yO9PmiJqEkZPyHQK+dphqrWODBOrpgIg1DawzzzDEd6f/T+SqxXEqJ1Fk/ 7cdlp5BFpJzINWtcvdC5PH5z4jggZGs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-9yww2jV9OASCNtYxr91j0g-1; Wed, 20 Jan 2021 05:39:55 -0500 X-MC-Unique: 9yww2jV9OASCNtYxr91j0g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A2171005D44; Wed, 20 Jan 2021 10:39:53 +0000 (UTC) Received: from [10.36.115.161] (ovpn-115-161.ams2.redhat.com [10.36.115.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id A27FA5D9C2; Wed, 20 Jan 2021 10:39:50 +0000 (UTC) Subject: Re: [PATCH V3 3/3] s390/mm: Define arch_get_mappable_range() To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com Cc: Oscar Salvador , Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <1610975582-12646-1-git-send-email-anshuman.khandual@arm.com> <1610975582-12646-4-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <31c19215-3f25-4d60-29f6-77127c05abbb@redhat.com> Date: Wed, 20 Jan 2021 11:39:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.01.21 09:28, Anshuman Khandual wrote: > > > On 1/19/21 5:56 PM, David Hildenbrand wrote: >> On 18.01.21 14:13, Anshuman Khandual wrote: >>> This overrides arch_get_mappabble_range() on s390 platform which will be >>> used with recently added generic framework. It modifies the existing range >>> check in vmem_add_mapping() using arch_get_mappable_range(). It also adds a >>> VM_BUG_ON() check that would ensure that memhp_range_allowed() has already >>> been called on the hotplug path. >>> >>> Cc: Heiko Carstens >>> Cc: Vasily Gorbik >>> Cc: David Hildenbrand >>> Cc: linux-s390@vger.kernel.org >>> Cc: linux-kernel@vger.kernel.org >>> Acked-by: Heiko Carstens >>> Signed-off-by: Anshuman Khandual >>> --- >>> arch/s390/mm/init.c | 1 + >>> arch/s390/mm/vmem.c | 15 ++++++++++++++- >>> 2 files changed, 15 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c >>> index 73a163065b95..97017a4bcc90 100644 >>> --- a/arch/s390/mm/init.c >>> +++ b/arch/s390/mm/init.c >>> @@ -297,6 +297,7 @@ int arch_add_memory(int nid, u64 start, u64 size, >>> if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot)) >>> return -EINVAL; >>> >>> + VM_BUG_ON(!memhp_range_allowed(start, size, true)); >>> rc = vmem_add_mapping(start, size); >>> if (rc) >>> return rc; >>> diff --git a/arch/s390/mm/vmem.c b/arch/s390/mm/vmem.c >>> index 01f3a5f58e64..afc39ff1cc8d 100644 >>> --- a/arch/s390/mm/vmem.c >>> +++ b/arch/s390/mm/vmem.c >>> @@ -4,6 +4,7 @@ >>> * Author(s): Heiko Carstens >>> */ >>> >>> +#include >>> #include >>> #include >>> #include >>> @@ -532,11 +533,23 @@ void vmem_remove_mapping(unsigned long start, unsigned long size) >>> mutex_unlock(&vmem_mutex); >>> } >>> >>> +struct range arch_get_mappable_range(void) >>> +{ >>> + struct range memhp_range; >> >> You could do: >> >> memhp_range = { >> .start = 0, >> .end = VMEM_MAX_PHYS - 1, >> }; >> >> Similar in the arm64 patch. > > There is a comment block just before this assignment on arm64. Also > it seems like code style preference and Heiko had originally agreed > on this particular patch. Could we just leave it unchanged please ? That's not how review works. But as I said, "You could do". -- Thanks, David / dhildenb