From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0635C71157 for ; Tue, 17 Jun 2025 09:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84A956B009D; Tue, 17 Jun 2025 05:44:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 821F16B009F; Tue, 17 Jun 2025 05:44:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 710D66B00A0; Tue, 17 Jun 2025 05:44:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5C8F66B009D for ; Tue, 17 Jun 2025 05:44:39 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0A2F1120A62 for ; Tue, 17 Jun 2025 09:44:39 +0000 (UTC) X-FDA: 83564407878.09.83581D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 8144D180007 for ; Tue, 17 Jun 2025 09:44:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HzkAvfQ5; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750153476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdEh9cEys/eVA2SD9wfMRib1+LZeWMxS5mffwDFqNgM=; b=21bCo8eXvPJSYf2gQmUAXWOBcvWUobwbo6UM2NXC4GGz/DHMzFB7uLBnAsHkAwAenSPKKz 6oxhZbAjGWwjXtFlgIbG5dYazwtzHHviDYQMoYFVt1VniXdED5C0JIOn9cmxBkx6AW5gds KV06bBLmwIBbQ/QOyY38NQ2Foriexuc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HzkAvfQ5; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750153476; a=rsa-sha256; cv=none; b=eVVv+bdyMZtM+4aGEG3lZ28Bsx+THOcL2jrxsQyka+3XbDB9eVuPs/y4cngrR16cueTZnr uimmn6Hr4HK0QLzwAGgEeFh+W1y7mRdytOmE9HtfiEbnzJ2fYQCYXviwM7ueG8mXbxIECo llC85VrWS+6PTXRwAK33xQnb1FjY8YU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750153475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sdEh9cEys/eVA2SD9wfMRib1+LZeWMxS5mffwDFqNgM=; b=HzkAvfQ5MxcdicUALf8x+HJQ6rSnG6en5uVXFbpN5p7IIQg8wsyrYNKbvGRIfahqmatl66 bdDS32JdHJKsv+TlHV1MoFmk8t6EJwDoD1XHnrdkQ5k7lovxogAD7ftAczwnfDO7+nAEcm F5e1O3jlh6AtTAu8gH/HK6fOh8tf/5o= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-i3lfYDOpOuWKXfGiz8AADg-1; Tue, 17 Jun 2025 05:44:34 -0400 X-MC-Unique: i3lfYDOpOuWKXfGiz8AADg-1 X-Mimecast-MFC-AGG-ID: i3lfYDOpOuWKXfGiz8AADg_1750153473 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45311704d1fso31175685e9.1 for ; Tue, 17 Jun 2025 02:44:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750153473; x=1750758273; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sdEh9cEys/eVA2SD9wfMRib1+LZeWMxS5mffwDFqNgM=; b=Is5EUkNasDCycYT8LS9+JTcLUVOv8O6GB97+l1firmdLgKhkEXh8TQMhy3cNMDOWz5 DbEAv94EtO5KF1JlR2hd12hATTwo9zlCa+5yAI0XDmkR7wPhUXS7CaUgnYtOoTLHlWhP EUCKSGjPgTeEfnmfb7oWh5PlxRQ5y3nPG8zhEi6whPRXIZXre6FnS/v0XO3IzfYJQM1E FLvAL3fjXUohae24CEP+WvBb/MUpXyCrZAAZFuQs9lmxX1iokGEaZp8AI6yVKAtKgWUJ C0w1orP9BKkm52ebwVq05+Cf9vOKBEtBW7lUqGFNLkjEdu8Yf1uXCVJGSe7Rbvh2PwTu /w/Q== X-Gm-Message-State: AOJu0YwU6Rj/VHCD9B6rZ7NPOgOYKoDZdyMDKrA+XGraWHbZQOcAfOQf dyxEBw5SFqMCznFh/dUcs3Hjsddydqsj7oN14A/DYKm896q9F2E7ygMWp73WN5fhSlikbCK47Zf I9R0eTzg8/lOVl2qlGYAYxYUrO6KRZTWeCciRoSOiurdqK+X5tIObeHxr/yrzFJo= X-Gm-Gg: ASbGncuQEGaxsGj1FY2b5GULmElVCkUBtQs+xW9BmpaveRflvXkvJDOctx40zB0Y/3b jh+lJcZ962D/lh7bSooWKrjNcfQaqwzos+vekmkra0sQYj7TxI4PKV87M9aI4Jp902s9X+wgY1o ruEDiEUscJCRflz7c+MNHJY6FipZcsSssTRBcti1SXhYB6vi3DPMLX9DZiY2AzyJxxTT+wavsYi NTVgOIutGEqPT9aOmEncZ0CQIbaVHnMFP3dPz9hYyV/MxMiZbIm0ipMNywjMCPaB5p7LvJoZBzK h1P7sGXcXH64cesARWt0iIumons5byX0/9fP3YNfrrNRsvVrpqTJrnWA/EJI+ExO/FgJ1nxrxEM O+lct7UrRNk9Gkd+hYgJZ8OAw3miKioVONtM6WVD4z7Lvb5A= X-Received: by 2002:a05:6000:65a:b0:3a5:88e9:a54f with SMTP id ffacd0b85a97d-3a588e9a99bmr1291324f8f.1.1750153473101; Tue, 17 Jun 2025 02:44:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHQpVd3mwZ+TEDjCXC20DL1F3MMRYh4Y/yZHPnb93a/Bf/b7RyUJmn1/nXnnPCK9NELoBd4w== X-Received: by 2002:a05:6000:65a:b0:3a5:88e9:a54f with SMTP id ffacd0b85a97d-3a588e9a99bmr1291288f8f.1.1750153472667; Tue, 17 Jun 2025 02:44:32 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b4b67bsm13257644f8f.83.2025.06.17.02.44.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 02:44:31 -0700 (PDT) Message-ID: <31bdbfcf-bbfa-46b7-a427-806d42d88cec@redhat.com> Date: Tue, 17 Jun 2025 11:44:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/14] mm/khugepaged: Remove redundant pmd_devmap() check To: Alistair Popple , akpm@linux-foundation.org Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net, m.szyprowski@samsung.com, Jason Gunthorpe References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _vn4ia8HtlFB-aZsEj7yFF690sFSBJw4Ym_nS2R2uCI_1750153473 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8144D180007 X-Stat-Signature: bp6659botrybwdxncfanpmi8rfhg4m4c X-Rspam-User: X-HE-Tag: 1750153476-93179 X-HE-Meta: U2FsdGVkX18vwroNo0pWylR65R/9xHvg1WzN85txjD5ODiUaflMOgp28lH4pifHPPONsVlmEnWnlRDjYyigjitYc2g0ZMUFvsSQY3cYZ7YEUlZgfF4GiqI7xL6cVCc1AT5Sh8oalZmIyQmYyjA/aeNZzfJ8zrsbs/Syhw23z0+4kA7ZFAZj/4fXNChWAhJqM+ZTrLqHJpUhepz3Lur/qNK6gY3co/hfAfZP1krW/G9XJMRb4Qf8Kym0BFcBw5RwMsVuTvcVO0MOzKScV/elhwtavdng5TAZNj9arwrU9zL9FrpbIfFxak94sSL62IPVAJj6WpDru0UilTUnsF00WQ/5spZqRfAtLmd5cMJ4HJn/6dop+lVf/ukP3v7WYwVqFWWt38UGciqjTp2CvGDt2qQUuF+aEwSP3ObrwxHjN6fIHsigA22IMTPwz3hN0OSpu4es3CDeoMzEUoG3iJ2N4mHzOIgLKTm+V01eww+UE9V97FmlOPal/C7T/hexvOsw8e/HmZ1WPq5SK91/NzU7HFRQ4AOvIsbzEwePuw35x1a6C5P3ZMlnUljBljVhwUCOLqmCBsgNlUQMssyJ87ZXeMH1wh7d6U8LPSQRH9dlGhGZNVhXbkmuNaTGA7WFcF+KLUTwREcuOwn+oYpnyEHDDQWkyB9EeffSvvGIHEXSyR1hp98QCKKMB8xJO5PHCo1t4TiiFaq+s4GFyYmfnvCLWIvRmg5eSXhgvv61iI2wfs2ih7OpTx6w8p9TeuwJR0ERx3sIu1it4jOBzOyCrAKUzxG6g3CT6rjHgYEOhzltupKA7oXk8wBbBn+WHQulZD5ZfI5ZQcNVPqVhqzFHtum3H7Pi/XCN7bspYVBBWYYMLEjOSgf7MwZ58FFL7zStw07OtPM9E+uUBlFd6e09po9fiNFgEilVKVq2pJ97VKVpyf5VCL9Ur40E4MqTUOH3p2idDZ9Y9rv++J7DW32aAwp3 YoFeCpgz utiOQugkbgb2eECvY8tpQk2J+6QDNVTqQFywh5litLsoMIMexbr4FcdX7WeqJCm9Yj0CPEagHYaP/x7bQDHlCtHssyRvL7RBPNGSR8jbgXmTlrhVZpm8y7a0IfQSIEaYdcIcRHSozQJSy8ounq/w7GORhARSsEmG63GrS9JAkuwmJqh4uCghQtYesAhLxVmHK1n3Ya4tV/Ff5fmeLIHAV+yJ/jqhE/eZqbG0oGtawt/DSdWdpQvgBe8rAswdShh0kgUBBmOqbPCTUmct0ibYz469fjxZcQsISrBd5jiljYTivqcWH84Jy5aKP5JwuiZi4f6624Q3z+SCSvs8A5FsphqKXL/fWBH4k+Hjc2TeXx+hkF7ngBlme3PKqup2yLVdyeHKMcCb8WZiMwMg6T/WIkyB234xXtihNQeyAZbb6uneYnS/mg7gDfrr31lreq2fjD5petGFAMQteFcNtlBfOYBshiQZn8aSyAfXmD5Etj/xlV/dArxs68Xjy6Scv9T9bEnIOdrsNluprZ8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.06.25 13:58, Alistair Popple wrote: > The only users of pmd_devmap were device dax and fs dax. The check for > pmd_devmap() in check_pmd_state() is therefore redundant as callers > explicitly check for is_zone_device_page(), so this check can be dropped. > Looking again, is this true? If we return "SCAN_SUCCEED", we assume there is a page table there that we can map and walk. But I assume we can drop that check because nobody will ever set pmd_devmap() anymore? So likely just the description+sibject of this patch should be adjusted. FWIW, I think check_pmd_state() should be changed to work on pmd_leaf() etc, but that's something for another day. -- Cheers, David / dhildenb