From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480D2C54791 for ; Thu, 22 Feb 2024 16:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D34AD6B0088; Thu, 22 Feb 2024 11:31:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE5116B0089; Thu, 22 Feb 2024 11:31:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B87286B008A; Thu, 22 Feb 2024 11:31:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A6D7D6B0088 for ; Thu, 22 Feb 2024 11:31:40 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7A6B2120EBC for ; Thu, 22 Feb 2024 16:31:40 +0000 (UTC) X-FDA: 81819980760.09.6D4777A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 3E0EC14002E for ; Thu, 22 Feb 2024 16:31:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LX0k5rzP; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708619498; a=rsa-sha256; cv=none; b=T7egwBbpDW8iOA4IvNPFqOhQFrOhQE9f/Yluxi461SiCvN46V1sjMnOlD/ZH/zhtZXVV81 KQX2kdiS6h1fYl/Sdi94fYF7j6VEkZj2/+Dw7sSpcphSx9/ukMPexIPCwmmLwQrce6/PCr t1sl2n1HM58sVYqOiSHw8mumE2oGZZs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LX0k5rzP; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708619498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TB+h9Y4eFs4+OFe3k2AYgGN2x3TMYZr1cM9XcIH8U2o=; b=gf4o//EJaPDVw/NhjAnsrSlFckEz3XrLC8YZ3GYkIntVJxMRIvI+pet4Af0+ssVg7EpTKN kc+83pSmFn+47sJqF6msjrvzIDK6lFQ51XZOZbwXhM+A/qykoGFYv2kwru+78bh2ekq3SU gM1L7MQfPJDejIRaQ2Ug7AJzjtAvIP4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708619497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TB+h9Y4eFs4+OFe3k2AYgGN2x3TMYZr1cM9XcIH8U2o=; b=LX0k5rzPALVh/Qg/IZ3KrujS5LSusPBOHzPTr7h7gbGJQgX5x6pAPpHiaibz2/NCbDDJVf vy6JDKjMOTcljKV6z2Q3yePiBLkx/7NB272rL+j7ZFXg4BIYogLWMo7Oo3EbiDwY4iht9V 8Lzs82PQD2TmN5uAjO6+ZBSQVhpZSPo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-NqQFChEKP0S2zm8wtcvH1Q-1; Thu, 22 Feb 2024 11:31:36 -0500 X-MC-Unique: NqQFChEKP0S2zm8wtcvH1Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33d7e755f52so789326f8f.1 for ; Thu, 22 Feb 2024 08:31:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708619495; x=1709224295; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TB+h9Y4eFs4+OFe3k2AYgGN2x3TMYZr1cM9XcIH8U2o=; b=JG6Mej685rUe0Vei7zbxGmU5fZmFoJ8JCWKUXm0dYgqfS0xwNL42oTBaXb5rfM2lMM GFVhU6O4mnv+mimGvNM7xvVA5bA/mwvyQq6nMqWwzDKOdBpo4ElLiMkF0rkBQEwE3k6i 8xEMzEiJl+FuWXNezt8tGc0OQQ6E3pFscONwzeN4CokjrKe08VZbRVOlXdpAHT5HBpCV 1fnL9EXojfMscJblbrx2zFwz6249HllCO2FcDNtr7uztGCGdVgqsafJwz7b1NiySpP2O WkM8a22MWvrimc9c+RXXXTSezUzB6YMmPpH+F5KpLxhzohhMWwU2e/lglrQa1FSfun3k w8dQ== X-Forwarded-Encrypted: i=1; AJvYcCU5MMmvti/xOt8+ak3rwNuGWDuJUDO6MJaQVMMC4hkLgxUymaU38JdQM+5TZs6/ZF0RRK/0mVcqLOX8u7XPtiuEo4g= X-Gm-Message-State: AOJu0YyB56npanrxBcI2ryqVLsCWuh/iDQLhL6Grrem9KXfQIgANIYQH uZKnHNrrvdPDJdqOy38bvQKewk4yTJ3JBasc/Jiw8vu+DQ4yf+CqC30bIs2958cmcsqZ/1/xcIM hsrDIp5Yv8FcDgJ/if0sI2xEqqv1bFJUo1nuHseJPd1s8K6nb X-Received: by 2002:a5d:6502:0:b0:33d:9c51:1776 with SMTP id x2-20020a5d6502000000b0033d9c511776mr1043958wru.10.1708619494887; Thu, 22 Feb 2024 08:31:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoKDx3jiXb3rrusVpzPdxnnhBRUGcwZtr+Ib0j5hFRv2sJu+SXFU64P9IUmHTMFwaMi35C3Q== X-Received: by 2002:a5d:6502:0:b0:33d:9c51:1776 with SMTP id x2-20020a5d6502000000b0033d9c511776mr1043946wru.10.1708619494530; Thu, 22 Feb 2024 08:31:34 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id i3-20020a05600011c300b0033cf453f2bbsm20825934wrx.35.2024.02.22.08.31.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 08:31:34 -0800 (PST) Message-ID: <31bade75-316c-4f3a-9325-1e347975f93c@redhat.com> Date: Thu, 22 Feb 2024 17:31:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/util.c: Added page count to __vm_enough_memory failure warning To: Matthew Cassell Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240221160235.1771-1-mcassell411@gmail.com> <1547a955-cee6-40e1-8231-0bd1229de0f3@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3E0EC14002E X-Stat-Signature: tw6p5r9zggafd9zxnfp8ioufbhsp1zoa X-Rspam-User: X-HE-Tag: 1708619498-671950 X-HE-Meta: U2FsdGVkX18snQwVKhvJp3ViukSpHL3AbOP4L2rG8CN39+LFsqUOUpt/6AomKmFW+64JgKBddWjCG1dNurV3S9/OnPQjfnflnpficcgjkkQmimbhJr2f+0G2Vvh4Gl4jK2Fkh4f9LE4Sz9EGvriRYnhAA3y7lGA519Htq3b/gUvFxg3Ve+jtOreouVz0No9dMumvB//Ku2VwyMDR/8gh/A2OuSfI5lDp80cJ/aQ+QHdnmXkj5F06+SHbcBjNJd8JNo9/Utoj7CJHuWAghfGCI+LfybzVP7U7wCLBB6bzGCMNws8rhEdAnAixZU3vvz0k6dwuc8wUEGqIhRQH/zw7akyo+SurctDlOJ+SG9LXfc58sPEzkVpIBgDfxzM8R5xg6BEy4Gd600H3y9PMy15yHC4qkwNXAWMvTO/bWY99IYDHR/1CeNX73l66EjYcNdk9r/RAgCtkjd2TxT4bBnEIAGF0wA0waNXcCavDWFBN0m5bwzSFRCaF0YU8k/0ivGJ8kcrlcso9DOgQw+2A27CqrjvtXrRhxOAaP8stztzFS5MSJZ/3eGHrFV1PNG1HrikZGNpqWugUX4B8iQJVzC+ghxevTyFUSXy++kmWKZp1Y0LwevkK9KqCOrDppmyqc24dBlcTVIMyMzDTAIXa1Ry2ltmhnBVcvoJ50Y3vPkYwqkZJlfa5Ru/1CGoYe62vDC3i7SvLxIdsx+5pApPiWky9moyuEoxR/oQQA/spOSmI9mIxaim45z0Bc3W9Qg5VM62FLcNEvUXWe9NQQQUG7h1c/kSbWtqvd+5SA9P0i4n0YYfBCFJpKuokMmtfbuiZxtTcwPWrfXgJWqveZp9Rmbrv8/+OtCY1dyNsjQGeEnHM++uO2J5iVsxhUI6zd/fK2gVimb6NYTqjvhRBwNOEPqSufu1+UA/1NHFu//Fgd9OPSE5uGLep3/DJLyP7el7MPC17oINX8hUxGyURSXyXW5r GirUv4w3 k9MV5mzFEm7hIjygX3F7JzUUf8rw1VJ2j+M3O4xsIJrEYRWUvFGyIl+67IzT8YBKf3TCpEILcZ/o8JoxfKxSunpdIpY6nGpN955kwhRW1KyGkA6S4UPUNk6Y2hXfqybS4XrpLTAKVW+EvZ/Ol4E9uoShFVXJNcXLHKlyRI6FY6uVlD9pGSpmoaxzxY9+DXtDSmj+fgJzg0jaCIxe4YQ0Na+IX9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001899, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.02.24 17:24, Matthew Cassell wrote: > Resending due to plain-text email issue that caused mailing list to get skipped. > > Thank you for the feedback. I agree with you and would prefer to use > bytes/kbytes. Here are the 2 concerns that led to me keeping it as > pages: > > > 1. Reduce the impact of the patch. Here is the call trace to reach the > failure warning: > > <… usual mmap() stuff …> > mmap_region() -> security_enough_memory_mm() -> __vm_enough_memory() > > Within mmap_region(), the length variable originally passed to mmap() > gets right-shifted to get the page count. My first thought was to add > an additional an additional argument to security_enough_memory_mm() of > type unsigned long to keep that variable, but saw a handful of calls > to it that would have to conform to the change. Not that I do not > think this debug statement does not warrant that, I felt the less > impact, the better. > > > 2. Concerned about losing bits. When converting back to bytes I was > worried about the loss of precision and printing that number back to > users: > > unsigned long bytes_failed = pages << (PAGE_SHIFT); > In which scenario would you imagine that we lose precision? In other words, how would someone be able to create a VMA that is larger than what we can fit into an unsigned long in bytes? I'd simply print "pages << PAGE_SHIFT" here and not worry about that :) -- Cheers, David / dhildenb