From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B609C433EF for ; Thu, 21 Apr 2022 09:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAEB76B0071; Thu, 21 Apr 2022 05:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5DFC6B0073; Thu, 21 Apr 2022 05:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8BE6B0074; Thu, 21 Apr 2022 05:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 8DE2D6B0071 for ; Thu, 21 Apr 2022 05:15:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5558932B4 for ; Thu, 21 Apr 2022 09:15:46 +0000 (UTC) X-FDA: 79380328692.27.9610009 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 7CDA8180025 for ; Thu, 21 Apr 2022 09:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650532545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjbrFR2rd1qLIkWt8BR0K+aE+G8bE2tFsHPUNoUm3Lc=; b=WdUIltEtfscYoN5rw50XGnkLuhLwiDd/TnjQOL6ZqH7x9ncFlAo05tWN5+6Gv5QrOJDQ2T 42lskp8YMksLSfjwnBIaP8EOXvYOYluhZGsYt1IgL19na4XuIgfyo0WrEQwnM1D8xdE5Lh qL165K5JFCPy2vLi73cdAWMhf1vUiw4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-501-mimFyULHM1KatjHkqoodxQ-1; Thu, 21 Apr 2022 05:15:42 -0400 X-MC-Unique: mimFyULHM1KatjHkqoodxQ-1 Received: by mail-wr1-f70.google.com with SMTP id d16-20020adfa410000000b0020ab103f0daso913668wra.8 for ; Thu, 21 Apr 2022 02:15:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=FjbrFR2rd1qLIkWt8BR0K+aE+G8bE2tFsHPUNoUm3Lc=; b=TZYhNIlRAHDqDsMU+K7LLWmff2UU7tUuS6J/+/O7R8A0yJHY2IvE6iLL99pFJnl21z mrTlV8ECiaM10NXbS1S4m0vvTZ1MXXg6Ea7lpa4FHm4JNfk/xBhc08qM0df3zpw6Z42T QzTcaZksbue1HtAcnniojVrNy0nIVQpL3nXekU5UWPeWcmfTL762/nVZNwFqQxo3WSYO SHhhlLW0Y0M+m9yOUAmWgKEDPgO0NglHfv6cjB0Z3B+6TBOAOoUQg3JE/UyDv13BNqCN X8+olGz1hK7YzjzT7sDA7gs+hDrzLq2dvyTSETIy9tHbWnSBKAgqS2OaEry87mIN05TA HCpg== X-Gm-Message-State: AOAM531Ox/uHBs1zFLbXnZtiHK7FHEzL7UudmEuHtW0lbj6RAdeLtTyU EErJbW59sOppZv0OnamzTO81NUMjLVUmXYc+0ZjC8b1FSrTUvMw1MqieuiVdp/tRgMYX1HagIqv /ZlT+i1WCinU= X-Received: by 2002:a7b:c5d1:0:b0:37f:a8a3:9e17 with SMTP id n17-20020a7bc5d1000000b0037fa8a39e17mr7420547wmk.109.1650532541075; Thu, 21 Apr 2022 02:15:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybhViWdGUkp8BlFKuS91mClSpg6lIAaDSHqaAhU8UVIOCqoiWdlZ9Z1I212vYDASNuQITD4g== X-Received: by 2002:a7b:c5d1:0:b0:37f:a8a3:9e17 with SMTP id n17-20020a7bc5d1000000b0037fa8a39e17mr7420518wmk.109.1650532540774; Thu, 21 Apr 2022 02:15:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:de00:711b:76af:b335:9b70? (p200300cbc702de00711b76afb3359b70.dip0.t-ipconnect.de. [2003:cb:c702:de00:711b:76af:b335:9b70]) by smtp.gmail.com with ESMTPSA id r17-20020a0560001b9100b00207afaa8987sm2160122wru.27.2022.04.21.02.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 02:15:40 -0700 (PDT) Message-ID: <31b37b7c-a969-eec2-bdff-a7e4dca9b770@redhat.com> Date: Thu, 21 Apr 2022 11:15:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 16/16] mm/gup: sanity-check with CONFIG_DEBUG_VM that anonymous pages are exclusive when (un)pinning To: Vlastimil Babka , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , linux-mm@kvack.org References: <20220329160440.193848-1-david@redhat.com> <20220329160440.193848-17-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7CDA8180025 X-Stat-Signature: dci7cnw5ddkdedpuprnbia4woxsx5jqq Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WdUIltEt; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1650532544-760877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.04.22 19:40, Vlastimil Babka wrote: > On 3/29/22 18:04, David Hildenbrand wrote: >> Let's verify when (un)pinning anonymous pages that we always deal with >> exclusive anonymous pages, which guarantees that we'll have a reliable >> PIN, meaning that we cannot end up with the GUP pin being inconsistent >> with he pages mapped into the page tables due to a COW triggered >> by a write fault. >> >> When pinning pages, after conditionally triggering GUP unsharing of >> possibly shared anonymous pages, we should always only see exclusive >> anonymous pages. Note that anonymous pages that are mapped writable >> must be marked exclusive, otherwise we'd have a BUG. >> >> When pinning during ordinary GUP, simply add a check after our >> conditional GUP-triggered unsharing checks. As we know exactly how the >> page is mapped, we know exactly in which page we have to check for >> PageAnonExclusive(). >> >> When pinning via GUP-fast we have to be careful, because we can race with >> fork(): verify only after we made sure via the seqcount that we didn't >> race with concurrent fork() that we didn't end up pinning a possibly >> shared anonymous page. >> >> Similarly, when unpinning, verify that the pages are still marked as >> exclusive: otherwise something turned the pages possibly shared, which >> can result in random memory corruptions, which we really want to catch. >> >> With only the pinned pages at hand and not the actual page table entries >> we have to be a bit careful: hugetlb pages are always mapped via a >> single logical page table entry referencing the head page and >> PG_anon_exclusive of the head page applies. Anon THP are a bit more >> complicated, because we might have obtained the page reference either via >> a PMD or a PTE -- depending on the mapping type we either have to check >> PageAnonExclusive of the head page (PMD-mapped THP) or the tail page >> (PTE-mapped THP) applies: as we don't know and to make our life easier, >> check that either is set. >> >> Take care to not verify in case we're unpinning during GUP-fast because >> we detected concurrent fork(): we might stumble over an anonymous page >> that is now shared. >> >> Signed-off-by: David Hildenbrand > > Acked-by: Vlastimil Babka > > Nits: > >> @@ -510,6 +563,10 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, >> page = ERR_PTR(-EMLINK); >> goto out; >> } >> + >> + VM_BUG_ON((flags & FOLL_PIN) && PageAnon(page) && >> + !PageAnonExclusive(page)); > > Do we rather want VM_BUG_ON_PAGE? Also for the same tests in mm/huge*.c below. Make sense, thanks: diff --git a/mm/gup.c b/mm/gup.c index 5c17d4816441..46ffd8c51c6e 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -564,8 +564,8 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, goto out; } - VM_BUG_ON((flags & FOLL_PIN) && PageAnon(page) && - !PageAnonExclusive(page)); + VM_BUG_ON_PAGE((flags & FOLL_PIN) && PageAnon(page) && + !PageAnonExclusive(page), page); /* try_grab_page() does nothing unless FOLL_GET or FOLL_PIN is set. */ if (unlikely(!try_grab_page(page, flags))) { diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 390f22334ee9..a2f44d8d3d47 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1392,8 +1392,8 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, if (!pmd_write(*pmd) && gup_must_unshare(flags, page)) return ERR_PTR(-EMLINK); - VM_BUG_ON((flags & FOLL_PIN) && PageAnon(page) && - !PageAnonExclusive(page)); + VM_BUG_ON_PAGE((flags & FOLL_PIN) && PageAnon(page) && + !PageAnonExclusive(page), page); if (!try_grab_page(page, flags)) return ERR_PTR(-ENOMEM); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 8a635b5b5270..0ba2b1930b21 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6100,8 +6100,8 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma, pfn_offset = (vaddr & ~huge_page_mask(h)) >> PAGE_SHIFT; page = pte_page(huge_ptep_get(pte)); - VM_BUG_ON((flags & FOLL_PIN) && PageAnon(page) && - !PageAnonExclusive(page)); + VM_BUG_ON_PAGE((flags & FOLL_PIN) && PageAnon(page) && + !PageAnonExclusive(page), page); /* * If subpage information not requested, update counters -- Thanks, David / dhildenb